On 9/10/20 12:00 AM, Alexey Makhalov wrote:
[snip]
>>>>> Fixes: 781b3e5efc3 ("tftp: Do not use priority queue")
>>>>
>>>> Please drop this line.
>>>>
>>>
>>> Same question here. I think is important information, specially for
>>> downstream since they could allow people to decide whether they need
>>> to backport this patch or not.
>>
>> You duplicate the information which is above. Additionally, IMO "Fixes:"
>> should contain bug number, CVE number, link to the bug, etc. not the
>> commit id.
>
> I think “Fixes: commit id” should remain in place. It provides direct
> information
> from what commit the bug existed in case of regression.
>
Yes, I think the same. For example I usually do git log --grep="Fixes:", but
don't have a strong opinion and I'm OK with dropping it if Daniel prefer that.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
