Re: [PATCH v2] Create Containerfiles with required grub packages for development

On Mon, 30 Jun 2025 14:15:59 -0600 Leo Sandoval wrote: > On Mon, Jun 30, 2025 at 1:45 PM Glenn Washburn > wrote: > > > On Fri, 20 Jun 2025 18:03:41 -0600 > > Leo Sandoval via Grub-devel wrote: > > > > > Containers bring the ability to have ready-to-use

Re: [PATCH v2] Create Containerfiles with required grub packages for development

On Fri, 20 Jun 2025 18:03:41 -0600 Leo Sandoval via Grub-devel wrote: > Containers bring the ability to have ready-to-use environments and in > this case complete Fedora and Debian container files are described > containing all required packages for building and testing grub2. > > Once users man

[PATCH] fs/zfs: Fix another memory leak in ZFS code

Commit b66c6f918 ("fs/zfs: Fix a number of memory leaks in ZFS code") fixes many of the same leaks detected in bug #63846 except one, which is fixed here. Fixes: https://savannah.gnu.org/bugs/?63846 Signed-off-by: Glenn Washburn --- Reviewing some of the bugs on Savannah, I noticed #6

[PATCH] tests: Disable gfxterm_menu and cmdline_cat tests

Those tests fail depending on the version of unifont. As we don't distribute our own unifont it fails for most users. Disable them so that they don't mask real failures. They can be reinstated once we solve unifont problem. Signed-off-by: Glenn Washburn --- This is my version of Vladim

Re: [PATCH] Disable gfxterm_menu and cmdline_cat tests

On Tue, 8 Apr 2025 18:51:38 + Vladimir Serbinenko wrote: > Those tests fail depending on the version of unifont. As we don't distribute > our own unifont it fails for most users. Disable them so that they don't mask > real failures. They can be reinstated once we solve unifont problem Does

Re: [PATCH] ntfs: Fix attribute validation check

me that's a separate issue. Tested-by: Glenn Washburn Glenn > > Signed-off-by: Vladimir Serbinenko > --- > grub-core/fs/ntfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/fs/ntfs.c b/grub-core/fs/ntfs.c > index b3117bf92..393a

Re: [PATCH v3] fs/ntfs: Correct NULL Deref / Possible Infinite Loop

e clarification. My email was send to raise awareness, as I hadn't seen this issue being discussed on the list. Glad to know that this issue is known and being worked on. Much appreciated, carry on. Glenn > > > Thanks, > Andrewkernel/printk/printk.c > > On Thu, May 1

Re: [PATCH v3] fs/ntfs: Correct NULL Deref / Possible Infinite Loop

On Thu, 20 Mar 2025 18:28:00 -0500 Andrew Hamilton wrote: > A regression was introduced recently as a part of the series of > filesystem related patches to address some CVEs found in GRUB. > > This issue may cause either an infinite loop at startup when > accessing certain valid NTFS file system

Re: [PATCH] Disable gfxterm_menu and cmdline_cat tests

On Tue, 8 Apr 2025 18:51:38 + Vladimir Serbinenko wrote: > Those tests fail depending on the version of unifont. As we don't distribute > our own unifont it fails for most users. Disable them so that they don't mask > real failures. They can be reinstated once we solve unifont problem > > S

Re: [PATCH 1/3] Use ET_DYN instead of ET_REL modules

On Tue, 8 Apr 2025 15:16:23 + Vladimir Serbinenko wrote: > ET_DYN also known as .so files are actually meant to be loaded dynamically. > Most of the work of linking is done by normal linker and we need to do > only simple relocation by offset. This significantly simplifies our > dynamic load

Re: [PATCH] fs/zfs: Fix a number of memory leaks in ZFS code

On Mon, 10 Mar 2025 11:23:59 -0500 Stuart Hayes wrote: > Without this fix, grub failed to boot linux with "out of memory" after > trying to run a "search --fs-uuid..." on a system that has 7 ZFS pools > across about 80 drives. > > Signed-off-by: Stuart Hayes > --- > grub-core/fs/zfs/zfs.c

Re: [PATCH v2 0/6] Various test fixes proposed by Thomas Schmitt

On Tue, 04 Mar 2025 10:56:15 +0100 "Thomas Schmitt" wrote: > Hi, > > Tested-by: Thomas Schmitt > > with remaining unrelated problems. > > --- > Test details: > > The patch series applied by "git am" without problems to a bra

Re: [PATCH v3 09/10] tests/tpm2_key_protector_test: Amend the NV index mode test

On Mon, 13 Jan 2025 11:07:12 +0800 Gary Lin via Grub-devel wrote: > Since 'grub-protect' already supports NV index mode, tpm2_seal_nv() is > replaced with one 'grub-protect' command to simplify the test script. > > Two more NV index test cases are also added to test key sealing and > unsealing w

[PATCH] tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS

-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments) Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 4867b6786895..228939a34d16 100644

[PATCH] tests/util/grub-shell-luks-tester: Find cryptodisk by UUID

header contains the UUID. Also, capitalize comment lines for consistency. Signed-off-by: Glenn Washburn --- tests/util/grub-shell-luks-tester.in | 35 +--- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/tests/util/grub-shell-luks-tester.in b/tests/util

[PATCH v2 3/6] tests/grub_cmd_cryptomount: Cleanup the cryptsetup script unless debug is enabled

This fixes an issue where the grub_cmd_cryptomount test leaves a file with an ambiguous name in the / directory when TMPDIR is not set. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/grub_cmd_cryptomount.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests

[PATCH v2 5/6] tests/grub_cmd_cryptomount: Remove temporary directories if successful and debug is not on

From: Thomas Schmitt grub_cmd_cryptomount creates a directory per subtest. If a subtest is successful and debugging is not on, the directory should be empty. So it can be deleted. Signed-off-by: Glenn Washburn --- tests/grub_cmd_cryptomount.in | 9 + 1 file changed, 9 insertions

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

On Sun, 02 Mar 2025 09:41:28 +0100 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > Seems like running them the tests before > > committing large patch series, like this security update, might be a > > good idea. > > I think that any change

[PATCH v2 4/6] tests/grub_cmd_cryptomount: Default TMPDIR to /tmp

This fixes behavior where grub_cmd_cryptomount temporary files, which are some times not cleaned up, are left in the / directory. Set TMPDIR if your system does not have /tmp or it can not be used for some reason. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests

[PATCH v2 2/6] tests: Cleanup generated files on expected failure in grub_cmd_cryptomount

Signed-off-by: Glenn Washburn --- tests/grub_cmd_cryptomount.in| 1 + tests/util/grub-shell-luks-tester.in | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in index f4d8f35473d0..63ed8e51bec3 100644 --- a

[PATCH v2 0/6] Various test fixes proposed by Thomas Schmitt

ilure. * Add patch #5 to remove empty directories left by the cryptomount tests. Glenn Washburn (5): tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup tests: Cleanup generated files on expected failure in grub_cmd_cryptomount tests/grub_cmd_crypto

[PATCH v2 1/6] tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup

Set the RET variable to the exit status of the script, as was assumed in the cleanup() function. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/util/grub-shell-luks-tester.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/grub-shell-luks-tester.in b/tests

[PATCH v2 6/6] tests/util/grub-shell: Remove the work directory on successful run and debug is not on

This removes alot of empty grub-shell working directories in the TMPDIR directory. Signed-off-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 15c5f45a5c30

Re: [PATCH v2] loader/efi/chainloader: Add efidriver command

On Sat, 26 Oct 2024 10:24:05 +0500 Nikita Travkin via Grub-devel wrote: > Nikita Travkin писал(а) 24.09.2024 21:29: > > Sometimes it's useful to load EFI drivers. Since loading a driver is > > the same as starting it and UEFI handles cleanup after on it's own, we > > can piggy back on existing ch

Re: [PATCH v2 0/4] EFI envblk

Daniel, Is this still in the to be reviewed queue? Despite how long its been, I believe this patch series still applies cleanly to master. Glenn On Mon, 23 Sep 2024 01:04:54 -0500 Glenn Washburn wrote: > Update v2: > * Rebase onto current master. This really did not change the conte

[PATCH v6 3/6] commands/ls: Show modification time for file paths

fit of reducing code complexity. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 2eaefaf9027a..1b447acf7c34 100644 --- a/grub-c

[PATCH v6 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13

[PATCH v6 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Washburn v6: * Rebase onto current master *

[PATCH v6 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 1b447acf7c34..886441575cac 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file

[PATCH v6 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index

[PATCH v6 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 886441575cac

[PATCH v6 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index f660946a24e4..65b17768b605 100644 --- a/grub-core/commands/ls.c +++ b/grub-core

Re: [SECURITY PATCH 18/73] fs/ntfs: Implement attribute verification

On Fri, 28 Feb 2025 14:04:51 +0100 Daniel Kiper via Grub-devel wrote: > Huh! > > B Horn, may I ask you to take a look at this and prepare a fix? > > Andreas, please help with testing the fix. Not that anyone cares, but this regression was caught by the file system tests. It causes grub-fstest

[PATCH v5 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 886441575cac..8f6440e845fd 100644

[PATCH v5 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 1b447acf7c34..886441575cac 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file

[PATCH v3] acpi: Use options enum to index command options

Signed-off-by: Glenn Washburn --- v3: * Specify first enum const value * Fix improperly using OPTION_EXCLUDE instead of OPTION_LOAD_ONLY v2: Rebase to current master --- Range-diff against v2: 1: 8b14fcf62f88 ! 1: a51e20bb9b10 acpi: Use options enum to index command options @@ grub-core

[PATCH v5 3/6] commands/ls: Show modification time for file paths

fit of reducing code complexity. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 2eaefaf9027a..1b447acf7c34 100644 --- a/grub-c

[PATCH v5 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index

[PATCH v5 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13

[PATCH v5 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Washburn v5: * Rebase onto current master *

[PATCH v5 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index f660946a24e4..65b17768b605 100644 --- a/grub-core/commands/ls.c +++ b/grub-core

Re: [PATCH v2] acpi: Use options enum to index command options

On Fri, 28 Feb 2025 15:39:28 +0100 Daniel Kiper wrote: > On Fri, Jan 03, 2025 at 12:11:14AM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > This should be a quick review. > > > > v2: Rebase to current master > > > > G

Re: [PATCH v4 5/6] commands/ls: Print full paths for file args

On Mon, 24 Feb 2025 18:14:59 +0100 Daniel Kiper wrote: > On Mon, Jan 06, 2025 at 01:02:43AM -0600, Glenn Washburn wrote: > > For arguments that are paths to files, print the full path of the file. > > > > Signed-off-by: Glenn Washburn > > --- > > grub-core/

Re: Arch Linux latest git snapshot has too many issues to be a new release base

On Thu, 20 Feb 2025 12:27:12 +0100 Tobias Powalowski via Grub-devel wrote: > Hi Daniel, > > according to my unanswered mail 2 days ago, we tried to bump grub to > latest git snapshot. > > It failed for my co-maintainer in 2 cases: > > - loopback device seems to be broken > > - encrypted devi

[PATCH] gitignore: Ignore generated files from libtasn

s they are not under revision control. Signed-off-by: Glenn Washburn --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 2105d87c8a9c..524f2e6d0070 100644 --- a/.gitignore +++ b/.gitignore @@ -141,10 +141,12 @@ widthspec.bin /grub-core/kernel.img.bin /

[PATCH v4 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13

[PATCH v4 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index e33c16158d63..384d3e3cede8 100644

[PATCH v4 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index

[PATCH v4 3/6] commands/ls: Show modification time for file paths

fit of reducing code complexity. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 43ee6aca085a..ed296a536554 100644 --- a/grub-c

[PATCH v4 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 6a1c7f5d3626..9e69b19371d5 100644 --- a/grub-core/commands/ls.c +++ b/grub-core

[PATCH v4 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Washburn v4: Add missing parenthesis Glenn W

[PATCH v4 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index ed296a536554..e33c16158d63 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file

[PATCH] commands/file: Fix null dereference in the knetbsd tests

From: Lukas Fink The pointer returned by grub_elf_file() is not checked to verify it is not null before use. A null pointer may be returned when the given file does not have a valid ELF header. Fixes: https://savannah.gnu.org/bugs/?61960 Signed-off-by: Lukas Fink Signed-off-by: Glenn Washburn

Re: [PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM VG

Hi Patrick, It looks like you're not using the --thread option for git format-patch. Would you please use that for the next version? That option will keep the patch set together for those with email clients with threaded view. Thanks. Glenn On Sat, 4 Jan 2025 15:16:59 -0500 Patrick Plenefisch w

[PATCH v3 3/6] commands/ls: Show modification time for file paths

fit of reducing code complexity. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 43ee6aca085a..b0f139cf133a 100644 --- a/grub-c

[PATCH v3 6/6] commands/ls: Add directory header for dir args

Like the GNU ls, first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 17 + 1 file changed, 13

[PATCH v3 4/6] commands/ls: Output path for single file arguments given with path

Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index b0f139cf133a..e671313e6a0e 100644 --- a/grub-core/commands/ls.c +++ b/grub-core/commands/ls.c @@ -108,6 +108,8 @@ print_file

[PATCH v3 5/6] commands/ls: Print full paths for file args

For arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index e671313e6a0e..a419174a81a5 100644

[PATCH v3 2/6] commands/ls: Merge print_files_long and print_files into print_file

Simplify the code by removing logic around which file printer to call. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index

[PATCH v3 0/6] More ls improvements

Considering Daniel's feedback on the v2 of this patch series, I've broken up patches #1 and #2 and dropped patch #3 from the original series. These changes make the output of the ls command a little more like the GNU ls output. Glenn Glenn Washburn (6): commands/ls: Return proper

[PATCH v3 1/6] commands/ls: Return proper GRUB_ERR_* for functions returning type grub_err_t

Also, remove unused code. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 6a1c7f5d3626..9e69b19371d5 100644 --- a/grub-core/commands/ls.c +++ b/grub-core

[PATCH] docs: Do not reference non-existent "--dumb" option

This appears to be a relic from GRUB legacy that used a --dumb option for its terminal command. The proper way to do this in GRUB2 is to set the temrinal to "dumb" via the terminfo command. Fixes: https://savannah.gnu.org/bugs/?66302 Reported-by: Jernej Jakob Signed-off-by: Glen

[PATCH] docs: Replace @lbracechar{} and @rbracechar{} with @{ and @}

Support for @lbracechar{} and @rbracechar{} was added in GNU Texinfo 5.0, but many older systems may have versions lower than this. Use @{ and @} to support a wider range of GNU Texinfo versions. Signed-off-by: Glenn Washburn --- docs/grub-dev.texi | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2] acpi: Use options enum to index command options

Signed-off-by: Glenn Washburn --- This should be a quick review. v2: Rebase to current master Glenn --- Range-diff against v1: 1: fbaf2eb14231 ! 1: 8b14fcf62f88 acpi: Use options enum to index command options @@ grub-core/commands/acpi.c {"exclude", 'x', 0

Re: [PATCH v2 0/3] More ls improvements

Ping. Wondering if this is still in the queue to be looked at. Glenn On Sat, 8 Jun 2024 16:58:30 -0500 Glenn Washburn wrote: > Currently when given a path to a file, ls will open the file to determine > if its is valid and then run the appropriate print function, in contrast to >

Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting

Ping. Wondering what might be holding this up from being merged? Glenn On Thu, 5 Sep 2024 20:37:11 -0500 Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > docs/grub.texi | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH v1 10/15] env: Add efi-export-env and efi-load-env commands

On Thu, 31 Oct 2024 13:42:53 -0600 Leo Sandoval wrote: > From: Peter Jones > > This adds "efi-export-env VARIABLE" and "efi-load-env", which manipulate the > environment block stored in the EFI variable > GRUB_ENV-91376aff-cba6-42be-949d-06fde81128e8. I would prefer that this patch and patch #

Re: [PATCH v8 10/10] efi: Disallow fallback to legacy Linux loader when shim says NX is required.

Hi Daniel, Looks like this and the two patches preceding this were not merged into git, nor do I see discussion or hints that they would be dropped. Is this intentional? Glenn On Wed, 9 Oct 2024 09:16:45 +0100 Mate Kukri wrote: > Signed-off-by: Mate Kukri > --- > grub-core/kern/efi/sb.c

Re: grub menu gets stuck issue report and fix patch merge request

Hi 段亚勇, I think you will get more of a response if you use git-send to send this patch inline (not attached), and to CC Daniel (Daniel Kiper ). And do periodically check back in. I have the feeling that Daniel is overwhelmed with some large patch sets and may take some time to get to this. Glenn

Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

> if [ -z "$debug" ] && [ "${RET:-1}" -eq 0 ]; then > > > rm -rf "$lukstestdir" || : > > > fi > > Glenn Washburn wrote: > > RET should never be undefined because $? always has a numerical value. > > And in m

Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

On Fri, 27 Sep 2024 13:59:35 +0200 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > [...] grub-shell-luks-tester cleans up after > > itself, if it returns success. grub_cmd_cryptomount has a test that > > expects failure. But grub-shell-luks-te

Re: [PATCH v6 3/6] Adjust import script, definitions and API users for libgcrypt 1.11

On Wed, 11 Sep 2024 12:34:18 +0300 Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko > --- > autogen.sh| 5 + > conf/Makefile.common | 4 +- > grub-core/Makefile.core.def | 36 ++- > grub-core/comm

Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

On Thu, 26 Sep 2024 22:44:20 +0200 "Thomas Schmitt" wrote: > Hi, > > i wrote: > > > I meanwhile forgot why i proposed > > > > +unset TMPDIR > > > but there was some theoretical reason for this ... > > Glenn Washburn wrote: > > M

Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

On Mon, 23 Sep 2024 17:52:00 +0200 "Thomas Schmitt" wrote: > Hi, > > The patches apply without complaints by "git am". > > But when i run (again as superuser, shudder): > > make check TESTS=grub_cmd_cryptomount > > i still get in /tmp the empty direcories /tmp/17*.LUKS2_*. > > > Minor nit

[PATCH v2 2/4] efi: Add efi-export-env and efi-load-env commands

b_guid_t, module name bug, missing return bug, memory leaks, formatting Add support for specifying multiple variables at once for efi-export-env. Signed-off-by: Glenn Washburn --- docs/grub.texi | 24 + grub-core/Makefile.core.def | 6 ++ grub-core/c

[PATCH v2 4/4] efi: Print GDB command for loading symbols if variable exists

If the variable "enable_earlyinit_gdbinfo" exists, print the GDB command needed to properly load symbols in an attached GDB session. This variable must come from the environment block stored in the GRUB_ENV EFI variable, which allows this to get printed as early as possible. Signed-off

[PATCH v2 3/4] tests: Add efienv_test for testing efi-export-env and efi-load-env

Signed-off-by: Glenn Washburn --- Makefile.util.def| 6 + tests/efienv_test.in | 57 2 files changed, 63 insertions(+) create mode 100644 tests/efienv_test.in diff --git a/Makefile.util.def b/Makefile.util.def index 0f74a1680f13

[PATCH v2 1/4] efi: Load env block from GRUB_ENV EFI variable in early init

From: Peter Jones This allows setting GRUB variables before any user interaction or GRUB script can run. It is primarily intended to be used to turn on early debugging. Signed-off-by: Peter Jones Replace grub_efi_guid_t -> grub_guid_t Signed-off-by: Glenn Washburn --- grub-c

[PATCH v2 0/4] EFI envblk

lly have a preference. Glenn [1] https://mail.gnu.org/archive/html/grub-devel/2023-03/msg00072.html Glenn Washburn (2): tests: Add efienv_test for testing efi-export-env and efi-load-env efi: Print GDB command for loading symbols if variable exists Peter Jones (2): efi: Load env block from G

Re: [PATCH] tests: Let grub_cmd_cryptomount by default operate in /tmp rather than in /

On Sun, 18 Aug 2024 23:41:16 +0200 "Thomas Schmitt" wrote: > Hi, > > i post this as base of discussion, not yet as sincere patch proposal. > > It seems desirable to bundle the temporary data of each particular test > in tests/grub_cmd_cryptomount.in in a single directory, as it seems > intended

[PATCH 3/4] tests: Default TMPDIR to /tmp in grub_cmd_cryptomount tests

This fixes behavior where grub_cmd_cryptomount temporary files, which are some times not cleaned up, are left in the / directory. Set TMPDIR if your system does not have /tmp or it can not be used for some reason. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests

[PATCH 2/4] tests: Cleaup the cryptsetup script in grub_cmd_cryptomount unless debug is enabled

This fixes an issue where the grub_cmd_cryptomount test leaves a file with an ambiguous name in the / directory when TMPDIR is not set. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/grub_cmd_cryptomount.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests

[PATCH 0/4] Various test fixes proposed by Thomas Schmitt

Thomas Schmitt proposed variations on these fixes[1]. I've broken his patch into several patches with improvements. Glenn [1] https://lore.kernel.org/all/9956308756800479...@scdbackup.webframe.org/ Glenn Washburn (4): tests/util/grub-shell-luks-tester: Add missing line to creat

[PATCH 1/4] tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup

Set the RET variable to the exit status of the script, as was assumed in the cleanup() function. Reported-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/util/grub-shell-luks-tester.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/grub-shell-luks-tester.in b/tests

[PATCH 4/4] tests/util/grub-shell: Remove the work directory on successful run and debug is not on

This removes alot of empty grub-shell working directories in the TMPDIR directory. Signed-off-by: Thomas Schmitt Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index ae5f711fe26c

Re: [PATCH 9/9] grub-shell: Explicitly specify firmware for i386-ieee1275

On Wed, 11 Sep 2024 12:37:35 +0300 Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko > --- > tests/util/grub-shell.in | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in > index 4b0900a32..de1eba83e 100644 > --- a/tes

Re: [PATCH 6/9] cmd_set_date: Ignore garbage line at shutdown

On Wed, 11 Sep 2024 12:37:32 +0300 Vladimir Serbinenko wrote: > Fedora arm-efi and riscv64-efi are verbose and add a garbage line > when shutting down. Ignore it Shouldn't the trim_tail modifications in patch 1 and 5 obviate the need for this? And why is the text being tested changed? I presume

Re: [PATCH 1/9] grub-shell: Support riscv64-efi

On Wed, 11 Sep 2024 12:37:27 +0300 Vladimir Serbinenko wrote: > Signed-off-by: Vladimir Serbinenko > --- > tests/util/grub-shell.in | 43 +++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell

[PATCH] docs: Fix incorrect and potentially confusing language and minor formatting

Signed-off-by: Glenn Washburn --- docs/grub.texi | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 63e796a3a738..e6e5efa05e6c 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4538,11 +4538,12 @@ files. @node

Re: [PATCH v15 3/3] fs/erofs: Add tests for EROFS in grub-fs-tester

ought also about just disabling the label tests, but I would rather not. I think the version of mkfs.erofs should be checked and only run the label tests if the version is >= 1.6. Glenn > > > Thanks, > > Yifan Zhao > > > On 2024/6/10 3:33, Glenn Washburn wrote: > >

Re: [PATCH v15 3/3] fs/erofs: Add tests for EROFS in grub-fs-tester

On Tue, 21 May 2024 01:20:59 +0800 Gao Xiang wrote: > From: Yifan Zhao > > In this patch, three tests of EROFS are introduced and they cover > compact, extended and chunk-based inodes, respectively. > > Signed-off-by: Yifan Zhao > Reviewed-by: Glenn Washburn > R

[PATCH] tests: Switch to requiring exfatprogs from exfat-utils

of 22 bytes of UTF-16 characters in the volume label compared to 30 bytes from exfat-utils. So the exfat label test is updated accordingly. Update documentation to not that exfatprogs is now needed and also exfat-fuse, which is needed do the fuse mount. Signed-off-by: Glenn Washburn --- IN

[PATCH] tests/util/grub-shell-luks-tester: Fix detached header test getting wrong header path

, otherwise leave it unset. The second statement sets it to itself if it is already set, otherwise it is set to $luksfile. Fixes: a7b540e6e (tests: Add cryptomount functional test) Signed-off-by: Glenn Washburn --- tests/util/grub-shell-luks-tester.in | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH 2/2] tests/util/grub-shell: Add flexibility in QEMU firmware handling

ephemeral VARS file that can be written to without causing side-effects for other tests. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 104 --- 1 file changed, 96 insertions(+), 8 deletions(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub

[PATCH 1/2] tests/util/grub-shell: Use pflash instead of -bios to load UEFI firmware

f the default i440fx, for i386-efi because the default machine type does not emulate a flash device, which is now needed to load the firmware. [1] http://www.linux-kvm.org/downloads/lersek/ovmf-whitepaper-c770f8c.txt Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 15 +++ 1

[PATCH 0/2] Better UEFI firmware handling in tests

The first patch moves away from using -bios which appears to be a best practice. And the second patch allows the firmware to be found in the source directory or system directory, in case the tester does not want to use system firmwares or is not on a Debian system. Glenn Glenn Washburn (2

[PATCH] tests/util/grub-shell: Print gdbinfo if on EFI platform

Allow using GDB to debug a failing QEMU test. This output does not cause issues for tests because it happens before the trim line, and so will be ignored. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/util/grub-shell.in b

[PATCH] configure: Add Debian/Ubuntu dejavu font path

Signed-off-by: Glenn Washburn --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 99aae8700d72..d4a14bf937e1 100644 --- a/configure.ac +++ b/configure.ac @@ -1847,7 +1847,7 @@ if test "x$with_dejavufont" = x; then #

[PATCH v2 3/3] commands/ls: Proper line breaks between arguments

wastes valuable screen space. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index 10939eefeab5..0a3070372821 100644 --- a/grub-cor

[PATCH v2 1/3] commands/ls: Allow printing mtime for file arguments

directories. This also has the added benefit of simplifying the code path. Signed-off-by: Glenn Washburn --- grub-core/commands/ls.c | 76 - 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c index

  1   2   3   4   5   6   7   8   9   10   >