On Sun, 02 Mar 2025 09:41:28 +0100
"Thomas Schmitt" <scdbac...@gmx.net> wrote:

> Hi,
> 
> Glenn Washburn wrote:
> > Seems like running them the tests before
> > committing large patch series, like this security update, might be a
> > good idea.
> 
> I think that any change of the filesystem code should be tested as
> much as possible.
> But it is quite some hurdle that some of the tests need to be run as
> superuser. Leaking temporary files further reduces the appeal.

Yes, not ideal. I have spent an embarrassing amount of time developing
scripts that do away with with root requirement, and it works. The way
they are able to run the root required tests as an unprivileged user is
by compiling a user mode linux kernel and running the tests in the UML
process. Would you be interested in trying out these scripts?

The leaking of temporary files is also annoying, but quite easy to
remedy. One need only set the TMPDIR to a directory and delete the
directory when done. 

> 
> I wonder what happened to the fixes for the file leaks of
> grub_cmd_cryptomount which we discussed in
>   https://lists.gnu.org/archive/html/grub-devel/2024-09/msg00222.html
> and follow-ups. The discussion went on until
>   https://lists.gnu.org/archive/html/grub-devel/2024-10/msg00054.html
> I fail to see "grub_cmd_cryptomount" in git log since october 2024
> or a commit by Glenn Washburn which would address this issue.
> 
> Was there a problem found of which i am not aware ?

Thank you for the reminder. I suspect what happened is that Daniel read
the thread and expected a v2 based on some changes discussed but not
reflected in the series, and so chose not to review the patch series. I
meant to send a v2, but hadn't gotten around to it. It is now sent and
now that the security patches are out, hopefully Daniel will be able to
get to them soon.

Glenn

> 
> 
> Have a nice day :)
> 
> Thomas
> 

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to