On Thu, 26 Sep 2024 22:44:20 +0200 "Thomas Schmitt" <scdbac...@gmx.net> wrote:
> Hi, > > i wrote: > > > I meanwhile forgot why i proposed > > > > + unset TMPDIR > > > but there was some theoretical reason for this ... > > Glenn Washburn wrote: > > My guess was that you wanted to unexport TMPDIR. > > Yes. The reason was that i wanted to limit the effect of exporting to > the run of grub-shell-luks-tester, just in case that any further code > does not expect exported TMPDIR. I think its fine in this case. But might be good for future proofing. I'll think about it. > > > > > LUKS2 test with argon2 pbkdf: XFAIL > > > XFAIL means "expected fail", so its okay. > > But why doesn't it clean up then ? This was an oversight. So grub-shell-luks-tester cleans up after itself, if it returns success. grub_cmd_cryptomount has a test that expects failure. But grub-shell-luks-tester doesn't know that this is an expected failure and should cleanup and grub_cmd_cryptomount doesn't ever cleanup after grub-shell-luks-tester. Perhaps grub-shell-luks-tester should be passed a parameter to indicate expected failure (eg. --xfail). Have any other ideas? Glenn > This particular sub-test leaves not only the empty ./mnt firectory but > also a 20 MB device image (?) and some small data files. > > All other sub-tests of tests/grub_cmd_cryptomount leave a neatly empty > directory which grub_cmd_cryptomount can rmdir after the sub-test is done. > > > Have a nice day :) > > Thomas > _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
