verse video)
This is possibly the problem that libbfd cannot not convert PE to ELF
properly.
Unfortunately the grub-pe2elf tool does support pe-i386 but not pei-i386.
I will try to fix this next week.
--
Regards,
Christian Franke
___
Grub-devel mailing
note -R .comment
> -o kernel.img kernel.exec.exe
>
Did the core.img actually work as expected then?
Thanks for the problem report.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
BVK Chaitanya wrote:
On Sat, Aug 28, 2010 at 5:53 PM, Christian Franke
<...> wrote:
$ grep ^grub_bin2h_LD Makefile
grub_bin2h_LDADD = libgrub.a
grub_bin2h_LDFLAGS = $(AM_LDFLAGS) $(LDFLAGS_PROGRAM) $(LIBINTL)
$(LIBDEVMAPPER)
The above should be:
grub_bin2h_LDADD = libgrub.a $(L
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
rovides a list of necessary
development packages.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
sall%cl, %edx
movl$64, %ecx
orl %eax, %edx
movl%edx, %eax
sall%cl, %eax
orl %edx, %eax
ret
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
This change is already included in Cygwin package grub-1.98-2.
-
+ test -z "$needmap" || cat<
This is already considered in the script: $needmap is set if ntldr is
found but
This change is already included in Cygwin package grub-1.98-2.
--
Regards,
Christian Franke
=== modified file 'ChangeLog'
--- ChangeLog 2010-05-05 19:19:55 +
+++ ChangeLog 2010-05-05 20:09:01 +
@@ -1,3 +1,9 @@
+2010-05-05 Christian Franke
+
+ * util/grub.d/10_windo
t/
$ grub-mkrelpath /mnt/boot/
I actually did not test the "/" corner case, sorry. New patch attached.
--
Regards,
Christian Franke
=== modified file 'ChangeLog'
--- ChangeLog 2010-04-26 01:35:55 +
+++ ChangeLog 2010-04-26 09:44:43 +
@@ -1,5 +1,17 @@
2
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
+ /* Include leading slash. */
+ offset = 0;
+ break;
Why do you make this change? It seems to make the behaviour of
make_path_relative_to_its root inconsistent since E.g.
This fixes build of grub-emu on Cygwin, works also for
--enable-grub-emu-modules.
--
Regards,
Christian Franke
=== modified file 'ChangeLog'
--- ChangeLog 2010-04-19 10:34:56 +
+++ ChangeLog 2010-04-19 15:31:52 +
@@ -1,3 +1,10 @@
+2010-04-19 Christian Franke
+
+ * config
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
According to 'gcc -dumpspecs' of Cygwin gcc 4.3.4-3, options '-u
___[de]register_frame_info' are always passed to the linker if
-static-libgcc is not specified. This is Cygwin and MinGW spe
--
Regards,
Christian Franke
=== modified file 'ChangeLog'
--- ChangeLog 2010-04-18 11:00:06 +
+++ ChangeLog 2010-04-18 14:39:41 +
@@ -1,3 +1,12 @@
+2010-04-18 Christian Franke
+
+ * include/grub/util/getroot.h (grub_get_prefix): Remove prototype.
+ * util/getroot.c [__CYGWI
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
The Cywin path handling is broken since
make_system_path_relative_to_its_root() functionality was moved from
the lib script to misc.c.
This patch should fix this. It reuses the Cygwin specific
Gettext support is not effective for the grub tools (except scripts)
because localedir is not passed to the Makefile.
2010-04-16 Christian Franke
* Makefile.in: Add missing localedir setting.
--
Regards,
Christian Franke
=== modified file 'Makefile.in'
--- Makefile.in
function.
I would suggest to remove grub_get_prefix(), it is now only used in
grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the patch,
should be done in a separate commit.
2010-04-14 Christian Franke
* util/grub-mkconfig_lib.in (make_system_path_relative_to_its_root
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
The *_frame_info symbols are set undefined to force linkage of the
libgcc_s shared library or dll.
This can be prevented by TARGET_LDFLAGS=-static-libgcc. To build from
grub-1.98 tarball on Cygwin, run conf
e of the
libgcc_s shared library or dll.
This can be prevented by TARGET_LDFLAGS=-static-libgcc. To build from
grub-1.98 tarball on Cygwin, run configure with this argument.
May also be necessary on other build platforms when -shared-libgcc is
the default. It may be possible simpl
This fixes a regression in grub-pe2elf which breaks build on Cygwin.
2010-03-03 Christian Franke
* util/grub-pe2elf.c: Add missing include "progname.h".
This fixes build on Cygwin.
--
Regards,
Christian Franke
=== modified file 'util/grub-pe2elf.c'
--
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
Hi Robert,
Robert Millan wrote:
Please be careful when adding modules. I see that too often new modules
are added without any real need to host this code separately.
...
kern/disk.c:
g a global function pointer
'grub_disk_ata_pass_through' is a hack. A cleaner design would be
possible with a grub_disk_dev.ioctl(.) call.
--
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Nando wrote:
It's great to have hdparm output added. Another fixup that would be
needed would be setting the ATAPI cable mode to be 80pin, rather than
the slower 40pin. Users who add hard drives in place of PATA optical
drives are liked affected. Eg:
http://forum.notebookreview.com/showthread
able as a Cygwin package, 1.97 will be provided when
binutils regression is fixed.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
ass-through functionality. A 'hdparm -X' would only help if the actual
boot works with ata.mod instead of biosdisk.mod.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
10], 20));
>
> It's not unusual to see stuff like this, but again, a small percent of
> translators will actually try to figure out if the string is correctly
> aligned or how many \t's they need to use (by manually calculating ho
pthru
# Turn APM off
hdparm -B 255 (ata0)
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
make sense
for any load command. For 'ntldr': check that the file size is
reasonable and that code starts with a jmp instruction. Allow to
override the check with '--force'.
--
Regards,
Christian Franke
___
Grub-de
2, EXE header at 0x4d40, PE at 0x4e10
bootmgr.exe from Vista: ???
grub4dos checks for ntldr as follows:
- file starts with 0xe9, 0x??, 0x01,
- first sector does not end with bootsector signature 0x55,0xaa,
- file size exceeds 0x3.
--
Regards
Christian Franke
compile time by half and generate module
file much smaller that the current format.
Tested successfully on Cygwin - Nice work!
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub
ably would make sense that the 'ntldr' command does simple
signature checks and fail on unknown files unless '--force' is specified.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
is missing.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
the hint, I will try objconv it soon.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
No.
Then building a Cygwin package would rely on the existence of (tested or
untested?) binaries in the a release tarball. Building packages from SVN
snapshots would no longer be possible.
I really don't want to spent my open-source-time with such kind of
feature removal :-)
--
it weird
Agree.
A 'ntldr' or 'chainloader --ntldr' command is not mandatory. But it is
'nice to have' because it allows to boot even if the boot code (6
sectors) in the area behind the PBR is not present for whatever reason.
See my previ
han a year
Commit 1726 is from 2008-07-24, start was here:
http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00452.html
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
y described that here:
http://lists.gnu.org/archive/html/grub-devel/2007-11/msg00233.html
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Robert Millan wrote:
> On Sat, Aug 01, 2009 at 05:06:46PM +0200, Christian Franke wrote:
> >
> > Since ~r1584, util/grub-* could be build and run on Cygwin. Commit
> > r1726 added support to build kernel and modules on Cygwin.
> >
>
> There has to be more to i
Robert Millan wrote:
On Fri, Jul 31, 2009 at 08:27:58PM +0200, Christian Franke wrote:
First of all, I'm worried that we have discussions to decide things and they
are later forgotten or ignored. Bean, please can you provide some explanation
on what happened?
Also, I think this c
hich we need to preserve win32 support at all costs.
$ find grub2 -type f -name '*.[ch]' | xargs cat | wc -l
128175
$ cat grub2/util/grub-pe2elf.c | wc -l
521
0.4% of the total LoC is IMO less than 'all costs' :-)
--
Regards
Christian Franke
Pavel Roskin wrote:
On Fri, 2009-07-24 at 23:02 +0200, Christian Franke wrote:
A correct performance-aware solution would look like:
#ifdef DT_DIR
if (de->d_type == DT_DIR)
info.dir = 1;
else if (de->type == DT_FILE)
There in no DT_FILE in glibc, but there is DT_REG.
was actually wrong in my original patch (svn 1353) that was
necessary because of missing d_type on Cygwin - Sorry! Meantime I added
d_type support to Cygwin itself and therefore learned how this is
supposed to work :-)
--
Regards,
Christian Franke
_
ring is "1.96+20090702-1-r2391" or "1.96+20090702-1" if
'svn info' is not available.
The string is added to grub title only, utils are left out for now.
Regards,
Christian Franke
2009-07-02 Christian Franke
Auto-generate a snapshot version string fo
Pavel Roskin wrote:
On Fri, 2009-06-19 at 22:05 +0200, Christian Franke wrote:
This was the AC_MSG_RESULT(...) for the
AC_MSG_CHECKING([for option to link raw image])
which is still present for the "$grub_cv_apple_target_cc" != "yes" case.
I would suggest to move
MSG_CHECKING outside the 'if
"$grub_cv_apple_target_cc" = "yes" ... fi' and re-add the AC_MSG_RESULT.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Pavel Roskin wrote:
We can use -Wl,--defsym,___main=0x8100 as it's done elsewhere in
configure.ac. Let me just check it doesn't break anything.
This (r2310) works on Cygwin, thanks.
--
Regards,
Christian Franke
___
Grub-devel ma
orks you can
commit it since we never do complete linking for target
Complete linking is not used during build but during configure. The
following tests rely on it:
grub_PROG_LD_BUILD_ID_NONE
grub_CHECK_BSS_START_SYMBOL
grub_CHECK_END_SYMBOL
I would suggest to undo commit 229
ccording to gcc 4.3.2 man page, '-nostdlib' usually
requires '-lgcc'.
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
ely, T13 docs are (unlike T10 and SATA-IO) still publicly available:
http://www.t13.org/Documents/MinutesDefault.aspx?DocumentType=4&DocumentStage=2
--
Regards,
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Pavel Roskin wrote:
On Sat, 2009-05-23 at 23:04 +0200, Christian Franke wrote:
New patch attached. Please test on the above hardware if possible.
It's working fine. (ata6) and (ata7) appear, but (ata0) and (ata1)
doesn't. When inserting ata.mod, I get:
error: error r
Christian Franke wrote:
Pavel Roskin wrote:
It helps detect CD-ROM under qemu. But on the real hardware, it
introduces ghost drives.
Without the patch, I have (ata7) for the SATA hard drive. With the
patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW
and two bogus
Pavel Roskin wrote:
On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote:
The attached patch should fix this. It should also prevents misleading
error messages if a device does not exist.
It helps detect CD-ROM under qemu. But on the real hardware, it
introduces ghost drives
The attached patch should fix this. It should also prevents misleading
error messages if a device does not exist.
2009-05-20 Christian Franke
* disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status
register.
(grub_ata_identify): Suppress error message if
ssumption that
device detection through the READY bit is safe. It was added to speed-up
the detection of the missing slave port of some SATA controllers working
in IDE-mode. The check can be safely removed, the only drawback is an
extra ~1s timeout for each SATA controller.
I will commit a fix soon.
--
CC patch I just remove it
'grub_start_addr' and '.globl start, _start' are also not used.
--
Christian Franke
diff --git a/configure.ac b/configure.ac
index a048828..e799a79 100644
--- a/configure.ac
+++ b/configure.ac
@@ -212,15 +212,13 @@ AC_MSG_CHECKING([for option t
ed Paths:
--
trunk/grub2/commands/i386/pc/drivemap_int13h.S
Function drivemap.c:install_int13_handler() copies the
grub_drivemap_handler code to some low memory allocated by
grub_mmap_malign_and_register(). No relocation is done. IMO the code
must be position independent.
--
C
to force NESTED_FUNC_ATTR on all functions used as an
argument to the same function.
7) The grub utils may not run on some 'security hardened' platform which
does not allow to enable stack execution.
--
Christian Franke
___
Grub-devel maili
lag buts sets
format2 to ~0U ('infinite' :-) if no precision is specified.
Thanks
--
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
e could you provide this in unified diff format? (diff
> -u)
I already added (fixed) the precision parsing and added handling of '%s'
precision (truncation):
http://svn.savannah.gnu.org/viewvc/trunk/grub2/kern/misc.c?root=grub&r1=1936&r2=1954
The parsing pa
Christian Franke wrote:
There is no warning, because none of the headers define _POSIX_C_SOURCE.
This should read: There is a warning, because features.h defines
_POSIX_C_SOURCE :-)
--
Christian Franke
___
Grub-devel mailing list
Grub-devel
# define _POSIX_C_SOURCE 200112L
# endif
#endif
I would suggest to remove the #define and commit the patch.
BTW: compiles fine on Cygwin, with or without the #define.
--
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lis
This is not necessary on Cygwin. Its /usr/bin/install handles the .exe
issue itself, such that most existing Makefiles work OOTB.
Please make sure that /usr/bin/install and no other install is found in
the PATH.
--
Christian Franke
___
Grub-devel
Alexandre Bique wrote:
On Thu, Feb 26, 2009 at 2:35 PM, Christian Franke
<...> wrote:
What is the error message you got on Cygwin ?
The problem is that make install installs elf binaries and not win32
binaries. But win32 binaries are compiled. I moved win32 binaries by
hand.
p'.
What is the error message you got on Cygwin ?
--
Christian Franke
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Robert Millan wrote:
On Sat, Feb 21, 2009 at 07:00:06PM +0100, Christian Franke wrote:
Very interesting. Do you think any of these features could be useful as a
default option in grub-mkconfig?
At least the --health check and --security-freeze are IMO recommended
for each disk
Robert Millan wrote:
On Sat, Feb 14, 2009 at 03:13:31PM +0100, Christian Franke wrote:
insmod ata_pthru
(note that module dependencies should make this unnecessary)
This insmod is necessary for now. hdparm.mod does not directly call
ata_pthru.mod, it uses kern/disk.c
phcoder wrote:
Hello. Here is bugfix
Thanks!
Yes, I should rename all occurences...
(gcc 3.4.4 did not detect this).
Committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Christian Franke wrote:
...
New patch below. Function grub_ata_pass_through() now moved to new
module ata_pthru.mod.
Committed. Now also includes a SMART status check.
grub.cfg example (assumes ata.mod is used):
...
insmod ata_pthru
insmod hdparm
# Make sure disks cannot be locked by an
Robert Millan wrote:
On Sun, Feb 08, 2009 at 12:12:32AM +0100, Christian Franke wrote:
Robert Millan wrote:
I would suggest to move grub_ata_pass_through() to a new module (e.g.
ata2.mod, atax.mod, ataex.mod, ...)
How about ata_something.mod? (consistent with ntfs.mod
Robert Millan wrote:
On Sun, Feb 08, 2009 at 12:12:32AM +0100, Christian Franke wrote:
Robert Millan wrote:
I would suggest to move grub_ata_pass_through() to a new module (e.g.
ata2.mod, atax.mod, ataex.mod, ...)
How about ata_something.mod? (consistent with ntfs.mod
Robert Millan wrote:
I would suggest to move grub_ata_pass_through() to a new module (e.g.
ata2.mod, atax.mod, ataex.mod, ...)
How about ata_something.mod? (consistent with ntfs.mod & ntfs_comp.mod)
ata_pthru.mod ?
Christian
___
Grub
Robert Millan wrote:
On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote:
This patch adds a command which allows to change a few (S)ATA drive
settings. It relies on a new pass-through function in ata.mod.
Is this function going to be used for "normal" use of
Christian Franke wrote:
This skips identical lines in hexdump output, like 'od' or 'xxd -a'
also do.
Committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
This skips identical lines in hexdump output, like 'od' or 'xxd -a' also do.
Christian
PS: I would suggest to change hexdump 'buf' parameter from 'char *' to
'const void *' to avoid unnecessary casts.
2009-01-30 Christian Franke
Christian Franke wrote:
This small patch allows '\n' in option help texts, for example:
Patch simplified & committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Javier Martín wrote:
El mar, 27-01-2009 a las 20:56 +0100, Christian Franke escribió:
Is building a bare 'no-OS' compiler supported by the upstream GCC sources?
Probably a too strict prerequisite for building GRUB.
I can't vouch so for all possible environments, but
Javier Martín wrote:
El mar, 27-01-2009 a las 18:21 +0100, Christian Franke escribió:
Javier Martín wrote:
Unfortunately, gcc has no '-fno_os' option to specify the bare CPU as
target.
Might -ffreestanding be what you are looking for?
Javier Martín wrote:
Unfortunately, gcc has no '-fno_os' option to specify the bare CPU as
target.
Might -ffreestanding be what you are looking for?
The option '-ffreestanding' is the same as '-fno-hosted'.
According to gcc (4.3.1) source, '-fno-hosted' clears variable
'flag_hosted
Robert Millan wrote:
Hi,
Based on the description of host/target triplets in configure.ac:
dnl build -- the environment for building GRUB
dnl host -- the environment for running utilities
dnl target -- the environment for running GRUB
it seems that target_os is an oxymoron. There's n
tandby or sleep mode (e.g. before running a long memtest):
hdparm -y (ata0)
hdparm -Y (ata0)
- Freeze security settings (some BIOS don't):
hdparm -F (ata0)
Thanks for any comment.
Christian
2009-01-24 Christian Franke
* commands/hdparm.c: New file. Provides `hdparm' c
},
...
};
grub> complex -h
...
-c, --very-complexsorry, but this very complex option requires more
. than one line to explain properly.
I need it for a new module :-)
Christian
2009-01-23 Christian Franke
* normal/arg.c (grub_arg_show_help): Add indentation if &
Christian Franke wrote:
This patch adds 'precision' support to grub_printf '%s' format, e.g.:
Committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Christian Franke wrote:
This patch fixes these open issues:
- grub_pio_read/write() check the ERR bit without ensuring !BSY.
- ata_read fails if (batch % size) == 0.
- ata_write does not work at all, it uses the read cmd.
Tested on several PC + Committed.
Christian
This patch adds 'precision' support to grub_printf '%s' format, e.g.:
grub_printf("data=%.20s...\n", data);
This feature of standard printf() is useful to limit output length or to
print strings which are not 0-terminated.
Christian
2009-01-21 Christian Fra
This patch fixes these open issues:
- grub_pio_read/write() check the ERR bit without ensuring !BSY.
- ata_read fails if (batch % size) == 0.
- ata_write does not work at all, it uses the read cmd.
Christian
2009-01-20 Christian Franke
* disk/ata.c (grub_ata_wait_status
Marco Gerards wrote:
> > Committed, plus an additional wait in grub_atapi_identify.
>
> Great! :-)
>
> > Open issues:
> > - grub_pio_read/write() check the ERR bit without ensuring !BSY.
> > - ata_read fails if (batch % size) == 0.
> > - ata_write does not work at all, it uses the read cmd.
>
>
Christian Franke wrote:
Marco Gerards wrote:
Christian Franke <...> writes:
This patch fixes the data I/O protocol of the ATA PACKET command.
The current implementation does not read the byte count
registers. ATAPI read may not work if the drive sends the data in
more than one
Christian Franke wrote:
This patch fixes SCSI blocksize handling, necessary for ATAPI CD/DVD.
Committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Marco Gerards wrote:
> Christian Franke <...> writes:
>
> > This patch fixes the data I/O protocol of the ATA PACKET command.
> >
> > The current implementation does not read the byte count
> > registers. ATAPI read may not work if the drive sends the data in
work.
Christian
2008-01-18 Christian Franke
* disk/ata.c (GRUB_ATAPI_REG_*): New defines.
(GRUB_ATAPI_IREASON_*): Likewise.
(grub_ata_pio_write): Fix timeout error return.
(grub_atapi_wait_drq): New function.
(grub_atapi_packet): New parameter `size
This patch fixes SCSI blocksize handling, necessary for ATAPI CD/DVD.
OT: There might be a memory leak in scsi_open(): free(scsi) is missing,
at least on open error.
Christian
2009-01-17 Christian Franke
* disk/scsi.c (grub_scsi_read10): Use scsi->blocksize instead
Christian Franke wrote:
...
Other issues found, not addressed in this patch:
...
- atapi_read does not always work (occasional timeouts, crash on VmWare)
Root of this problem is in scsi.mod: It always assumes a sector size of
512 bytes which is not the case for ATAPI CD/DVD.
Christian
Christian Franke wrote:
This patch fixes the following issues in ata.mod I found during
testing on several PC and VMs:
...
Committed.
Christian
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
:
- ata_read fails if (batch % size) == 0.
- ata_write does not work at all, it uses the read cmd.
- atapi_read does not always work (occasional timeouts, crash on VmWare)
I will provide patches for these later.
Christian
2009-01-14 Christian Franke
* disk/ata.c (enum grub_ata_commands
Christian Franke wrote:
For the compatibility mode check, the ATA driver uses the bits in the
"Revision" byte instead of the "Programming Interface Byte" of the
class value (See T13/1510D). The compat_use[] flags are never set.
This patch fixes both issues.
C
For the compatibility mode check, the ATA driver uses the bits in the
"Revision" byte instead of the "Programming Interface Byte" of the class
value (See T13/1510D). The compat_use[] flags are never set.
This patch fixes both issues.
Christian
2009-01-11 Christian Fran
Robert Millan wrote:
On Thu, Nov 06, 2008 at 09:43:09PM +0100, Christian Franke wrote:
How would the whole picture look like? Sounds like it'd mean less
complexity
in external modules at the expense of more complexity in the build system.
Here a first proof-of-concept patch,
Robert Millan wrote:
On Thu, Nov 06, 2008 at 10:10:56PM +0100, Christian Franke wrote:
See attached patch for a possible fix: Each module using grub_dprintf
(here disk.c) may specify its name in 'this_file'. When all modules are
changed, the '#define this_file' an
Robert Millan wrote:
On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote:
PS: The current use of __FILE__ may also add extra unexpected size: For
packaging, configure is often run outside of $srcdir with a absolute
path name. This may result in long __FILE__ strings, like
Robert Millan wrote:
On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote:
Then, a module author has the option to check the ABI version by
importing this symbol
(possibly by simply adding '-u grub_abi_VERSION' to ld command)
How would the whole picture look lik
1 - 100 of 273 matches
Mail list logo
