Robert Millan wrote:
On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote:
This patch adds a command which allows to change a few (S)ATA drive
settings. It relies on a new pass-through function in ata.mod.
Is this function going to be used for "normal" use of ata? Note that ata.mod
should be as small as possible, since coreboot users usually want to include
it the GRUB that is installed to flash.
Like 'hdparm.mod' itself, the ATA pass-through function is not needed
for normal boot.
Would it make sense to put the function elsewhere?
I would suggest to move grub_ata_pass_through() to a new module (e.g.
ata2.mod, atax.mod, ataex.mod, ...)
The function should not be in hdparm.mod itself, because the hdparm
command would also work with other ATA pass-through functions. For
example with some future ahci.mod or even in conjunction with native USB
support through a SAT tunnel.
Christian
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
