Marco Gerards wrote:
> > Committed, plus an additional wait in grub_atapi_identify.
>
> Great! :-)
>
> > Open issues:
> > - grub_pio_read/write() check the ERR bit without ensuring !BSY.
> > - ata_read fails if (batch % size) == 0.
> > - ata_write does not work at all, it uses the read cmd.
>
> grub_ata_write does not use the read cmd, or do you mean indirectly?
> In that case, where does it use the read command?
>
cmd_write is set, but not used:
grub_ata_readwrite (...)
{
...
cmd = GRUB_ATA_CMD_READ_SECTORS;
cmd_write = GRUB_ATA_CMD_WRITE_SECTORS;
if (rw == 0)
{
...
} else {
/* Write sectors. */
if (grub_ata_cmd (dev, cmd))
-----------------------------^^^ GRUB_ATA_CMD_READ_SECTORS
...
}
...
}
I will post a patch for all 3 issues soon.
Christian
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
