Re: configure options when building from source

2017-05-14 Thread Andrei Borzenkov
14.05.2017 20:54, Beeblebrox пишет: > Hello, building Grub from source on FreeBSD with > ./autogen.sh --disable-efiemu --disable-nls > ./configure --disable-efiemu --disable-nls > > The resulting config is below > GRUB2 will be compiled with following components: > Platform: i386-pc > With devmap

Re: GRUB 2.02 release

2017-04-27 Thread Andrei Borzenkov
26.04.2017 14:27, Vladimir 'phcoder' Serbinenko пишет: > Hello everyone. GRUB maintainers team is proud to announce GRUB 2.02 that > we have just released. This release contains fixes for bugs uncovered in > 2.02~rc2 and updated translations. > > Full list of new features since release 2.00 is ava

Re: grub-install deleting long UEFI entries bug ?

2017-04-23 Thread Andrei Borzenkov
23.04.2017 23:33, adrian15 пишет: > El 23/04/17 a las 10:45, Andrei Borzenkov escribió: >> 23.04.2017 11:21, adrian15 adrian15 пишет: >>> 2017-04-23 6:36 GMT+02:00 Andrei Borzenkov : >>> >>>> 23.04.2017 03:54, adrian15 пишет: >>>>&g

Re: grub2-common: grub.cfg gains wrong root settings for multi-OS system

2017-04-23 Thread Andrei Borzenkov
23.04.2017 08:43, Ralph Ronnquist пишет: > For all installs, I made it mount /dev/sda1 at /boot but only the > first install formatted it. Shared /boot never worked reliably. With or without grub. Sorry. ___ Grub-devel mailing list Grub-devel@gnu.org ht

Re: grub-install deleting long UEFI entries bug ?

2017-04-23 Thread Andrei Borzenkov
23.04.2017 11:21, adrian15 adrian15 пишет: > 2017-04-23 6:36 GMT+02:00 Andrei Borzenkov : > >> 23.04.2017 03:54, adrian15 пишет: >>> grub-install seems to be deleting long UEFI entries >>> >>> (*) What the bug is >>> >>> * Ad

Re: grub-install deleting long UEFI entries bug ?

2017-04-22 Thread Andrei Borzenkov
23.04.2017 03:54, adrian15 пишет: > grub-install seems to be deleting long UEFI entries > > (*) What the bug is > > * Add an UEFI entry with this label (Remove the single quotes): > '(Rescapp added) \EFI\ubuntu\MokManager.efi' > > Example: > > efibootmgr -c \ > -d /dev/sda \ > -p 2 \ > -L '

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-04-19 Thread Andrei Borzenkov
19.04.2017 20:48, Pali Rohár пишет: > Hi! I would like to remind this patch. It allows to use UUID of UDF > partition in grub2. Linux tool blkid is already able to handle it, so it > is possible to specify UUID of UDF partition in /etc/fstab. > > UDF is filesystem used on optical disks (DVD), but

Re: How to deal with `multiboot` and compressed files

2017-04-15 Thread Andrei Borzenkov
15.04.2017 19:47, Paul Menzel пишет: > Dear GRUB folks, > > > The payloads for coreboot are normally LZMA compressed, as there is > only little room on a flash ROM chip. Vladimir adapted SeaBIOS so it’s > Multiboot compatible, so that SeaBIOS and the VGA Option can be easily > loaded from the har

Re: `halt` doesn’t work on Lenovo T60 with coreboot and GRUB payload

2017-04-15 Thread Andrei Borzenkov
15.04.2017 19:32, Paul Menzel пишет: > Dear GRUB folks, > > > On a Lenovo T60 with coreboot and the GRUB payload, version 2.02-rc1, > entering `halt` in the GRUB command line, nothing happens. The cursor > goes one line below, and everything stays that way. After that, the > system can only be po

Re: Support for search by disk id module

2017-04-15 Thread Andrei Borzenkov
15.04.2017 14:27, Mat628 пишет: > There is no established standard and this changed over time. GRUB uses > platform firmware to access devices, so it can only use information > firmware exports. In general we have no way to query for this information. > > Would it be considered acceptable to call

Re: `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)

2017-04-15 Thread Andrei Borzenkov
15.04.2017 13:25, Paul Menzel пишет: > Dear GRUB folks, > > > When using GRUB as a coreboot payload, that means passing `--with- > platform=coreboot` to configure, and configuring it to load the GRUB > configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7 > (Jessie/stable) and 9 (Stre

Re: Support for search by disk id module

2017-04-15 Thread Andrei Borzenkov
15.04.2017 13:55, Mat628 пишет: > Hi, > > I wanted to verify/clarify what would be an acceptable format for a disk id > to be used as a search parameter for a module to return the associated device. > > Where on Linux, devices are mapped to a hardware specific path. > For hard disks it is > > t

Re: [RFC][PATCH] cmd: test: Add bitwise AND, document the feature

2017-04-12 Thread Andrei Borzenkov
12.04.2017 21:10, Brad Mouring пишет: > Currently, there is not a good way to control script flow based on > bitwise values. This initially led to NI adding the ability to read > a specific bit from a port-mapped register to control bootflow. > > Here, we add a more generic ability to test the bit

Re: Grub2, can the following be done

2017-04-11 Thread Andrei Borzenkov
12.04.2017 02:28, Vladimir 'phcoder' Serbinenko пишет: > I documented this in the manual. See "standalone multi-OS setup" > There is no such section. You probably mean Configuration - Multi-boot manual config. Unfortunately this is not as simple. 1. Sourcing full configuration file from another

Re: Support for plain dm-crypt and detached LUKS header

2017-04-08 Thread Andrei Borzenkov
Thank you for the patch. Unfortunately it does not solve fundamental problem - grub-install is expected to auto-detect everything that is required to access /boot/grub (it violates it now for encrypted /boot, but I plan to submit patch after release to decouple it from /etc/default/grub). So any so

[PATCH] acpi: do not attempt to create EBDA on EFI (was: Loading DSDT table using 'acpi' or some memory write command?)

2017-04-04 Thread Andrei Borzenkov
01.04.2017 12:09, Andrei Borzenkov пишет: > > I also have rather weird issue that after "acpi dsdt.aml" I lose > partitions (only hard disk itself is visible). This is on real hardware > (Dell Latitude E5450). > > Anyone knows why we attempt to write to some arbitra

Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-04-04 Thread Andrei Borzenkov
03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет: > On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov wrote: > >> sblock was local and so considered new variable on every loop >> iteration. >> >> While on it, dynamically allocate buffer to reduce stack u

[PATCH] acpi: add missing efi_call wrapper to acpi command

2017-04-01 Thread Andrei Borzenkov
Fixed loading of ACPI tables on EFI (side effect was apparent memory corruption ranging from unpredictable behavior to system reset). Reported by Nando Eva --- @Nando: please test this patch. It fixed loading for me at least on QEMU/OVMF. It conflicts with lsacpi patch, but you can actually ver

Re: Integrating a FreeBSD/GELI change

2017-04-01 Thread Andrei Borzenkov
01.04.2017 15:57, Eric McCorkle пишет: > Hello, > > I've been working on a series of changes designed to expand FreeBSD's > full-disk encryption support via GELI (its preferred disk encryption > mechanism). One of the important parts of this landed in HEAD last night: > > https://github.com/free

Re: Loading DSDT table using 'acpi' or some memory write command?

2017-04-01 Thread Andrei Borzenkov
ationTable does not work; after "acpi ..." "lsacpi --scan" still displays old RSDP and tables (although grub itself would use new one). I also have rather weird issue that after "acpi dsdt.aml" I lose partitions (only hard disk itself is visible). This is on real har

[PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-03-31 Thread Andrei Borzenkov
sblock was local and so considered new variable on every loop iteration. While on it, dynamically allocate buffer to reduce stack usage. Closes: 50597 --- grub-core/fs/btrfs.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/grub-core/fs/btrfs.c b/grub-cor

[PATCH] i386, x86_64, ppc: fix switch fallthrough cases with GCC7

2017-03-31 Thread Andrei Borzenkov
In util/getroot and efidisk slightly modify exitsing comment to mostly retain it but still make GCC7 compliant with respect to fall through annotation. In grub-core/lib/xzembed/xz_dec_lzma2.c it adds same comments as upstream. In grub-core/tests/setjmp_tets.c declare functions as "noreturn" to su

Re: Loading DSDT table using 'acpi' or some memory write command?

2017-03-29 Thread Andrei Borzenkov
29.03.2017 20:45, Nando Eva пишет: >> How exactly do you find RSDP? On EFI RSDP should be retrieved from EFI >> Configuration Table, which grub tries to update. Please give as much >> details as possible. > > Good point. I can get the RSDP from tools like 'ru.efi' or even with 'r-w > everything'.

Re: [wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]

2017-03-28 Thread Andrei Borzenkov
28.03.2017 09:34, Peter Palfrader пишет: > } /dev/md2953M 176K 953M 1% /boot/efi Sorry, that's not going to work. Even assuming that grub can map from Linux MD to underlying physical device + partition (as that is what efibootmgr needs, we cannot simply pass /dev/md2 to it), this will

Re: Loading DSDT table using 'acpi' or some memory write command?

2017-03-27 Thread Andrei Borzenkov
27.03.2017 17:12, Nando Eva пишет: > OK, I found the cause if the problem: > - the ACPI tables specified to the 'acpi' command are loaded to new addresses > and a new RSDT and XSDT created with pointers to them. This can be confirmed > by the 'lsacpi' command. > > - the RSDP isn't updated to poi

Re: [wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]

2017-03-27 Thread Andrei Borzenkov
27.03.2017 15:41, Colin Watson пишет: > I guess that the attached bug happens because grub_install_register_efi > is called on non-biosdisk-ish systems but uses > grub_util_biosdisk_get_osdev to get an OS device name for > efidir_grub_dev->disk, which isn't going to work so well. I'm a bit > rusty

Re: [wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]

2017-03-27 Thread Andrei Borzenkov
Link to the bug report would be helpful. I assume it contains actual invocation with arguments, I do not see them in this mail. On Mon, Mar 27, 2017 at 3:41 PM, Colin Watson wrote: > I guess that the attached bug happens because grub_install_register_efi > is called on non-biosdisk-ish systems bu

Re: cbfsdisk not found

2017-03-25 Thread Andrei Borzenkov
25.03.2017 10:22, Vladimir 'phcoder' Serbinenko пишет: > On Sat, Mar 25, 2017, 00:16 Andrei Borzenkov wrote: > >> 24.03.2017 21:38, Gailu Singh пишет: >>> This is how it is calculated in coreboot >>> >>> >> https://review.coreboot.org:4

Re: cbfsdisk not found

2017-03-25 Thread Andrei Borzenkov
> } > BIOS_UNUSABLE@0xf3f000 0x4 > DEVICE_EXTENSION@0xf7f000 0x7f000 > UNUSED_HOLE@0xfff000 0x1000 > } > > How does it help us? We have no idea which board grub currently runs on. Do you suggest scanning the whole memory for "__FMAP__" signature? " > >

Re: cbfsdisk not found

2017-03-24 Thread Andrei Borzenkov
24.03.2017 20:32, Gailu Singh пишет: >>> Could you please reference the solution for future users with the same > problem? > Sure. Infect I should have detailed it without asking. Sorry for that. > > Solution can be referenced to following thread in coreboot mailing list > that provide details of

Re: Disable graphics completly

2017-03-20 Thread Andrei Borzenkov
On Mon, Mar 20, 2017 at 2:57 PM, Andrei Borzenkov wrote: > On Mon, Mar 20, 2017 at 1:47 PM, Gailu Singh wrote: >> Thanks Daniel. >> >> I do not see video specific modules in the below list (guessing based on the >> names though, so may be wrong) >> > > Def

Re: Disable graphics completly

2017-03-20 Thread Andrei Borzenkov
On Mon, Mar 20, 2017 at 1:47 PM, Gailu Singh wrote: > Thanks Daniel. > > I do not see video specific modules in the below list (guessing based on the > names though, so may be wrong) > Default output driver on coreboot platform in text mode VGA. Unfortunately GRUB starts output even before evalua

Re: cbfsdisk not found

2017-03-17 Thread Andrei Borzenkov
On Fri, Mar 17, 2017 at 4:24 PM, Gailu Singh wrote: > @Vladimir > I do not have serial console (board has memory mapped uart not support in > grub) to capture memory details. Also on graphics console I can not give > commands from usb keyboard to dump memory because USB port on board are 3.0 > an

Re: cbfsdisk not found

2017-03-17 Thread Andrei Borzenkov
address of cbfs. If this location contains wrong address, there is nothing we can do here. We need information how to discover cbfs using other means. > > > On Fri, Mar 17, 2017 at 8:57 AM, Andrei Borzenkov > wrote: >> >> 16.03.2017 22:43, Gailu Singh пишет: >> >&g

Re: cbfsdisk not found

2017-03-16 Thread Andrei Borzenkov
16.03.2017 22:43, Gailu Singh пишет: >>> Try insmod cbfs > >> > Trieed, it does not help. BTW cbfs is already included in my grub elf image > so I don't think I need to do insmod. > > ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o > default_payload.elf --modules='ls ahci pa

Re: [PATCH] disk/efi: skip iPXE dummy block devices

2017-03-13 Thread Andrei Borzenkov
14.03.2017 06:03, Michael Chang пишет: > On Mon, Mar 13, 2017 at 06:45:02AM +0300, Andrei Borzenkov wrote: >> iPXE adds Simple File System Protocol to loaded image handle, as side >> effect it also adds Block IO protocol (according to comments, to work >> around some bugs i

[PATCH] disk/efi: skip iPXE dummy block devices

2017-03-12 Thread Andrei Borzenkov
iPXE adds Simple File System Protocol to loaded image handle, as side effect it also adds Block IO protocol (according to comments, to work around some bugs in EDK2). GRUB assumes that every device with Block IO is disk and skips network initialization entirely. But iPXE Block IO implementation is

Re: Menu for booting BTRFS snapshots

2017-03-04 Thread Andrei Borzenkov
Отправлено с iPhone > 4 марта 2017 г., в 4:02, Robert LeBlanc написал(а): > > > menuentry 'RXE Snapshot' { > load_env -f /snaps/rxe-boot/grub2/grubenv > configfile /snaps/rxe-boot/grub2/grub.cfg > } > Grub.cfg as created by grub-mkconfig loads $prefix/grubenv which overrides wh

Re: Menu for booting BTRFS snapshots

2017-03-02 Thread Andrei Borzenkov
03.03.2017 00:40, Robert LeBlanc пишет: > I'm trying to add some menuentry items to move between btrfs > snapshots. I've added the following in the non-snapshot > /etc/grub.d/40_custom. > > menuentry 'RXE Snapshot' { >load_env -f /snaps/rxe-boot/grub2/grubenv >configfile /snaps/rxe

Re: USB3.0 XHCI support on GRUB2

2017-03-01 Thread Andrei Borzenkov
tive. > On physical platforms grub normally relies on firmware to access devices. What exact problem do you solve? Why do you need direct xHCI access? What firmware this board has (I presume, EFI)? > On Wed, Mar 1, 2017 at 4:07 PM, Bjørn Forsman > wrote: > >> On 1 March 2

Re: 8250 memory mapped UART

2017-02-28 Thread Andrei Borzenkov
please test patches from Matthias Lange https://lists.gnu.org/archive/html/grub-devel/2017-02/msg00104.html On Wed, Mar 1, 2017 at 9:15 AM, Gailu Singh wrote: > Hi Experts, > > I am using GRUB2 on intel apollo lake board. This board does not have IO > mapped uart instead it has 8250 memory mapp

Re: USB3.0 XHCI support on GRUB2

2017-02-28 Thread Andrei Borzenkov
Yes, Bjørn Forsman intended to work on implementation. On Wed, Mar 1, 2017 at 9:14 AM, Gailu Singh wrote: > Hi Experts, > > Is there any development on XHCI support on GRUB2? New Intel boards (e.g. > Apollo Lake) has only XHCI controller so none my USB device (keyboarrd, mass > storage) works on

Re: grub-probe for nested BSD partition on Linux

2017-02-28 Thread Andrei Borzenkov
01.03.2017 01:05, Lennart Sorensen пишет: > On Tue, Feb 28, 2017 at 09:50:27PM +0300, Andrei Borzenkov wrote: >> 28.02.2017 21:31, Lennart Sorensen пишет: >>> On Tue, Feb 28, 2017 at 08:13:53PM +0300, Andrei Borzenkov wrote: >>>> Sorry? vda7 is 256M, how can

Re: grub-probe for nested BSD partition on Linux

2017-02-28 Thread Andrei Borzenkov
28.02.2017 21:31, Lennart Sorensen пишет: > On Tue, Feb 28, 2017 at 08:13:53PM +0300, Andrei Borzenkov wrote: >> Sorry? vda7 is 256M, how can you suddenly pretend it is 2G? >> >> 10:~ # fdisk -l /dev/vda >> Disk /dev/vda: 5 GiB, 5368709120 bytes, 10485760 sectors >>

grub-probe for nested BSD partition on Linux (was: [PATCH 1/1] add --partuuid to probe)

2017-02-28 Thread Andrei Borzenkov
28.02.2017 17:08, Vladimir 'phcoder' Serbinenko пишет: >> >> OK I see, kernel skips BSD partition marked as "unused". >> >> So it appears that kernel always puts special nested partitions after >> normal logical MSDOS partitions, so it will not skew MSDOS partition >> numbers. >> >> [1.529752]

Re: [PATCH 1/1] add --partuuid to probe

2017-02-27 Thread Andrei Borzenkov
27.02.2017 21:20, Vladimir 'phcoder' Serbinenko пишет: > On Mon, Feb 27, 2017, 09:55 Andrei Borzenkov wrote: > >> 27.02.2017 03:37, Vladimir 'phcoder' Serbinenko пишет: >> ... >>>>>>> This is not NT-style. NT uses partition offset. W

Re: [GRUB PARTUUID PATCH V3 5/5] Harmonize patches

2017-02-27 Thread Andrei Borzenkov
27.02.2017 03:34, Vladimir 'phcoder' Serbinenko пишет: >>if (state[6].set) >> { >>char *partuuid = NULL; /* NULL to silence a spurious GCC warning */ >> - /* Nested partitions are not supported for now. */ >> - /* Non-nested partitions must have dev->disk->partition->pare

Re: [PATCH 1/1] add --partuuid to probe

2017-02-27 Thread Andrei Borzenkov
27.02.2017 03:37, Vladimir 'phcoder' Serbinenko пишет: ... > This is not NT-style. NT uses partition offset. Who uses this format? >> Are This is used by util-linux and Linux kernel. * 6) PARTUUID=00112233-4455-6677-8899-AABBCCDDEEFF representing >> the *

Re: Loading DSDT table using 'acpi' or some memory write command?

2017-02-27 Thread Andrei Borzenkov
On Mon, Feb 27, 2017 at 2:29 PM, Nando Eva wrote: > @Andrei Borzenkov, I've confirmed that any of the following do not alter the > Win10 DSDT table across numerous Macbooks and my Dell E6540. > > acpi dsdt.aml > acpi --load-only dsdt dsdt.aml > acpi -2 dsdt.aml > > Fo

Re: [GRUB PARTUUID PATCH V3 4/5] Support both EFI and NT Disk Signature for passing to kernel as root=PARTUUID=$val

2017-02-26 Thread Andrei Borzenkov
Отправлено с iPhone > 27 февр. 2017 г., в 3:35, Vladimir 'phcoder' Serbinenko > написал(а): > > > >> On Sun, Feb 26, 2017, 16:22 Nicholas Vinson wrote: >> From: Steve Kenton > > Please avoid resubmitting patches made by someone else in most cases. It > obscures proper attribution. We ca

Re: [GRUB PARTUUID PATCH V3 1/5] Fix flex-2.6.3 incompatbility issue

2017-02-26 Thread Andrei Borzenkov
27.02.2017 03:28, Vladimir 'phcoder' Serbinenko пишет: > Please explain why this patch is needed. I compile with 2.6.1 just fine > There is bug introduced in flex 2.6.2 (I believe) and fixed in current git, so in to be released 2.6.4. See https://savannah.gnu.org/bugs/index.php?50093 https://git

sqaush4 tests (was: Re: [PATCH] squash4: fix handling of fragments and sparse files)

2017-02-25 Thread Andrei Borzenkov
25.02.2017 18:23, Andrei Borzenkov пишет: > 24.02.2017 19:19, Andrei Borzenkov пишет: >>> How do you create those files reliably? Feel free to add any files to >>> grub-fs-tester. Feel free to commit without tests, we can add tests later. >>> >> >> I w

Re: [PATCH] squash4: fix handling of fragments and sparse files

2017-02-25 Thread Andrei Borzenkov
24.02.2017 19:19, Andrei Borzenkov пишет: >> How do you create those files reliably? Feel free to add any files to >> grub-fs-tester. Feel free to commit without tests, we can add tests later. >> > > I would say, we need to generally create less "nice" test file

Re: [PATCH] efi: strip off final NULL from File Path in grub_efi_get_filename

2017-02-24 Thread Andrei Borzenkov
25.02.2017 02:21, Vladimir 'phcoder' Serbinenko пишет: > On Fri, Feb 24, 2017, 09:47 Andrei Borzenkov wrote: > >> UEFI 2.6 9.3.6.4 File Path Media Device Path says that Path Name is >> "A NULL-terminated Path string including directory and file names". &g

Re: pvgrub2 legacy_configfile issues: /sbin/init exec error -8

2017-02-24 Thread Andrei Borzenkov
25.02.2017 02:22, Vladimir 'phcoder' Serbinenko пишет: > On Sun, Feb 12, 2017, 11:52 Vladimir 'phcoder' Serbinenko > wrote: > >> >> >> On Sun, 12 Feb 2017, 08:06 Andrei Borzenkov wrote: >> >> 12.02.2017 00:07, Vladimir 'phcoder&

Re: Loading DSDT table using 'acpi' or some memory write command?

2017-02-24 Thread Andrei Borzenkov
23.02.2017 19:00, Nando Eva пишет: > Hi grub-devel, I'm endeavouring to pre-load a modified DSDT table > using grub2. The syntax I've tried being as shown below, after which > I chainload to Win10. This being done on a Dell E6540 with Win10 and > grub 2.02 (or older.. tried many versions, same r

Re: [PATCH] squash4: fix handling of fragments and sparse files

2017-02-24 Thread Andrei Borzenkov
23.02.2017 16:52, Vladimir 'phcoder' Serbinenko пишет: > On Sat, Feb 18, 2017, 10:17 Andrei Borzenkov wrote: > >> 1. Do not assume block list and fragment are mutually exclusive. Squash >> can pack file tail as fragment (unless -no-fragments is specified); so >>

[PATCH] efi: strip off final NULL from File Path in grub_efi_get_filename

2017-02-24 Thread Andrei Borzenkov
UEFI 2.6 9.3.6.4 File Path Media Device Path says that Path Name is "A NULL-terminated Path string including directory and file names". Strip final NULL from Path Name in each File Path node when constructing full path. To be on safe side, strip all of them. Fixes failure chainloading grub from g

Should Path Name in File Path Media Device Path node be NULL terminated?

2017-02-23 Thread Andrei Borzenkov
Historically grub2 built image paths using two File Path nodes - one for directory and one for file name relative to directory. These nodes had path names that were not NULL terminated. Recently we had bug report that secure boot using grub2 failed. It was tracked down to exactly the fact that pat

[PATCH RFC] efi/chainloader: build image path as single File Path

2017-02-23 Thread Andrei Borzenkov
According to EFI 9.3.6.4 File Path Media Device Path, Path Name is A NULL-terminated Path string including directory and file names. EFI chainloader is using two File Path nodes for image name - directory and file. It appears that at least some firmware implementations interpret NULL terminated d

kernel build still pulls in host includes even with -nostdinc

2017-02-18 Thread Andrei Borzenkov
Could someone comment on this? gcc -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I386_PC -m32 -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/5/include So we do have definitions from /usr/lib/gcc/x86_64-linux-gnu/5/include used. How harmless/harmful is it?

Re: [PATCH 1/1 V2] add --partuuid to probe

2017-02-18 Thread Andrei Borzenkov
18.02.2017 18:31, Steve Kenton пишет: > Signed-off-by: Steve Kenton > --- > V2 coding style changes as suggested in feedback > In V1 I was treating p->index as an offset into the partition table instead > of an index from 0-15 of the partition table slot needing to be multipled > by the size of a

Re: [PATCH 1/1] add --partuuid to probe

2017-02-18 Thread Andrei Borzenkov
15.02.2017 20:25, Vladimir 'phcoder' Serbinenko пишет: > On Wed, Feb 15, 2017, 17:27 Andrei Borzenkov wrote: > >> 15.02.2017 13:56, Vladimir 'phcoder' Serbinenko пишет: >>> On Tue, Feb 14, 2017, 19:01 Steve Kenton wrote: >>> >>>> S

[PATCH] squash4: fix handling of fragments and sparse files

2017-02-18 Thread Andrei Borzenkov
1. Do not assume block list and fragment are mutually exclusive. Squash can pack file tail as fragment (unless -no-fragments is specified); so check read offset and read either from block list or from fragments as appropriate. 2. Support sparse files with zero blocks. 3. Fix fragment read - frag.

Re: [PATCH 1/1] add --partuuid to probe

2017-02-15 Thread Andrei Borzenkov
15.02.2017 13:56, Vladimir 'phcoder' Serbinenko пишет: > On Tue, Feb 14, 2017, 19:01 Steve Kenton wrote: > >> Support both EFI and NT Disk Signature for passing to kernel as >> root=PARTUUID=$val >> >> Signed-off-by: Steve Kenton >> --- >> It's been six months so I thought I'd resend this so it

Re: [PATCH 1/1] add --partuuid to probe

2017-02-14 Thread Andrei Borzenkov
14.02.2017 21:00, Steve Kenton пишет: > Support both EFI and NT Disk Signature for passing to kernel as > root=PARTUUID=$val > Yes, I guess we need to add it finally. Unfortunately it is too late for 2.02, but it should go after in release. There were also patches for grub-probe and we also need

Re: [PATCH v2] mips64: Add support for 64-bit MIPS.

2017-02-13 Thread Andrei Borzenkov
13.02.2017 18:57, wa...@lemote.com пишет: > From: Heiher > Before going in more depth for review, could you give more details which platforms are using it, what ABI is targeted (n64? something else?) Is MIPS going to be included in official UEFI spec? ___

Re: pvgrub2 legacy_configfile issues: /sbin/init exec error -8

2017-02-11 Thread Andrei Borzenkov
12.02.2017 00:07, Vladimir 'phcoder' Serbinenko пишет: ... >> > For multiboot module old grub was passing module file name on module > command line, so legacy_configfile should replicate this behaviour. But in > Linux case it shouldn't have ended up loading twice. We need additional > code in legac

[PATCH] script: fix double free in lexer

2017-02-11 Thread Andrei Borzenkov
yylex_destroy() already frees scanner. Found by: Coverity scan. CID: 176636 --- grub-core/script/lexer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/grub-core/script/lexer.c b/grub-core/script/lexer.c index 89cf677..c6bd317 100644 --- a/grub-core/script/lexer.c +++ b/grub-core/script/lexe

Re: pvgrub2 legacy_configfile issues: /sbin/init exec error -8

2017-02-11 Thread Andrei Borzenkov
11.02.2017 20:19, Andy Smith пишет: > Hello, > > On Sat, Feb 11, 2017 at 03:26:43PM +, Andy Smith wrote: >> Here is what the config looks like if I interrupt the boot and go to >> edit it: >> >> set root='(hd0,1)'; set legacy_hdbias='0' >> legacy_kernel '/boot/vmlinuz-3.16.0-4-amd64' >> '/b

Re: pvgrub2 legacy_configfile issues: /sbin/init exec error -8

2017-02-11 Thread Andrei Borzenkov
11.02.2017 16:53, Andy Smith пишет: ... > > if search -s -f /grub/menu.lst ; then > set root=(xen/xvda,msdos1) > echo "Reading (${root})/grub/menu.lst" > read > legacy_configfile /grub/menu.lst > fi > -

Re: Quation about build grub source code

2017-02-09 Thread Andrei Borzenkov
09.02.2017 19:46, Andre Bigijani пишет: > hi, > I'm develop my own simple os and for boot it i wants to use grub > how can i compile grub source code with cygwin64 in windows for get > loader.o file? > INSTALL lists prerequisite packages and how to build from snaoshot. If you follow INSTALL and g

Re: [PATCH] Make grub-install check for errors from efibootmgr

2017-02-09 Thread Andrei Borzenkov
30.01.2017 22:04, Steve McIntyre пишет: > Code is currently ignoring errors from efibootmgr, giving users > clearly bogus output like: > > Setting up grub-efi-amd64 (2.02~beta3-4) ... > Installing for x86_64-efi platform. > Could not delete variable: No space left on device

Re: explicit refresh?

2017-02-09 Thread Andrei Borzenkov
08.02.2017 11:29, Laszlo Ersek пишет: > Hi, > > this is a dumb question and it's not appropriate for a development > mailing list, but I couldn't find "grub-user" or "grub-users", so I'll > ask here anyway... > there is help-g...@gnu.org > My laptop is connected to my workstation via USB-serial

Re: xen: Fix handling of GRUB chainloading.

2017-02-07 Thread Andrei Borzenkov
I'm not familiar with code, so go ahead if you are sure it is bug fix. Отправлено с iPhone > 7 февр. 2017 г., в 0:50, Vladimir 'phcoder' Serbinenko > написал(а): > > In case of GRUB we put remapper after domain pages and not at 0x0. > In this case we use max_addr to put remapper. Unfortunately

Re: xen: Fix parsing of XZ kernel.

2017-02-07 Thread Andrei Borzenkov
Отправлено с iPhone > 7 февр. 2017 г., в 0:51, Vladimir 'phcoder' Serbinenko > написал(а): > > In case of xz, the uncompressed size is appended to xz data which confuses > our xz decompressor. Trim it. > > Daniel, Andrei, Alexander, do you agree that this should go into 2.02? > --- > grub-c

Re: Booting a system in a specific language

2017-02-04 Thread Andrei Borzenkov
04.02.2017 20:47, scootergrisen пишет: > Den 04-02-2017 kl. 18:26 skrev Andrei Borzenkov: >> 04.02.2017 20:04, scootergrisen пишет: >>> I test out different Linux distributions and some distributions offer to >>> select language during boot and some does not. >>

Re: Booting a system in a specific language

2017-02-04 Thread Andrei Borzenkov
04.02.2017 20:04, scootergrisen пишет: > I test out different Linux distributions and some distributions offer to > select language during boot and some does not. > > It helps when i can select language and keyboard layout etc. during boot > so i dont have to change the language etc. from inside G

Re: [PATCH v2] Clarify documentation for special environment variable "default"

2017-02-03 Thread Andrei Borzenkov
This landed in rc1. Thanks! 03.02.2017 08:23, Daniel Kahn Gillmor пишет: > The current documentation for the special environment variable > "default" is confusing and unclear. This patch attempts to clean it > up. > > In particular, the current documentation refers to the "number or > title", b

Re: [PATCH] Clarify documentation for special environment variable "default"

2017-02-02 Thread Andrei Borzenkov
03.02.2017 03:19, Daniel Kahn Gillmor пишет: > The current documentation for the special environment variable > "default" is confusing and unclear. This patch attempts to clean it > up. > > In particular, the current documentation refers to the "number or > title", but then in the example it give

Re: [PATCH] i386/relocator: Align stack in grub_relocator64_efi relocator

2017-02-02 Thread Andrei Borzenkov
On Thu, Feb 2, 2017 at 5:48 PM, Vladimir 'phcoder' Serbinenko wrote: > > > On Thu, 2 Feb 2017, 15:43 Andrei Borzenkov wrote: >> >> On Thu, Feb 2, 2017 at 5:27 PM, Daniel Kiper >> wrote: >> > Unified Extensible Firmware Interface Specification,

Re: [PATCH] i386/relocator: Align stack in grub_relocator64_efi relocator

2017-02-02 Thread Andrei Borzenkov
On Thu, Feb 2, 2017 at 5:27 PM, Daniel Kiper wrote: > Unified Extensible Firmware Interface Specification, Version 2.6, > section 2.3.4, x64 Platforms, boot services, says among others: > The stack must be 16-byte aligned. So, do it. Otherwise OS may > boot only by chance as it happens right now.

Re: [PATCH] Ignore xen all_video module emptiness

2017-01-29 Thread Andrei Borzenkov
29.01.2017 12:37, Vladimir 'phcoder' Serbinenko пишет: > Not tested yet. If there are no opposition I'll test and commit it. > > ... > diff --git a/util/grub-module-verifierXX.c b/util/grub-module-verifierXX.c > index 9c04caa..c79c1cb 100644 > --- a/util/grub-module-verifierXX.c > +++ b/util/grub

Re: [PATCH 1/4] Allow non-default ports for HTTP requests

2017-01-28 Thread Andrei Borzenkov
24.01.2017 03:35, Matthew Garrett пишет: > Add support for passing ports in HTTP requests. This takes the form of: > (http,serverip:portnum)/file > --- > grub-core/net/http.c | 8 ++-- > grub-core/net/net.c | 10 +- > include/grub/net.h | 1 + > 3 files changed, 16 insertions(+),

Disable movw/movt with clang

2017-01-27 Thread Andrei Borzenkov
> diff --git a/configure.ac b/configure.ac > index 4e980c5..ab7fa92 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1152,6 +1152,16 @@ if test "$target_cpu"-"$platform" = x86_64-efi; then > fi > > if test "x$target_cpu" = xarm; then > + AC_CACHE_CHECK([whether option -mllvm -arm-use-mov

Re: [PATCH] Add fwconfig command

2017-01-25 Thread Andrei Borzenkov
24.01.2017 02:43, Matthew Garrett пишет: > Add a command to read values from the qemu fwcfg store. This allows data > to be passed from the qemu command line to grub. > > Example use: > > echo '(hd0,1)' >rootdev > qemu -fw_cfg opt/rootdev,file=rootdev > > fwconfig opt/rootdev root The name soun

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-25 Thread Andrei Borzenkov
24.01.2017 23:50, Matthew Garrett пишет: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: >> 24.01.2017 03:36, Matthew Garrett пишет: >>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >>> it impossible to pass boot files with co

Re: [RFC 0/2] UEFI-based HTTP Boot

2017-01-25 Thread Andrei Borzenkov
On Wed, Jan 25, 2017 at 11:49 AM, Michael Chang wrote: > On Wed, Jan 25, 2017 at 11:19:19AM +0300, Andrei Borzenkov wrote: >> On Wed, Jan 25, 2017 at 11:09 AM, Michael Chang wrote: >> > On Fri, Jan 20, 2017 at 05:50:56PM +0300, Andrei Borzenkov wrote: >> >> On Fri

Re: [RFC 0/2] UEFI-based HTTP Boot

2017-01-25 Thread Andrei Borzenkov
On Wed, Jan 25, 2017 at 11:09 AM, Michael Chang wrote: > On Fri, Jan 20, 2017 at 05:50:56PM +0300, Andrei Borzenkov wrote: >> On Fri, Jan 20, 2017 at 4:13 AM, Ken Lin wrote: >> > This RFC patchset is stacked on the previous HTTP boot patchset: >> > https://lists.gnu.

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-24 Thread Andrei Borzenkov
On Wed, Jan 25, 2017 at 10:16 AM, Matthew Garrett wrote: > On Tue, Jan 24, 2017 at 10:56 PM, Andrei Borzenkov > wrote: >> On Wed, Jan 25, 2017 at 7:25 AM, Matthew Garrett wrote: >>> If prefix isn't set then won't bootfile be interpreted as the device plus >

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-24 Thread Andrei Borzenkov
On Wed, Jan 25, 2017 at 7:25 AM, Matthew Garrett wrote: > On Tue, Jan 24, 2017 at 8:15 PM, Andrei Borzenkov wrote: >> 25.01.2017 07:06, Matthew Garrett пишет: >>> I don't understand - grub_net_open_real() already handles this case: >> >> Because bootfile

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-24 Thread Andrei Borzenkov
25.01.2017 07:06, Matthew Garrett пишет: > On Tue, Jan 24, 2017 at 7:48 PM, Andrei Borzenkov wrote: >> 24.01.2017 23:50, Matthew Garrett пишет: >>> On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov >>> wrote: >>>> 24.01.2017 03:36, Matthew Garrett пишет: &

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-24 Thread Andrei Borzenkov
24.01.2017 23:50, Matthew Garrett пишет: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: >> 24.01.2017 03:36, Matthew Garrett пишет: >>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >>> it impossible to pass boot files with co

Re: [PATCH v2] osdep/linux: handle autofs entries in /proc/self/mountinfo

2017-01-24 Thread Andrei Borzenkov
19.01.2017 19:37, Andrei Borzenkov пишет: > These entries have placeholder for device name and so are useless for our > purpose. grub failed with something like > > grub-install: error: failed to get canonical path of `systemd-1'. > > When we see autofs entry, record i

Re: Why is stdint.h so little used?

2017-01-23 Thread Andrei Borzenkov
On Tue, Jan 24, 2017 at 10:08 AM, Bjørn Forsman wrote: > On 24 January 2017 at 02:33, Vladimir 'phcoder' Serbinenko > wrote: >> All files in posix_wrap are only for porting code to GRUB with little >> modification. No GRUB-specific code should use it. > > That only explains half of it :-) > > Wha

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

2017-01-23 Thread Andrei Borzenkov
24.01.2017 03:36, Matthew Garrett пишет: > Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making > it impossible to pass boot files with commas in them. Allow using a grub_net_open() operates on devices, not files. Please give more details about your problem. > semicolon to

Re: [PATCH 3/4] Don't allocate a new address buffer if we receive multiple DNS responses

2017-01-23 Thread Andrei Borzenkov
24.01.2017 03:36, Matthew Garrett пишет: > The current logic in the DNS resolution code allocates an address buffer > based on the number of addresses in the response packet. If we receive > multiple response packets in response to a single query packet, this means > that we will reallocate a new b

Re: [RFC 0/2] UEFI-based HTTP Boot

2017-01-21 Thread Andrei Borzenkov
> I hope this help you and the other maintainers understand the background of the HTTP(s) Boot patches from us. > ____ > From: Andrei Borzenkov > Sent: Friday, January 20, 2017 10:50:56 PM > To: The development of GNU GRUB > Cc: Lin, Ken (HPS OE-Lin

Re: [RFC 0/2] UEFI-based HTTP Boot

2017-01-20 Thread Andrei Borzenkov
On Fri, Jan 20, 2017 at 4:13 AM, Ken Lin wrote: > This RFC patchset is stacked on the previous HTTP boot patchset: > https://lists.gnu.org/archive/html/grub-devel/2016-12/msg00088.html > It re-uses some code from it, e.g. the DCHPACK > with vendor_class_identifier=HTTPClient. > > Instead of implem

[PATCH v2] osdep/linux: handle autofs entries in /proc/self/mountinfo

2017-01-19 Thread Andrei Borzenkov
These entries have placeholder for device name and so are useless for our purpose. grub failed with something like grub-install: error: failed to get canonical path of `systemd-1'. When we see autofs entry, record it (to keep parent-child relationship) but continue to look for real mount. If it i

  1   2   3   4   5   6   7   8   9   10   >