03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет: > On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov <arvidj...@gmail.com> wrote: > >> sblock was local and so considered new variable on every loop >> iteration. >> >> While on it, dynamically allocate buffer to reduce stack usage. >> > Looks good. Did you check all instances sizeof, so we don't have sizeof of > pointer? > Did you check return paths for free'ing on all of them? >
There is one common return path, but I committed light version that just moves variable out of loop; will commit full version after release. _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
