[PATCH v2] ieee1275: obdisk driver

2018-05-30 Thread Eric Snowberg
Add a new disk driver called obdisk for IEEE1275 platforms. Currently the only platform using this disk driver is SPARC, however other IEEE1275 platforms could start using it if they so choose. While the functionality within the current IEEE1275 ofdisk driver may be suitable for PPC and x86, it p

Re: [PATCH] loader/i386/linux: calculate the size of the setup header

2018-05-30 Thread Daniel Kiper
On Fri, May 25, 2018 at 12:02:03PM -0700, Andrew Jeddeloh wrote: > Oops, my bad, didn't mean to drop the ML. No problem. Sometimes it happens. > So you're saying the setup header could expand to include some of pad7 > in the future, but we error if it goes beyond that (into the e820 Yep! > map)

Re: FTDI serial console support?

2018-05-30 Thread Daniel Kiper
On Sat, May 26, 2018 at 07:21:24AM +0200, Petter Gustad wrote: > From: Andrew Worsley > Subject: Re: FTDI serial console support? > Date: Sat, 19 May 2018 23:12:42 +1000 > > > On 19 May 2018 at 00:32, Petter Gustad wrote: > >> From: Daniel Kiper > >> Subject: Re: FTDI serial console support? > >

Re: online doc currency?

2018-05-30 Thread Daniel Kiper
On Mon, May 21, 2018 at 01:26:25AM -0400, Felix Miata wrote: > https://www.gnu.org/software/grub/manual/grub/html_node/Command_002dline-and-menu-entry-commands.html > shows only a small fraction of what I see at a grub> prompt, where there are > 19 > items starting with the string "net_" alone. Is

Re: [PATCH 9/9] btrfs: add RAID 6 recovery for a btrfs filesystem.

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:19PM +0200, Goffredo Baroncelli wrote: > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the old md RAID 6 code already s/the old md/the md/ > present in grub. > > Signed-off-by: Goffredo Baronc

Re: [PATCH 8/9] btrfs: make more generic the code for RAID 6 rebuilding

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:18PM +0200, Goffredo Baroncelli wrote: > The original code which handles the recovery of a RAID 6 disks array > assumes that all reads are multiple of 1 << GRUB_DISK_SECTOR_BITS and it > assumes that all the I/O is done via the struct grub_diskfilter_segment. > This is

Re: [PATCH 7/9] btrfs: add support for recovery for a RAID 5 btrfs profiles.

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:17PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 174 ++- > 1 file changed, 170 insertions(+), 4 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH 6/9] btrfs: refactor the code that read from disk

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:16PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the RAID 5/6 recovery Please move "This is a preparatory patch" sentence below... > code. In case of availability of all disks, this code is good for all the > RAID profiles.

Re: [PATCH 5/9] btrfs: move logging code in grub_btrfs_read_logical()

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:15PM +0200, Goffredo Baroncelli wrote: > A portion of the logging code is moved outside a for(;;). The part that is s/outside a for/outside of for/ > left inside is the one which depends by the for(;;) index. s/depends by the for/depends on the for/ By the way, the

Re: [PATCH 4/9] btrfs: avoiding a rescan for a device which was already not founded.

2018-05-30 Thread Daniel Kiper
WRT the subject: s/btrfs: avoiding a rescan for a device which was already not founded./ btrfs: Avoid a rescan for a device which was already not found/ On Wed, May 16, 2018 at 08:48:14PM +0200, Goffredo Baroncelli wrote: > If a device is not found, record this failure storing NULL in s/failure

Re: [PATCH 3/9] btrfs: move the error logging from find_device() to its callee.

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:13PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this s/callee/caller/ > error is fatal or not, i.e. another available disk. s/i.e. another available disk./e.g. another disk is available or not./ And I think that you

Re: [PATCH 2/9] btrfs: add helper to check the btrfs header.

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:12PM +0200, Goffredo Baroncelli wrote: > This helper will be used in few places to help the debugging. As s/in few/in a few/ > conservative approach, in case of error it is only logged. This s/This/This is/ Otherwise LGTM. Daniel _

Re: [PATCH 1/9] btrfs: add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-05-30 Thread Daniel Kiper
On Wed, May 16, 2018 at 08:48:11PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 68 > 1 file changed, 68 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544