On Wed, May 16, 2018 at 08:48:15PM +0200, Goffredo Baroncelli wrote: > A portion of the logging code is moved outside a for(;;). The part that is
s/outside a for/outside of for/ > left inside is the one which depends by the for(;;) index. s/depends by the for/depends on the for/ By the way, there are 2 for(;;). You have to be clear which one. > This is a preparatory patch: in the next one it will be possible to refactor > the code inside the for(;;) in an another function. I think that you can drop these sentences. However, it seems to me that you are no giving the reason why this move is needed for subsequent patches. Please explain that in the commit message. And missing SOB. The code itself LGTM. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
