On Wed, May 16, 2018 at 08:48:13PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this
s/callee/caller/ > error is fatal or not, i.e. another available disk. s/i.e. another available disk./e.g. another disk is available or not./ And I think that you can reverse order of the sentences above. WRT the subject: s/Move the error logging logic from find_device() to the callee./ Move the error logging from find_device() to its caller/ Otherwise LGTM. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel