Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.04.2013 20:07, Leif Lindholm wrote: > I don't see grub-mkimage currently being fully cross-platform anyway, > so I would (as mentioned in previous email) prefer to postpone any > such adjustments until the basic support is in. I have the patches > for it, if not entirely up to date. grub-mk

Re: [PATCH 3/7] Initial support for U-Boot platforms

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.04.2013 20:05, Lennart Sorensen wrote: > On Wed, Apr 03, 2013 at 04:24:51PM +, Leif Lindholm wrote: >> Because I am an overtly paranoid person. :) > > That's not paranoid. That's just inefficient. The length argument has > to be based on the target size, NOT the length of the source.

Re: grub2-rc1-emu under cygwin

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 31.01.2013 23:20, Cyrille Lefevre wrote: > Hi, > > I'm attempting to build grub2-rc1 -emu under cygwin w/o success. > I've made a fast and dirty patch about the missing stuff (emunet tap), > see attachment, > It breaks Linux part, you need #ifdef's # but I don't known how to say to the build

Re: DSA GnuPG signatures

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 31.01.2013 13:49, Andrey Borzenkov wrote: > В Fri, 11 Jan 2013 21:54:22 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> Hello, all. I've just committed import of libgcrypt and implementation >> of related code to check signatures. Short usage: >> verify_detached FILE FILE.sig [pubke

Re: [PATCH] fix entry editor screen screen layout corruption in trunk

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 17.02.2013 16:15, Andrey Borzenkov wrote: > See screenshot for what I get using current trunk. > > I do not pretend to fully understand all this code so review is > appreciated. So far it does fix both gfxterm and console cases for me. I've fixed the same problem by much smaller logic change

Re: [PATCH] Make grub_efidisk_get_device_name() work on 4K native disks.

2013-04-03 Thread Andrey Borzenkov
В Wed, 3 Apr 2013 11:53:06 -0400 Peter Jones пишет: > When we have 4kB sectors instead of 512b sectors, hd.partition_start and > grub_partition_get_start() won't match - the latter assumes 512-byte > sectors, and the former gives us the correct number based on the > physical media's sector size.

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 06:24:43PM +0200, Francesco Lavra wrote: > On 03/24/2013 06:01 PM, Leif Lindholm wrote: > > === added file 'grub-core/kern/arm/efi/misc.c' > > --- grub-core/kern/arm/efi/misc.c 1970-01-01 00:00:00 + > > +++ grub-core/kern/arm/efi/misc.c 2013-03-24 15:43:19 + > [.

Re: [PATCH 3/7] Initial support for U-Boot platforms

2013-04-03 Thread Lennart Sorensen
On Wed, Apr 03, 2013 at 04:24:51PM +, Leif Lindholm wrote: > Because I am an overtly paranoid person. :) That's not paranoid. That's just inefficient. The length argument has to be based on the target size, NOT the length of the source. If you want to length of the source, that's what plain

Re: [PATCH] Add DragonFly BSD disklabel64 support

2013-04-03 Thread Radosław Szymczyszyn
> Please email the following information [...] Done. >> +fail: >> + return grub_error (GRUB_ERR_BAD_PART_TABLE, "disklabel64 not found"); >> +} > There is only one user for this label. Please put this part directly at > where it's used Fixed. part-dfly.3.patch Description: Binary data __

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 04:31:13AM +0200, Vladimir '??-coder/phcoder' Serbinenko wrote: > > +static grub_uint64_t > > > +grub_efi_get_time_ms(void) > > +{ > > + grub_efi_time_t now; > > + grub_uint64_t retval; > > + grub_efi_status_t status; > > + > > + status = efi_call_2 (grub_efi_system_ta

Re: [PATCH 6/7] add ARM Linux loader

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 06:18:17PM +0200, Francesco Lavra wrote: > On 03/24/2013 06:01 PM, Leif Lindholm wrote: > > === added directory 'grub-core/loader/arm' > > === added file 'grub-core/loader/arm/linux.c' > > --- grub-core/loader/arm/linux.c1970-01-01 00:00:00 + > > +++ grub-core/loader

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 04:15:03AM +0200, Vladimir '??-coder/phcoder' Serbinenko wrote: > > +#define GRUB_KERNEL_MACHINE_STACK_SIZE 0x4 > > +#define GRUB_KERNEL_MACHINE_HEAP_SIZE (grub_size_t) (2 * 1024 * 1024) > > Why so small heap? I copied ieee1275 HEAP_MIN_SIZE to begin with, and it wa

Re: [PATCH 3/7] Initial support for U-Boot platforms

2013-04-03 Thread Leif Lindholm
On Sat, Mar 30, 2013 at 05:20:54PM +0100, Francesco Lavra wrote: > Mostly cosmetic comments from my side here... Typos will be fixed. > On 03/24/2013 06:01 PM, Leif Lindholm wrote: > [...] > > === added file 'grub-core/kern/uboot/init.c' > > --- grub-core/kern/uboot/init.c 1970-01-01 00:00:0

Re: [PATCH 3/7] Initial support for U-Boot platforms

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 04:08:59AM +0200, Vladimir '??-coder/phcoder' Serbinenko wrote: > On 24.03.2013 18:01, Leif Lindholm wrote: > About memory map: > It would make sense to put modules right before heap as module space is > reused later as heap if this is enabled. So, move stack to after hea

[PATCH] Make grub_efidisk_get_device_name() work on 4K native disks.

2013-04-03 Thread Peter Jones
When we have 4kB sectors instead of 512b sectors, hd.partition_start and grub_partition_get_start() won't match - the latter assumes 512-byte sectors, and the former gives us the correct number based on the physical media's sector size. So when we have to compare them, we need to compensate. Sign

Re: [PATCH 2/7] Initial support for ARMv7 architecture

2013-04-03 Thread Leif Lindholm
On Sat, Mar 30, 2013 at 04:15:54PM +0100, Francesco Lavra wrote: > On 03/24/2013 06:01 PM, Leif Lindholm wrote: > [...] > > === added file 'grub-core/kern/arm/cache.S' > > --- grub-core/kern/arm/cache.S 1970-01-01 00:00:00 + > > +++ grub-core/kern/arm/cache.S 2013-03-24 12:56:20 +

Re: [PATCH 2/7] Initial support for ARMv7 architecture

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 03:28:17AM +0200, Vladimir '??-coder/phcoder' Serbinenko wrote: > > === added directory 'grub-core/kern/arm' > > > === added file 'grub-core/kern/arm/cache.S' > > --- grub-core/kern/arm/cache.S 1970-01-01 00:00:00 + > > +++ grub-core/kern/arm/cache.S 2013-03-

Re: [PATCH 1/7] ARM/U-Boot basic build system additions

2013-04-03 Thread Leif Lindholm
On Sat, Mar 30, 2013 at 04:09:28PM +0100, Francesco Lavra wrote: > > + CFLAGS_PLATFORM += -mthumb-interwork -mno-unaligned-access -mlong-calls > > + CCASFLAGS_PLATFORM = -Wa,-mimplicit-it=thumb > > The -mimplicit-it=thumb assembler option is generally frowned upon and > is used mostly to convert

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 04:29:02PM +0200, Francesco Lavra wrote: > >> On 04/01/2013 04:15 AM, Vladimir '??-coder/phcoder' Serbinenko wrote: > Which architecture is raspberry pie? I have one here and it would be > good if I could use it for testing. > >> It's ARMv6, so unfortunately it's n

Re: [PATCH/RFC] cpuid.c: Provide CPU model information

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.01.2013 21:36, David Michael wrote: > insmod cpuid > if [ "$cpuid_model_name" = "QEMU Virtual CPU ... This is not a proper way to detect qemu (see -cpu ?). You should probably rather parse smbios tables signature.asc Description: OpenPGP digital signature

Re: Command documentation part 1.

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.03.2013 09:46, Andrey Borzenkov wrote: > В Tue, 26 Mar 2013 11:48:37 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >>> +@deffn Command background_color color >>> +Set background color for active terminal. For valid color specifications >>> see >>> +@pxref{Theme file format, ,Colo

Re: [PATCH] Add DragonFly BSD disklabel64 support

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.03.2013 15:44, Radosław Szymczyszyn wrote: > +fail: > + return grub_error (GRUB_ERR_BAD_PART_TABLE, "disklabel64 not found"); > +} There is only one user for this label. Please put this part directly at where it's used signature.asc Description: OpenPGP digital signature ___

Re: [PATCH] multistring support in gui_label

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.03.2013 16:58, Vladimir Testov wrote: > +word_width = label_string_width (buf, font, l_lastend, end); > +if (isvertical || (str_width + word_width > l_width)) // can't add new > word > + { Please don't use // comments. This code completely forgets the cases when even the first

Re: [PATCH] Add missing ARM relocation codes and fix existing ones

2013-04-03 Thread Leif Lindholm
On Mon, Apr 01, 2013 at 06:45:16PM +0200, Francesco Lavra wrote: > On 03/17/2013 09:36 PM, Francesco Lavra wrote: > > I'm working on the GRUB port to ARM using the EFI platform. When > > generating a relocatable ARM image, some relocation entries use a > > relocation code (0x33) which is not define

Re: [3/4] [PATCH] start angle (option of circular_progress)

2013-04-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 20.03.2013 08:41, Vladimir Testov wrote: > new option: start_angle_degrees > > maybe like that? :) > Using a different option for the same thing just expressed in different units isn't good or natural. It's more natural to use unit modifiers like start_angle = "90°" or start_angle = "90 deg"