On 22.03.2013 16:58, Vladimir Testov wrote: > + word_width = label_string_width (buf, font, l_lastend, end); > + if (isvertical || (str_width + word_width > l_width)) // can't add new > word > + {
Please don't use // comments. This code completely forgets the cases when even the first word doesn't fit in the available space. The code as whole breaks some unicode concepts like e.g. bidi stack. Could you reuse the already available line-vreaking algorithm in normal/term.c and normal/charset.c ? Since the line-breaking is artificially disabled for labels it should require only minor adjustments to be reenabled.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel