Re: [GITGRUB] New menu interface (implementation)

2009-10-17 Thread Bean
Hi, Update: Add sub menu support, generate widgets dynamically using menu entries. Now grub.cfg should look like this: menuentry "AAA" { set root=(hd0,1) chainloader +1 } menuentry "BBB" --class ubuntu { true } . /menu/menu.cfg The menu have three items, AAA, BBB and Tools, which is a

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread richardvo...@gmail.com
On Sat, Oct 17, 2009 at 7:09 AM, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: >> On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> >>> Robert Millan wrote: >>> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrot

Re: [2637] 2009-10-16 Colin Watson

2009-10-17 Thread richardvo...@gmail.com
On Sat, Oct 17, 2009 at 6:40 AM, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: >> On Fri, Oct 16, 2009 at 03:38:44PM +, Colin Watson wrote: >> >>> Revision: 2637 >>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=2637 >>> Author:   cjwatson >>> Date:     2009

Test on powerpc: what means '/boot/grub must be a mount point.'

2009-10-17 Thread rubisher
Hello all, Some time ago, I tried to install a debian distro (iirc 5.0) with net-install cd on a IBM p510 lpar. All works fine, but the yaboot which cd installed failed to boot this installation :_(. I well reported the issue but never get feedback :_( On the other hand I reach to install an

Re: [patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Vasily Averin wrote: > While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid directory, > 10_linux script did not check it properly and do not set root device via UUID. > Therefore following kernel boot can fail (incorrect root device) if device > names > was changed. > > I would be

Re: [patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Felix Zielcke
Am Samstag, den 17.10.2009, 13:56 +0100 schrieb Colin Watson: > On Sat, Oct 17, 2009 at 02:50:41PM +0200, Felix Zielcke wrote: > > If /dev/disk/by-uuid/abc123 doestn't exit, then this implies > > that /dev/disk/by-uuid is not a directory. > > I think you are misreading the original patch. Check it

Re: [patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Colin Watson
On Sat, Oct 17, 2009 at 02:50:41PM +0200, Felix Zielcke wrote: > If /dev/disk/by-uuid/abc123 doestn't exit, then this implies > that /dev/disk/by-uuid is not a directory. I think you are misreading the original patch. Check it again ... -- Colin Watson [cjwa

Re: [patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Colin Watson
On Sat, Oct 17, 2009 at 04:24:53PM +0400, Vasily Averin wrote: > While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid directory, > 10_linux script did not check it properly and do not set root device via UUID. > Therefore following kernel boot can fail (incorrect root device) if device

Re: [patch] deadloop in grub_ext2_iterate_dir

2009-10-17 Thread Felix Zielcke
Am Samstag, den 17.10.2009, 16:17 +0400 schrieb Vasily Averin: > + if (grub_le_to_cpu16 (dirent.direntlen) == 0) > +return 0; > + >if (dirent.namelen != 0) For consistency we should either always use the grub_Xe_to_cpuYZ functions or never when checking for a 0 value. Oh and

Re: [patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Felix Zielcke
Am Samstag, den 17.10.2009, 16:24 +0400 schrieb Vasily Averin: > While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid > directory, > 10_linux script did not check it properly and do not set root device > via UUID. > Therefore following kernel boot can fail (incorrect root device) if >

[patch] incorrect root device while /dev/ on tmpfs

2009-10-17 Thread Vasily Averin
While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid directory, 10_linux script did not check it properly and do not set root device via UUID. Therefore following kernel boot can fail (incorrect root device) if device names was changed. Attached path fixes this issue. Please review an

filesystem check on software raid partitions

2009-10-17 Thread Vasily Averin
Dear all, I've noticed that grub2 tries to detect filesystem on software raid partitions. IMHO it isn't correct: - this partition can have correct filesystem header or superblock, and therefore it can look at the first glance as one having filesystem. However access to filesystem data is tricky, y

[patch] deadloop in grub_ext2_iterate_dir

2009-10-17 Thread Vasily Averin
fix for deadloop in grub_ext2_iterate_dir: fpos is not updated if dirent.direntlen == 0 Signed-off-by: Vasily Averin diff -up ./fs/ext2.c.e2rdr ./fs/ext2.c --- ./fs/ext2.c.e2rdr 2009-07-19 17:59:21.0 +0400 +++ ./fs/ext2.c 2009-10-17 15:28:11.0 +0400 @@ -649,6 +649,9 @@ grub_ext

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> 2009-10-16 Vladimir Serbinenko +

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Felix Zielcke
Am Samstag, den 17.10.2009, 14:00 +0200 schrieb Robert Millan: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Robert Millan wrote: > > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko > > > wrote: > > > > > >> 2009-10-16 Vladimir

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Robert Millan
On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >> 2009-10-16 Vladimir Serbinenko > >> > >> + * util/i386/pc/grub-setup.c (setup): Refuse to

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> 2009-10-16 Vladimir Serbinenko >> >> +* util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. >> +(options): New option --destroy-xfs. >> +(main): Handle

Re: [2637] 2009-10-16 Colin Watson

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Fri, Oct 16, 2009 at 03:38:44PM +, Colin Watson wrote: > >> Revision: 2637 >> http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=2637 >> Author: cjwatson >> Date: 2009-10-16 15:38:42 + (Fri, 16 Oct 2009) >> Log Message: >> --- >> 2

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Robert Millan
On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > 2009-10-16 Vladimir Serbinenko > > + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. > + (options): New option --destroy-xfs. > + (main): Handle --destroy-xfs. I gave this so

Re: [2637] 2009-10-16 Colin Watson

2009-10-17 Thread Robert Millan
On Fri, Oct 16, 2009 at 03:38:44PM +, Colin Watson wrote: > Revision: 2637 > http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=2637 > Author: cjwatson > Date: 2009-10-16 15:38:42 + (Fri, 16 Oct 2009) > Log Message: > --- > 2009-10-16 Colin Watson > >

Re: powerpc/sparc problems

2009-10-17 Thread Robert Millan
On Fri, Oct 16, 2009 at 09:21:36PM -0400, Pavel Roskin wrote: > On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote: > > > > They worked perfectly fine for me on a real system with > > a real compiler and glibc. > > > > If you're going to use cross compilation to test, use > > a full cross tool

Re: powerpc/sparc problems

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Pavel Roskin wrote: > On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote: > >> From: Pavel Roskin >> Date: Thu, 15 Oct 2009 18:41:41 -0400 >> >> >>> This makes me think that checks for __bswapsi2 and __bswapdi2 will fail >>> on Sparc64, even if those functions are present and even if >