Re: [PATCH] enable buildable targets by default

2009-07-16 Thread Pavel Roskin
Quoting Vladimir 'phcoder' Serbinenko : comitted I wish I had time to review it :-( I have fixed the easy stuff (spelling, wrong variables, use of "$no", use of "-c" in CFLAGS). The remaining problem is that efiemu only compiles on i386-pc, but configure not only checks for the necessary

Re: [PATCH] Support for OSX

2009-07-16 Thread Yves Blusseau
Le 16 juil. 09 à 21:19, Pavel Roskin a écrit : On Thu, 2009-07-16 at 19:45 +0200, Yves Blusseau wrote: Hi, here's a patch so grub-setup can be compiled and work on MacOSX. # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) if (ioctl (fd, DIOCGMEDIASIZE, &nr)) +# elif defined(__AP

Re: [PATCH] Support for OSX

2009-07-16 Thread Pavel Roskin
On Thu, 2009-07-16 at 19:45 +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > if (ioctl (fd, DIOCGMEDIASIZE, &nr)) > +# elif defined(__APPLE__) > + if (ioctl (fd, DKIOCGET

Re: [PATCH] Support for OSX

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
Hello On Thu, Jul 16, 2009 at 7:45 PM, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > There are stylistic problems with your patch. For the overview of our style see http://www.gnu.org/prep/standards/ Your tabulations are wrong. Use emacs (recomme

[PATCH] Support for OSX

2009-07-16 Thread Yves Blusseau
Hi, here's a patch so grub-setup can be compiled and work on MacOSX. The only problem remaining is trampoline (nested functions), because OSX don't want to execute code in the heap. Best Regards Yves Blusseau osx_support.diff Description: Binary data __

Re: [PATCH] enable buildable targets by default

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
comitted On Wed, Jun 17, 2009 at 3:34 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello. We often faced breakages of components which aren't enabled by > default. So Robert Millan proposed to enable all buildable tagets by > default. Here is an implementation. Additionally at the end of output > it

Re: [PATCH 1/2] RFT: Eliminate Apple specific code from boot/i386/pc/boot.S

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: > ChangeLog: > >        * boot/i386/pc/boot.S: Remove all code dependent on APPLE_CC. >        Use local labels starting with "L_" so that Apple assembler >        would know they are local. You have really a lot of patches. It's undoubtly a good

Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: > ChangeLog: > >        * Makefile.in: Remove LIBLZO and enable_lzo. >        * conf/i386-pc.rmk: Remove lzo support. >        * configure.ac: Remove checks for lzo, don't define ENABLE_LZMA. >        * include/grub/i386/pc/kernel.h: Define ENABL

Re: please stop this

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 5:23 PM, Robert Millan wrote: > On Wed, Jul 15, 2009 at 02:17:39AM +0800, Bean wrote: >> On Wed, Jul 15, 2009 at 2:09 AM, Pavel Roskin wrote: >> > On Tue, 2009-07-14 at 19:57 +0200, Robert Millan wrote: >> > >> >> I agree that we have a problem due to lack of leadership, but

Re: [PATCH] reset USB controller

2009-07-16 Thread Robert Millan
On Wed, Jul 15, 2009 at 10:51:55PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello, some BIOSes don't conform semaphore specification about handing > over the control on UHCI and/or EHCI controller. Most OS cope with it > by taking ownership regardless after some timeout. This however > increas

Re: [PATCH 1/2] Introduce grub_malloc0()

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 5:41 PM, Pavel Roskin wrote: > On Thu, 2009-07-16 at 17:22 +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: >> > Even though it's a new function added to the core, its use makes >> > core.img smaller.  And it makes modules s

Re: [PATCH 4/7] Eliminate kernel_address

2009-07-16 Thread Robert Millan
On Tue, Jul 14, 2009 at 09:00:36PM -0400, Pavel Roskin wrote: > ChangeLog: > > * boot/i386/pc/boot.S: Eliminate kernel_address. Add .bss > section corresponding to the loader. Use relative jump to the > loader. Nice simplification. But what's this .bss needed for? It doesn't

Re: [PATCH 3/7] Eliminate kernel_segment

2009-07-16 Thread Robert Millan
On Tue, Jul 14, 2009 at 09:00:30PM -0400, Pavel Roskin wrote: > ChangeLog: > > * boot/i386/pc/boot.S (kernel_segment): Remove. > (copy_buffer): Copy to 0x:0x8000, not to 0x0800:0x. This looks like it would set an higher limit to the kernel link address. Are we certain we want

Re: [PATCH 1/7] Make boot/i386/pc/boot.S safer to modify

2009-07-16 Thread Robert Millan
On Tue, Jul 14, 2009 at 09:00:17PM -0400, Pavel Roskin wrote: > ChangeLog: > > * include/grub/i386/pc/boot.h: Sort all offsets. > (GRUB_BOOT_MACHINE_KERNEL_ADDRESS): Remove, it's unused. > (GRUB_BOOT_MACHINE_KERNEL_SEGMENT): Likewise. > * boot/i386/pc/boot.S: Assert locatio

Re: [PATCH 1/2] Introduce grub_malloc0()

2009-07-16 Thread Pavel Roskin
On Thu, 2009-07-16 at 17:22 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: > > Even though it's a new function added to the core, its use makes > > core.img smaller. And it makes modules smaller too. > I like the idea even if function name is ine

Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
comitted On Sun, Jun 21, 2009 at 2:34 PM, Vladimir 'phcoder' Serbinenko wrote: > > >> >> Anyway, given that grub-emu is a debugging/development tool, I'm not sure >> it's that useful to export those flags to autoconf.  We could just live >> with #ifdefs in the code IMHO.  Distributors are going to

Re: [PATCH] fix SigSegV and hang with grub-emu-usb

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
committed On Fri, Jun 19, 2009 at 8:44 PM, Vladimir 'phcoder' Serbinenko wrote: > > > On Fri, Jun 19, 2009 at 6:52 PM, Pavel Roskin wrote: >> >> OK, I understand you tried USB mass storage devices. >> >> I believe the paramount here is consistency.  There are several places >> in the code where g

Re: [PATCH 7/7] RFC: Use correct addresses, eliminate manual relocations

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 5:44 AM, Pavel Roskin wrote: > Quoting Vladimir 'phcoder' Serbinenko : > > Sorry for the second reply.  I have some new data now. > >> AFAIR during compilation process relocation entries are preserved and >> resolved only in the last step. Now thinking it should work even >>

Re: [PATCH 1/2] Introduce grub_malloc0()

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: > Even though it's a new function added to the core, its use makes > core.img smaller.  And it makes modules smaller too. I like the idea even if function name is inexplicit. Do you have a better alterative? > > ChangeLog: > >        * kern/mm.c

Re: please stop this

2009-07-16 Thread Robert Millan
On Wed, Jul 15, 2009 at 02:17:39AM +0800, Bean wrote: > On Wed, Jul 15, 2009 at 2:09 AM, Pavel Roskin wrote: > > On Tue, 2009-07-14 at 19:57 +0200, Robert Millan wrote: > > > >> I agree that we have a problem due to lack of leadership, but this is not > >> acceptable.  Marco is busy right now (trav