Hello

On Thu, Jul 16, 2009 at 7:45 PM, Yves Blusseau<bluss...@zetam.org> wrote:
> Hi,
>
> here's a patch so grub-setup can be compiled and work on MacOSX.
>
There are stylistic problems with your patch. For the overview of our
style see http://www.gnu.org/prep/standards/
Your tabulations are wrong. Use emacs (recommended) or at least make
sure your editor creates correct identations.
We don't use // style comments. Use /* */
What is the reason of discarding const on p
> The only problem remaining is trampoline (nested functions), because OSX
> don't want
> to execute code in the heap.
Could you document on the wiki how to disable stack protection on Darwin/OSX?
>
> Best Regards
> Yves Blusseau
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to