In case someone is curios, I did refactor the code a lot more, to bring
down the gocyclo complexity from 23 to 11. I feel that this should be in a
better shape now. Thanks everyone for the comments. Let me know if you
still find any scope for optimisation or cleanup.
I would add some test cases to
2018-05-14 20:39 GMT+05:30 :
> They might have been looking for something like this:
>
> github.com/psankar/network-monitor
> package monitor code files
> cmd/
> minion/
> package main code files
> server/
> package main code files
>
The reviewer me
They might have been looking for something like this:
github.com/psankar/network-monitor
package monitor code files
cmd/
minion/
package main code files
server/
package main code files
In a code review I would mention the use of packages as not bein
There's an old Dilbert about this:
Don't know how to solve a problem? No problem! Don't hire a consultant;
hold an interview and choose the best answer you receive from all the
candidates.
I'll get my coat.
Chris
On Monday, 14 May 2018 12:35:23 UTC+1, Sankar wrote:
>
> Hi
>
> I was recently as
2018-05-14 17:28 GMT+05:30 Tamás Gulácsi :
> Minion/minion? For what?
>
So that the minion package structs can be shared between Minion/Minion.go
server and the APIServer.go server.
>
> Also APIServer.go has some goroutine starting loops that are very similar
> - should be a function.
> I'd pre
Minion/minion? For what?
Also APIServer.go has some goroutine starting loops that are very similar -
should be a function.
I'd prefer splitting the HTTP handlers to parser + executor + responder
(a'la go-kit), clarifying the business logic.
Just my 2¢.
2018. május 14., hétfő 13:35:23 UTC+2 id
