Minion/minion? For what? Also APIServer.go has some goroutine starting loops that are very similar - should be a function. I'd prefer splitting the HTTP handlers to parser + executor + responder (a'la go-kit), clarifying the business logic.
Just my 2¢. 2018. május 14., hétfő 13:35:23 UTC+2 időpontban Sankar a következőt írta: > > Hi > > I was recently asked in an interview to write a golang program for a > problem that involves working with a million nodes. I did write a program > that solved the problem statement. However, I was told that the solution > was "poorly structured", but I did not get any detailed review comments > though. > > So, I recreated the solution in github and wanted to know if anyone could > give some review comments as to what you see as bad things in the code. > > The problem statement, code and the instructions are at: > https://github.com/psankar/network-monitor > > I personally felt that the code (written in about 6 hours for the > interview) is good and I would've hired anyone writing this, but may be I > am biased because it is written by me. I want to improve my Golang skills > and your review comments would be helpful. Any help ? > > If the golang list is unsuitable for this, you can even email me, > individually, with the review comments. > > Thanks. > > Sankar > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
