[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2023-02-21 Thread Debarshi Ray
rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` > I'm actually confused why %gobuildflags exists, because > %gobuild below that doesn't use it. In fact, %gobuild > uses an exact copy of gobuildflags with BUILDTAGS > already there. A bit of Git for

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2023-02-21 Thread Debarshi Ray
rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` Speaking as someone who maintains a code base where `go build` is invoked by Meson ... > I traced through the commit history and found the commit[1] > where the %gobuildflags macro was created. It l

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2023-02-21 Thread Debarshi Ray
rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` Since commit [c593262127afd28d](https://pagure.io/go-rpm-macros/c/c593262127afd28d9f0b52a78a3cf0ef5b14673f) or PR [#35](https://pagure.io/go-rpm-macros/pull-request/35), `%gobuild` does use `%gobui

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2023-02-21 Thread Debarshi Ray
rishi commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` Anyway, I think this pull request should be closed because `BUILDTAGS` is already part of `%gobuildflags` these days. See commit [c593262127afd28d](https://pagure.io/go-rpm-macros/c/c593262127afd28

[golist] PR #30: Don't skip testdata

2023-02-21 Thread Elliott Sales de Andrade
qulogic commented on the pull-request: `Don't skip testdata` that you are following: `` Sorry, I've had to revert this change. After applying it, it causes several bugs: 1. `testdata` that includes invalid Go code can cause `golist` to panic, as it does so when importing a directory fails. 2.