Re: Patch : editing "Posted" time of transactions.

2016-02-22 Thread John Ralls
> On Feb 22, 2016, at 7:21 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > My patchset is not ready yet. > > After three weeks of intensive testing (without any crash :-), I > finally stumbled on a bug. > > That bug is that, when editing a transaction done when the daylight > settings is not the

Re: Patch : editing "Posted" time of transactions.

2016-02-22 Thread gLETTERyYuMEANSj LETTERyOt
My patchset is not ready yet. After three weeks of intensive testing (without any crash :-), I finally stumbled on a bug. That bug is that, when editing a transaction done when the daylight settings is not the same as the time of edition, the date is going earlier and earlier. To enter a correct

Re: Patch : editing "Posted" time of transactions.

2016-02-01 Thread John Ralls
> On Feb 1, 2016, at 8:08 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > Thank you very much. > > I would like to test gnc_localtime (and gnc_localtime_r). > > For that, I would like to change the timezone. > > Is there an environmental variable I can define with export of bash ? No. The defau

Re: Patch : editing "Posted" time of transactions.

2016-02-01 Thread gLETTERyYuMEANSj LETTERyOt
2016-01-28 19:54 UTC+01:00, John Ralls : > You removed the code for the auto-read-only threshold. This is because my version of gnc_tree_util_split_reg_parse_date delegated to qof_scan_date_internal, and I did not know that qof_scan_date_internal does not honor that auto-read-only threshold. I wi

Re: Patch : editing "Posted" time of transactions.

2016-02-01 Thread gLETTERyYuMEANSj LETTERyOt
Thank you very much. I would like to test gnc_localtime (and gnc_localtime_r). For that, I would like to change the timezone. Is there an environmental variable I can define with export of bash ? (sorry for the dupplicate mail to you, John) 2016-02-01 16:36 UTC+01:00, John Ralls : > >> On Feb

Re: Patch : editing "Posted" time of transactions.

2016-02-01 Thread John Ralls
> On Feb 1, 2016, at 1:50 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > Dear everyone, > > Can someone help me, by showing the right Gnucash-compatible way to recover > the > time difference due to the timezone settings at a given UTC date, in > C++ and in C? > > This is blocking any progress

Re: Patch : editing "Posted" time of transactions.

2016-02-01 Thread gLETTERyYuMEANSj LETTERyOt
Dear everyone, Can someone help me, by showing the right Gnucash-compatible way to recover the time difference due to the timezone settings at a given UTC date, in C++ and in C? This is blocking any progress from my part :-/ 2016-01-29 15:49 UTC+01:00, Geert Janssens : >

Re: Patch : editing "Posted" time of transactions.

2016-01-29 Thread John Ralls
> On Jan 29, 2016, at 6:49 AM, Geert Janssens > wrote: > > On Friday 29 January 2016 14:07:57 gLETTERyYuMEANSj LETTERyOt wrote: > > > > > I have well understood that I should not remove such comments, > > whatever the reason to above old commit. > > > In the old commit the doxygen comments

Re: Patch : editing "Posted" time of transactions.

2016-01-29 Thread Geert Janssens
On Friday 29 January 2016 14:07:57 gLETTERyYuMEANSj LETTERyOt wrote: > Dear Geert, > > Thank you for your very helpful input ! > > >> 2016-01-28 19:54 UTC+01:00, John Ralls : > >> > Don't remove function description comments; do make them Doxygen > >> > markup. > > > > On Friday 29 January 2016

Re: Patch : editing "Posted" time of transactions.

2016-01-29 Thread gLETTERyYuMEANSj LETTERyOt
Dear Geert, Thank you for your very helpful input ! >> 2016-01-28 19:54 UTC+01:00, John Ralls : >> > Don't remove function description comments; do make them Doxygen >> > markup. > On Friday 29 January 2016 11:44:53 I wrote: >> I did that because some function description comments were removed >

Re: Patch : editing "Posted" time of transactions.

2016-01-29 Thread Geert Janssens
On Friday 29 January 2016 11:44:53 gLETTERyYuMEANSj LETTERyOt wrote: > Dear John, > > Thank you very much for the help your comments provide to me ! > > I accept without additionnal question all of your comments that are > not quoted below, and will work on them. > > 2016-01-28 19:54 UTC+01:00,

Re: Patch : editing "Posted" time of transactions.

2016-01-29 Thread gLETTERyYuMEANSj LETTERyOt
Dear John, Thank you very much for the help your comments provide to me ! I accept without additionnal question all of your comments that are not quoted below, and will work on them. 2016-01-28 19:54 UTC+01:00, John Ralls : > Don't remove function description comments; do make them Doxygen marku

Re: Patch : editing "Posted" time of transactions.

2016-01-28 Thread John Ralls
> On Jan 28, 2016, at 9:43 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > 2015-05-28 17:15 UTC+02:00, John Ralls : >> Please don't submit patches to the mailing list. Open a bug in >> Bugzilla.gnome.org or fork our repo on Github, create a branch with your >> patch, and make a pull request. Patche

Re: Patch : editing "Posted" time of transactions.

2016-01-28 Thread gLETTERyYuMEANSj LETTERyOt
2015-05-28 17:15 UTC+02:00, John Ralls : > Please don't submit patches to the mailing list. Open a bug in > Bugzilla.gnome.org or fork our repo on Github, create a branch with your > patch, and make a pull request. Patches should be written against HEAD in > the branch you're working on -- which sh

Re: Patch : editing "Posted" time of transactions.

2015-08-13 Thread John Ralls
> On Aug 13, 2015, at 11:35 AM, Geert Janssens > wrote: > > On Thursday 28 May 2015 22:46:00 gLETTERyYuMEANSj LETTERyOt wrote: >> From gnucash --help: >> >> --debug Enable debugging mode: increasing logging to provide deep >> detail. --extra Enable extra/development/debugging features.

Re: Patch : editing "Posted" time of transactions.

2015-08-13 Thread Geert Janssens
On Thursday 28 May 2015 22:46:00 gLETTERyYuMEANSj LETTERyOt wrote: > From gnucash --help: > > --debug Enable debugging mode: increasing logging to provide deep > detail. --extra Enable extra/development/debugging features. > --log Log level overrides, of the form > "log.ger.path={deb

Re: Patch : editing "Posted" time of transactions.

2015-06-30 Thread John Ralls
> On Jun 30, 2015, at 4:51 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > 2015-05-29 12:05 UTC+02:00, Christoph Holtermann : >> I vote for keeping the times and making them visible. > > Thank you. > > I have created a github fork. I am trying to upload my patches there, but I am > in a busy peri

Re: Patch : editing "Posted" time of transactions.

2015-06-30 Thread gLETTERyYuMEANSj LETTERyOt
2015-05-29 12:05 UTC+02:00, Christoph Holtermann : > I vote for keeping the times and making them visible. Thank you. I have created a github fork. I am trying to upload my patches there, but I am in a busy period. Then I will switch to 1100Z. Daniel _

Re: Patch : editing "Posted" time of transactions.

2015-05-29 Thread Christoph Holtermann
Am 29.05.2015 um 00:28 schrieb John Ralls: >> I think that the coding and debugging style, the TZ environment variable and >> the lack of patch to preferences.glade are better reasons to disqualify it. > Those are all fixable. Once they’re fixed, the patch can be considered for > master, though as

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread John Ralls
> On May 28, 2015, at 1:46 PM, gLETTERyYuMEANSj LETTERyOt > wrote: > > Thank you very much to discuss with me. > >> That changes the way the database is interpreted > > I disagree. > > If the user loads a .gnucash file then edits it and saves it, the date field > of > a preexisting transact

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread gLETTERyYuMEANSj LETTERyOt
Thank you very much to discuss with me. > That changes the way the database is interpreted I disagree. If the user loads a .gnucash file then edits it and saves it, the date field of a preexisting transaction only changes if: - the date field used another timezone than + (gnucash-2.4), in w

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread John Ralls
> On May 28, 2015, at 10:26 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > >> Daniel, >> >> Please don't submit patches to the mailing list. Open a bug in >> Bugzilla.gnome.org or fork our repo on Github, create a branch with your >> patch, and make a pull request. > > I'll choose the buzgilla bug

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread gLETTERyYuMEANSj LETTERyOt
2015-05-28 20:02 UTC+02:00, Michael Ferrara : > I see how noting transaction times down to the fraction of a second could > be useful for quantitative analysis of a stock market. Among the multiple date format used (from memory: struct tm, Timespec, time64, GDate, GDateTime, {int day, month, year}

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread Michael Ferrara
I see how noting transaction times down to the fraction of a second could be useful for quantitative analysis of a stock market. For instance, I know a guy working on relativistic trading... That is, markets and computers are getting so fast that the SEC has to factor in nano-seconds, GPS, and Eins

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread gLETTERyYuMEANSj LETTERyOt
> Daniel, > > Please don't submit patches to the mailing list. Open a bug in > Bugzilla.gnome.org or fork our repo on Github, create a branch with your > patch, and make a pull request. I'll choose the buzgilla bug. I'll then ask my boss if I can take time for a github account (would be my first

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread John Ralls
> On May 28, 2015, at 6:37 AM, gLETTERyYuMEANSj LETTERyOt > wrote: > > Dear developers, > > For my work I had to patch gnucash-2.6.5 so that time of transactions are > displayed and editable, and so that new transactions are correctly > timestamped. > > I plan to release the resulting patche

Re: Patch : editing "Posted" time of transactions.

2015-05-28 Thread Geert Janssens
Hi Daniel, I'm pleased to hear you have been working on gnucash for your work :) Your work is in a way one possible solution for https://bugzilla.gnome.org/show_bug.cgi?id=137017 and https://bugzilla.gnome.org/show_bug.cgi?id=89439 And we also have two voting tickets on uservoice: http://gnucash