> On Feb 22, 2016, at 7:21 AM, gLETTERyYuMEANSj LETTERyOt > <gletteryyumeansjletter...@gmail.com> wrote: > > My patchset is not ready yet. > > After three weeks of intensive testing (without any crash :-), I > finally stumbled on a bug. > > That bug is that, when editing a transaction done when the daylight > settings is not the same as the time of edition, the date is going > earlier and earlier. To enter a correct time, it is now necessary add > *three times* that time difference. > > 2016-01-28 19:54 UTC+01:00, John Ralls <jra...@ceridwen.us>: >> BTW your >> https://github.com/gijut/gnucash/commit/885314788855f74d920e0637ea41b3289f5b55b4 >> incorrectly copies a GCC bug: >> https://sourceware.org/bugzilla/show_bug.cgi?id=15366 *and* overrides a >> #define that belongs to the libc/libc++ headers. >> (The bug was the result of the GCC folks following an effort by the ISO C >> committee to tell the ISO C++ committee what to do. The ISO C++ committee >> ignored them, but the GCC folks didn't. The ISO C committee fixed their >> overstep in C11. See http://en.cppreference.com/w/Talk:cpp/types/integer. >> >> Please remove that commit. > > This is yet to be done, and I also have to undo some color editing (I > am vision impaired). > >> Don't change ChangeLog. It's automatically generated from the git log at >> each release. > > This has been done. > >> You removed the code for the auto-read-only threshold. > > This has been corrected (as discussed earlier). > >> Don't use Timespec in new code, use time64. > > This is still future work. > >> Don't remove function description comments; do make them Doxygen markup. > > This has been corrected (as discussed earlier). > >> Don't use magic numbers. Create static const variables (not #defines!) with >> descriptive names. > > This has been done. > > [...] > >>> * if TZ is not defined, gnucash crashes immediately. >> The crashes alone make this patch incomplete and unacceptable as-written. > > This has been corrected. > >> That's all I have time for now, and I won't have more for a couple of weeks. >> In that time, please rewrite your submission taking the above into account >> and complying with http://wiki.gnucash.org/wiki/CodingStandard. Put it in a >> feature branch and squash out irrelevant commits. I'll do a deeper review >> then. > > Sorry, I am not yet ready.
No problem and no rush. Regards, John Ralls _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
