xudong963 commented on issue #15290:
URL: https://github.com/apache/datafusion/issues/15290#issuecomment-2732391652
There is a proposal: https://github.com/apache/datafusion/pull/15296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
UBarney commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2000992780
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,423 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstGroupsAccumulator
+wh
alamb commented on issue #15291:
URL: https://github.com/apache/datafusion/issues/15291#issuecomment-2732103208
Thanks @aectaan -- what is the error message that you get?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
UBarney commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2000992780
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,423 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstGroupsAccumulator
+wh
Omega359 commented on code in PR #15242:
URL: https://github.com/apache/datafusion/pull/15242#discussion_r2001009802
##
datafusion/sqllogictest/test_files/union_by_name.slt:
##
@@ -287,3 +287,137 @@ SELECT '0' as c UNION ALL BY NAME SELECT 0 as c;
0
0
+
+# Regression tes
blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2001416176
##
datafusion/core/Cargo.toml:
##
@@ -126,6 +126,7 @@ datafusion-physical-plan = { workspace = true }
datafusion-sql = { workspace = true }
flate2 = { version =
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001379803
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -153,7 +151,15 @@ async fn schema_merge_can_preserve_metadata() {
let actual = df.collect().await.unwrap();
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001384434
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -145,16 +146,7 @@ async fn parquet_distinct_partition_col() -> Result<()> {
.collect()
.awai
sdht0 commented on PR #15286:
URL: https://github.com/apache/datafusion/pull/15286#issuecomment-2733877823
Ah fixed it thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
xudong963 commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2001108185
##
datafusion/sqllogictest/test_files/explain_tree.slt:
##
@@ -202,53 +202,48 @@ physical_plan
02)│ AggregateExec │
03)│
xudong963 commented on PR #15268:
URL: https://github.com/apache/datafusion/pull/15268#issuecomment-2733344214
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xudong963 merged PR #15268:
URL: https://github.com/apache/datafusion/pull/15268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on issue #15290:
URL: https://github.com/apache/datafusion/issues/15290#issuecomment-2732132955
> Will require an accurate distribution (not just an approximation
Yes, it depends on whether each distribution is accurate, if they're, the
merged distribution should b
Dandandan commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2000574008
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,423 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstGroupsAccumulator
xudong963 commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2000832270
##
datafusion/sqllogictest/test_files/explain_tree.slt:
##
@@ -202,53 +202,48 @@ physical_plan
02)│ AggregateExec │
03)│
alamb commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2733529188
Converting to a draft until we hav spawn service
- https://github.com/apache/arrow-rs/pull/7253
--
This is an automated message from the Apache Git Service.
To respond to the messa
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r2000904176
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1571,14 +1571,18 @@ async fn with_column_join_same_columns() -> Result<()> {
assert_snapshot!(
Omega359 commented on PR #15101:
URL: https://github.com/apache/datafusion/pull/15101#issuecomment-2733251482
Is this ready for review or is there something outstanding for it to be
still in draft?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
irenjj commented on PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#issuecomment-2733266739
Thanks @alamb, @jayzhan211 and @xudong963 for your review, here are two
points that remain unclear:
1. For GROUP BY, is it necessary to preserve the row index -- for more
informati
sdht0 commented on PR #15286:
URL: https://github.com/apache/datafusion/pull/15286#issuecomment-2733900724
Weird that I received an email about another comment from Weijun-H but can't
see it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
irenjj commented on PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#issuecomment-2732945218
> Is it possible to modify `Display` for Expr for explain statement?
I haven't tried it, not sure how it will affect other logic.
--
This is an automated message from the Apac
blaginin commented on code in PR #14954:
URL: https://github.com/apache/datafusion/pull/14954#discussion_r2001448048
##
datafusion-cli/tests/cli_integration.rs:
##
@@ -51,6 +51,163 @@ fn init() {
["--command", "show datafusion.execution.batch_size", "--format", "json",
"-q
RaghavendraGanesh commented on issue #1509:
URL:
https://github.com/apache/datafusion-comet/issues/1509#issuecomment-2733053103
Thanks @andygrove , will give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
GitHub user bertvermeiren edited a discussion: enum Expr extension on logical
level
Hi,
In order to write some additional logical and physical plan implementations, we
do have to create some kind of "composite" logical expression.
Nowadays in the code base you have already existing expressi
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001378037
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -82,7 +69,18 @@ async fn schema_merge_ignores_metadata_by_default() {
.unwrap();
let actual = df.col
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001380462
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -167,7 +173,15 @@ async fn schema_merge_can_preserve_metadata() {
assert_eq!(actual.clone(), expected_metadat
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001378793
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -97,7 +95,18 @@ async fn schema_merge_ignores_metadata_by_default() {
.collect()
.await
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001386538
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -430,21 +381,7 @@ async fn parquet_multiple_partitions() -> Result<()> {
.collect()
.await?;
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001387282
##
datafusion/core/tests/sql/select.rs:
##
@@ -30,23 +30,7 @@ async fn test_list_query_parameters() -> Result<()> {
.with_param_values(vec
}
alamb commented on issue #15298:
URL: https://github.com/apache/datafusion/issues/15298#issuecomment-2734055350
Thank you @Omega359 -- I agree this is very important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on code in PR #15263:
URL: https://github.com/apache/datafusion/pull/15263#discussion_r200126
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -224,6 +224,327 @@ mod tests {
)
}
+#[tokio::test]
+async fn test_pushdown_
milenkovicm commented on issue #1205:
URL:
https://github.com/apache/datafusion-ballista/issues/1205#issuecomment-2734056479
once we have s3 support it should work with minio. would you be interested
in contributing @fithisux ?
--
This is an automated message from the Apache Git Service
alamb commented on issue #15298:
URL: https://github.com/apache/datafusion/issues/15298#issuecomment-2734058015
I think this is a good first issue as the write up is clear and there is an
example to follow
--
This is an automated message from the Apache Git Service.
To respond to the mess
alamb commented on issue #15291:
URL: https://github.com/apache/datafusion/issues/15291#issuecomment-2734059396
Thanks @aectaan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on issue #15291:
URL: https://github.com/apache/datafusion/issues/15291#issuecomment-2734063672
I wonder if you can get a pure SQL (`datafusion-cli` based) reproducer? Or
does it require creating and configuring a custom context / optimizer rules 🤔
--
This is an automated
xudong963 opened a new pull request, #15296:
URL: https://github.com/apache/datafusion/pull/15296
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/15290
## Rationale for this change
See issue #15290
## What change
2010YOUY01 commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2000593852
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,423 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstGroupsAccumulator
irenjj commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2000877388
##
datafusion/sqllogictest/test_files/explain_tree.slt:
##
@@ -202,53 +202,48 @@ physical_plan
02)│ AggregateExec │
03)│ │
xudong963 merged PR #15294:
URL: https://github.com/apache/datafusion/pull/15294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
GitHub user dadepo added a comment to the discussion: Does DataFusion Support
JSON Path Filtering Like `jsonb_path_exists` in PostgreSQL?
> You could create a function called `jsonb_path_exists` that takes a binary
> column and a json path string perhaps?
I think what I am missing is how this
savaliyabhargav commented on issue #13815:
URL: https://github.com/apache/datafusion/issues/13815#issuecomment-2732178094
@matthewmturner yes sure i am interested can you please give me more detail
about it
--
This is an automated message from the Apache Git Service.
To respond to th
xudong963 opened a new issue, #15290:
URL: https://github.com/apache/datafusion/issues/15290
### Is your feature request related to a problem or challenge?
I'm working on the ticket: https://github.com/apache/datafusion/issues/10316.
Given that, we'll replace all `Precision` wit
andygrove commented on code in PR #1540:
URL: https://github.com/apache/datafusion-comet/pull/1540#discussion_r2001302504
##
docs/source/user-guide/kubernetes.md:
##
@@ -65,31 +65,31 @@ metadata:
spec:
type: Scala
mode: cluster
- image: ghcr.io/apache/datafusion-comet:sp
fithisux commented on issue #1205:
URL:
https://github.com/apache/datafusion-ballista/issues/1205#issuecomment-2733646600
I would rather have minio support because they provide full working docker
images that you incorporate in a full fledge docker compose educational stack.
--
This is a
aectaan commented on issue #15291:
URL: https://github.com/apache/datafusion/issues/15291#issuecomment-2732112476
@alamb it's related to common subexpr eliminate:
```
called `Result::unwrap()` on an `Err` value: Context("Optimizer rule
'common_sub_expression_eliminate' failed", SchemaE
kosiew opened a new pull request, #15295:
URL: https://github.com/apache/datafusion/pull/15295
## Which issue does this PR close?
- Closes #14757.
## Rationale for this change
This PR introduces a `NestedStructSchemaAdapter` to improve schema evolution
handling in DataFu
kosiew commented on code in PR #15295:
URL: https://github.com/apache/datafusion/pull/15295#discussion_r2000486806
##
datafusion/datasource/src/nested_schema_adapter.rs:
##
@@ -0,0 +1,582 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
kosiew commented on code in PR #15295:
URL: https://github.com/apache/datafusion/pull/15295#discussion_r2000486806
##
datafusion/datasource/src/nested_schema_adapter.rs:
##
@@ -0,0 +1,582 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
irenjj commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2001153997
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -801,6 +803,16 @@ impl DisplayAs for AggregateExec {
}
}
Display
onlyjackfrost commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r2001158621
##
datafusion/sql/src/expr/unary_op.rs:
##
@@ -45,7 +45,18 @@ impl SqlToRel<'_, S> {
{
Ok(operand)
} e
iffyio commented on code in PR #1766:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1766#discussion_r2001170116
##
src/ast/mod.rs:
##
@@ -2256,6 +2256,57 @@ impl fmt::Display for ConditionalStatements {
}
}
+/// A `RAISE` statement.
+///
+/// Examples:
+//
irenjj commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2001176277
##
datafusion/expr/src/expr.rs:
##
@@ -2596,6 +2612,176 @@ impl Display for SchemaDisplay<'_> {
}
}
+struct SqlDisplay<'a>(&'a Expr);
+impl Display for SqlD
onlyjackfrost commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r2001158621
##
datafusion/sql/src/expr/unary_op.rs:
##
@@ -45,7 +45,18 @@ impl SqlToRel<'_, S> {
{
Ok(operand)
} e
iffyio merged PR #1766:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
eliaperantoni commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r2001166961
##
datafusion/sql/src/expr/unary_op.rs:
##
@@ -45,7 +45,18 @@ impl SqlToRel<'_, S> {
{
Ok(operand)
} e
onlyjackfrost commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r2001158621
##
datafusion/sql/src/expr/unary_op.rs:
##
@@ -45,7 +45,18 @@ impl SqlToRel<'_, S> {
{
Ok(operand)
} e
blaginin commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2001206529
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,424 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstPrimitiveGroupsAccum
blaginin commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2001210201
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,424 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstPrimitiveGroupsAccum
alamb commented on issue #15067:
URL: https://github.com/apache/datafusion/issues/15067#issuecomment-2733546979
I am convinced this issue would be solved with automatic retries
- https://github.com/apache/arrow-rs/issues/7242
--
This is an automated message from the Apache Git Service.
iffyio commented on code in PR #1767:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1767#discussion_r2000290321
##
src/ast/mod.rs:
##
@@ -7919,11 +7921,28 @@ impl fmt::Display for ContextModifier {
write!(f, "")
}
Self::L
dependabot[bot] opened a new pull request, #15292:
URL: https://github.com/apache/datafusion/pull/15292
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.15.1 to 1.16.0.
Release notes
Sourced from https://github.com/uuid-rs/uuid/releases";>uuid's releases.
v1.16.0
What'
dependabot[bot] opened a new pull request, #15293:
URL: https://github.com/apache/datafusion/pull/15293
Bumps [rust_decimal](https://github.com/paupino/rust-decimal) from 1.36.0 to
1.37.0.
Release notes
Sourced from https://github.com/paupino/rust-decimal/releases";>rust_decimal's
dependabot[bot] opened a new pull request, #15294:
URL: https://github.com/apache/datafusion/pull/15294
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.87 to
0.1.88.
Release notes
Sourced from https://github.com/dtolnay/async-trait/releases";>async-trait's
rel
suibianwanwank commented on PR #15281:
URL: https://github.com/apache/datafusion/pull/15281#issuecomment-2731893665
@alamb Hi, I have updated the PR title to start with "fix," but it seems
that the "bug" label has not been added. And the PR is now ready for review,
Please take a look at you
berkaysynnada merged PR #15284:
URL: https://github.com/apache/datafusion/pull/15284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
berkaysynnada commented on PR #15284:
URL: https://github.com/apache/datafusion/pull/15284#issuecomment-2731952749
Thank you @alamb and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb closed issue #15105: Upgrade Guide for DataFusion 46 does not include the
array signatures change
URL: https://github.com/apache/datafusion/issues/15105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
adriangb commented on code in PR #15263:
URL: https://github.com/apache/datafusion/pull/15263#discussion_r2001600091
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -224,6 +224,327 @@ mod tests {
)
}
+#[tokio::test]
+async fn test_pushdo
alamb merged PR #15237:
URL: https://github.com/apache/datafusion/pull/15237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
andygrove merged PR #1544:
URL: https://github.com/apache/datafusion-comet/pull/1544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
mbutrovich opened a new pull request, #1547:
URL: https://github.com/apache/datafusion-comet/pull/1547
## Which issue does this PR close?
Closes #.
## Rationale for this change
We don't need the whole Spark repository to run Spark SQL tests.
Current
alamb commented on issue #15291:
URL: https://github.com/apache/datafusion/issues/15291#issuecomment-2734534317
> Unfortunately `datafusion-cli` parser fails at this request: doesn't like
opening brace before WHERE - that's why I made it as a test. Maybe I missing
something.
Maybe yo
alamb commented on code in PR #15260:
URL: https://github.com/apache/datafusion/pull/15260#discussion_r2001661867
##
datafusion/catalog/Cargo.toml:
##
@@ -35,17 +35,18 @@ arrow = { workspace = true }
async-trait = { workspace = true }
dashmap = { workspace = true }
datafusion
comphead commented on code in PR #1540:
URL: https://github.com/apache/datafusion-comet/pull/1540#discussion_r2001712113
##
docs/source/user-guide/kubernetes.md:
##
@@ -65,31 +65,31 @@ metadata:
spec:
type: Scala
mode: cluster
- image: ghcr.io/apache/datafusion-comet:spa
alamb merged PR #15286:
URL: https://github.com/apache/datafusion/pull/15286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed pull request #15285: WIP: Test arrow-rs 54.3.0 upgrade
URL: https://github.com/apache/datafusion/pull/15285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
comphead commented on code in PR #1456:
URL: https://github.com/apache/datafusion-comet/pull/1456#discussion_r2001744891
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -61,13 +61,15 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde wit
alamb commented on PR #15239:
URL: https://github.com/apache/datafusion/pull/15239#issuecomment-2734365565
Thanks again@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
andygrove commented on code in PR #1548:
URL: https://github.com/apache/datafusion-comet/pull/1548#discussion_r2001820424
##
README.md:
##
@@ -46,23 +46,23 @@ The following chart shows the time it takes to run the 22
TPC-H queries against
using a single executor with 8 cores.
alamb commented on PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#issuecomment-2734461898
> Thanks @alamb, @jayzhan211 and @xudong963 for your review, here are two
points that remain unclear:
>
> 1. For GROUP BY, is it necessary to preserve the row ind
jonahgao commented on code in PR #15300:
URL: https://github.com/apache/datafusion/pull/15300#discussion_r2002313134
##
datafusion/sqllogictest/test_files/union.slt:
##
@@ -907,11 +907,56 @@ SELECT * FROM (SELECT y FROM u1 UNION ALL SELECT y FROM
u2) ORDER BY y;
20
40
+quer
jonahgao merged PR #15300:
URL: https://github.com/apache/datafusion/pull/15300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jsai28 commented on issue #14429:
URL: https://github.com/apache/datafusion/issues/14429#issuecomment-2735199806
Hi, is this still a potential GSoC project? It looks like many of the
tickets in this epic have an open pull request and are close to completion. If
you know of any other areas t
Kontinuation commented on issue #1523:
URL:
https://github.com/apache/datafusion-comet/issues/1523#issuecomment-2735209828
The query blocked because we don't have enough number of blocking threads
configured for the tokio runtime.
In merge phase, each spill file will be wrapped by a
matthewmturner commented on issue #13815:
URL: https://github.com/apache/datafusion/issues/13815#issuecomment-2735185316
For the WASM UDFs they just need some more real world testing /
benchmarking. To be honest, the other points @alamb mentioned would probably
better benefit the DataFusio
xudong963 commented on code in PR #15296:
URL: https://github.com/apache/datafusion/pull/15296#discussion_r2002335941
##
datafusion/expr-common/src/statistics.rs:
##
@@ -857,6 +857,143 @@ pub fn compute_variance(
ScalarValue::try_from(target_type)
}
+/// Merges two distr
xudong963 commented on code in PR #15296:
URL: https://github.com/apache/datafusion/pull/15296#discussion_r2002299377
##
datafusion/expr-common/src/statistics.rs:
##
@@ -857,6 +857,143 @@ pub fn compute_variance(
ScalarValue::try_from(target_type)
}
+/// Merges two distr
xudong963 commented on issue #15151:
URL: https://github.com/apache/datafusion/issues/15151#issuecomment-2735217322
Just a reminder, we can do a final release today, it seems to require a PMC
member to do the last steps. cc@alamb.
--
This is an automated message from the Apache Git Servic
xudong963 commented on PR #15296:
URL: https://github.com/apache/datafusion/pull/15296#issuecomment-2735210417
> I think eventually it would be nice to add some tests for this code
Yes, as the ticket description said: I'll do it after we are consistent.
--
This is an automated messa
UBarney commented on code in PR #15266:
URL: https://github.com/apache/datafusion/pull/15266#discussion_r2002297890
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -179,6 +292,424 @@ impl AggregateUDFImpl for FirstValue {
}
}
+struct FirstPrimitiveGroupsAccumu
iffyio commented on code in PR #1767:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1767#discussion_r2001562854
##
src/ast/mod.rs:
##
@@ -7919,11 +7921,28 @@ impl fmt::Display for ContextModifier {
write!(f, "")
}
Self::L
1 - 100 of 228 matches
Mail list logo
