irenjj commented on code in PR #15253:
URL: https://github.com/apache/datafusion/pull/15253#discussion_r2000877388


##########
datafusion/sqllogictest/test_files/explain_tree.slt:
##########
@@ -202,53 +202,48 @@ physical_plan
 02)│       AggregateExec       │
 03)│    --------------------   │
 04)│   aggr: sum(bigint_col)   │
-05)│                           │
-06)│         group_by:         │
-07)│ string_col@0 as string_col│

Review Comment:
   It's true that column indices provide precise tracking and tracing 
capabilities for complex query analysis, but I think tree explain should be as 
simple as possible🤔, as doc says:
   ```
       /// TreeRender, displayed in the `tree` explain type.
       ///
       /// This format is inspired by DuckDB's explain plans. The information
       /// presented should be "user friendly", and contain only the most 
relevant
       /// information for understanding a plan. It should NOT contain the same 
level
       /// of detail information as the  [`Self::Default`] format.
    ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to