onlyjackfrost commented on code in PR #15209:
URL: https://github.com/apache/datafusion/pull/15209#discussion_r2001158621
##########
datafusion/sql/src/expr/unary_op.rs:
##########
@@ -45,7 +45,18 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
{
Ok(operand)
} else {
- plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types")
+ plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types").map_err(|e| {
+ let span = operand.spans().and_then(|s| s.first());
+ let mut diagnostic = Diagnostic::new_error(
+ format!("+ cannot be used with {data_type}"),
+ span
+ );
+ if span.is_none() {
+ diagnostic.add_note("+ can only be used with
numbers, intervals, and timestamps", None);
+ diagnostic.add_help(format!("perhaps you need to
cast {operand}"), None);
+ }
Review Comment:
# from the reply above
> note (without span) = "+ can only be used with numbers, intervals, and
timestamps"
> help (without span) = "perhaps you need to cast {expression}"
oops... I might have misunderstood your reply.
I'll remove the condition from here.
##########
datafusion/sql/src/expr/unary_op.rs:
##########
@@ -45,7 +45,18 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
{
Ok(operand)
} else {
- plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types")
+ plan_err!("Unary operator '+' only supports numeric,
interval and timestamp types").map_err(|e| {
+ let span = operand.spans().and_then(|s| s.first());
+ let mut diagnostic = Diagnostic::new_error(
+ format!("+ cannot be used with {data_type}"),
+ span
+ );
+ if span.is_none() {
+ diagnostic.add_note("+ can only be used with
numbers, intervals, and timestamps", None);
+ diagnostic.add_help(format!("perhaps you need to
cast {operand}"), None);
+ }
Review Comment:
from the reply above
> note (without span) = "+ can only be used with numbers, intervals, and
timestamps"
> help (without span) = "perhaps you need to cast {expression}"
oops... I might have misunderstood your reply.
I'll remove the condition from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
