shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1960715986
##
datafusion/functions/src/datetime/date_part.rs:
##
@@ -95,24 +96,29 @@ impl DatePartFunc {
signature: Signature::one_of(
vec reported that for their [first
project(link)](https://15799.courses.cs.cmu.edu/spring2025/project1.html), they
tr
2010YOUY01 commented on code in PR #14745:
URL: https://github.com/apache/datafusion/pull/14745#discussion_r1961058668
##
.github/workflows/extended.yml:
##
@@ -39,43 +39,54 @@ jobs:
linux-build-lib:
name: linux build test
runs-on: ubuntu-latest
-container:
-
mertak-synnada commented on PR #14685:
URL: https://github.com/apache/datafusion/pull/14685#issuecomment-2667684649
Yes, I agree with the builder approach, it might be helpful for such cases.
However, I'm a bit concerned about with the explicit approach, since it might
be forgotten. It look
niebayes commented on code in PR #14699:
URL: https://github.com/apache/datafusion/pull/14699#discussion_r1961065951
##
datafusion/physical-expr/src/intervals/cp_solver.rs:
##
@@ -15,7 +15,130 @@
// specific language governing permissions and limitations
// under the License.
erchirag opened a new issue, #14768:
URL: https://github.com/apache/datafusion/issues/14768
### Discussed in https://github.com/apache/datafusion/discussions/11730
Originally posted by **erchirag** July 30, 2024
Hi
I have a parquet file with following example data
ozankabak closed issue #14577: Apache DataFusion Google Summer of Code (GSoC)
Application Guidelines
URL: https://github.com/apache/datafusion/issues/14577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zjregee commented on code in PR #14767:
URL: https://github.com/apache/datafusion/pull/14767#discussion_r1961079113
##
datafusion/common/src/dfschema.rs:
##
@@ -230,6 +230,13 @@ impl DFSchema {
return _schema_err!(SchemaError::DuplicateQualifiedField {
findepi commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2667781939
We could move logic of `PushDownLimit::rewrite` to make it inherent method
(`impl PushDownLimit` block).
This way we could recurse without threading useless `config` parameter
jatin510 commented on PR #14764:
URL: https://github.com/apache/datafusion/pull/14764#issuecomment-2667556139
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jatin510 commented on PR #14756:
URL: https://github.com/apache/datafusion/pull/14756#issuecomment-2667568452
I see that a recursion limit of 50 is introduced for SQL parsing.
Is this based on specific performance benchmarks or potential stack overflow
risks?
Also, is there any refer
codecov-commenter commented on PR #1416:
URL:
https://github.com/apache/datafusion-comet/pull/1416#issuecomment-2667576051
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1416?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
irenjj commented on issue #14761:
URL: https://github.com/apache/datafusion/issues/14761#issuecomment-2667601156
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
ozankabak commented on code in PR #14745:
URL: https://github.com/apache/datafusion/pull/14745#discussion_r1961014910
##
.github/workflows/extended.yml:
##
@@ -95,7 +106,7 @@ jobs:
- name: Run tests
run: |
cd datafusion
- cargo test --profile
ozankabak commented on code in PR #14745:
URL: https://github.com/apache/datafusion/pull/14745#discussion_r1961014910
##
.github/workflows/extended.yml:
##
@@ -95,7 +106,7 @@ jobs:
- name: Run tests
run: |
cd datafusion
- cargo test --profile
zhuqi-lucas opened a new pull request, #14766:
URL: https://github.com/apache/datafusion/pull/14766
…ory for the result batches
## Which issue does this PR close?
- Closes[ #14751](https://github.com/apache/datafusion/issues/14751)
## Rationale for this change
This
zhuqi-lucas commented on PR #14766:
URL: https://github.com/apache/datafusion/pull/14766#issuecomment-2667614609
cc @alamb @2010YOUY01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
zhuqi-lucas commented on PR #14766:
URL: https://github.com/apache/datafusion/pull/14766#issuecomment-2667624674
1. The memory usage now is accurate, it will not collect all result to
memory.
2. We now register datafusion-cli result batch to memory pool also.
The testing result for
zhuqi-lucas commented on PR #14766:
URL: https://github.com/apache/datafusion/pull/14766#issuecomment-2667636669
Before this PR, the result is double:
```rust
/usr/bin/time -l cargo run --release -- --mem-pool-type fair -m 5G --maxrows
10 -f '/Users/zhuqi/arrow-datafusion/benchmark
Chen-Yuan-Lai opened a new pull request, #14764:
URL: https://github.com/apache/datafusion/pull/14764
## Which issue does this PR close?
- Closes #14707 .
## Rationale for this change
## What changes are included in this PR?
## Are these cha
jayzhan211 opened a new issue, #14763:
URL: https://github.com/apache/datafusion/issues/14763
### Is your feature request related to a problem or challenge?
`Log` for example can be handled with `TypeSignature::Coercible` where the
desired type is float and allow source types are inte
comphead merged PR #14739:
URL: https://github.com/apache/datafusion/pull/14739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alan910127 commented on issue #14763:
URL: https://github.com/apache/datafusion/issues/14763#issuecomment-2667281094
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
codecov-commenter commented on PR #1421:
URL:
https://github.com/apache/datafusion-comet/pull/1421#issuecomment-2667378784
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1421?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
Tanger commented on issue #7308:
URL: https://github.com/apache/datafusion/issues/7308#issuecomment-2667394052
Can I take this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
friendlymatthew commented on issue #14536:
URL: https://github.com/apache/datafusion/issues/14536#issuecomment-2667388287
> @Omega359 wrote: We submit a PR to arrow-rs to attempt the casting of
dates to timestamps in the display code in arrow-cast upon receiving a format
failure.
I a
Chen-Yuan-Lai commented on issue #14762:
URL: https://github.com/apache/datafusion/issues/14762#issuecomment-2667277631
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
parthchandra commented on PR #1415:
URL:
https://github.com/apache/datafusion-comet/pull/1415#issuecomment-2667311891
@kazuyukitanimura @andygrove @huaxingao @comphead review requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
comphead opened a new pull request, #1421:
URL: https://github.com/apache/datafusion-comet/pull/1421
## Which issue does this PR close?
Related #1417.
## Rationale for this change
## What changes are included in this PR?
## How are these cha
ngli-me commented on issue #13192:
URL: https://github.com/apache/datafusion/issues/13192#issuecomment-2667317716
Hi! I'm just going through older issues, it looks like this one can be
closed as of #13260, since #13061 got merged into that one?
--
This is an automated message from the Apa
comphead merged PR #14743:
URL: https://github.com/apache/datafusion/pull/14743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #14742:
URL: https://github.com/apache/datafusion/pull/14742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
github-actions[bot] closed pull request #1561: POC to show performance
improvements of not copying token
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kazuyukitanimura commented on PR #1416:
URL:
https://github.com/apache/datafusion-comet/pull/1416#issuecomment-2667093535
wondering if we can fix in arrow/datafusion
It looks addition is working, I wonder what would be the difference between
`+` and `%`
```
checkSparkAnswerAnd
TheBuilderJR commented on issue #14757:
URL: https://github.com/apache/datafusion/issues/14757#issuecomment-2667240380
cc @alamb many of my users can't query their data because of this evolution.
any chance you can take a look to see if there's any workaround I can do for
now?
--
This is
jayzhan211 commented on PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2667238494
Close by #14440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jayzhan211 closed issue #14230: DataFusion Regression (Starting in v43): Type
Coercion for UDF Arguments (X --> String) for Specified UDFs
URL: https://github.com/apache/datafusion/issues/14230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
TheBuilderJR opened a new issue, #14757:
URL: https://github.com/apache/datafusion/issues/14757
### Describe the bug
I'd expect as I add fields to structs, I should be able to cast one into
another. You can see in the repro below this doesn't seem to be allowed:
### To Reproduc
jayzhan211 commented on issue #14230:
URL: https://github.com/apache/datafusion/issues/14230#issuecomment-2667238810
Close by #14440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1960783349
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 closed pull request #14268: Fix Type Coercion for UDF Arguments
URL: https://github.com/apache/datafusion/pull/14268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jayzhan211 merged PR #14734:
URL: https://github.com/apache/datafusion/pull/14734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on PR #14734:
URL: https://github.com/apache/datafusion/pull/14734#issuecomment-2667239582
Thanks @joroKr21 @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
comphead opened a new issue, #14758:
URL: https://github.com/apache/datafusion/issues/14758
### Is your feature request related to a problem or challenge?
PostgreSQL just landed elimination for the self joins for some queries
https://www.phoronix.com/news/PostgreSQL-Self-Join-Elimi
comphead commented on code in PR #14730:
URL: https://github.com/apache/datafusion/pull/14730#discussion_r1960781327
##
.github/dependabot.yml:
##
@@ -21,19 +21,30 @@ updates:
directory: "/"
schedule:
interval: daily
-open-pull-requests-limit: 10
target
jayzhan211 opened a new issue, #14760:
URL: https://github.com/apache/datafusion/issues/14760
### Is your feature request related to a problem or challenge?
After #14440, we can use `Coercible` for existing `Numeric` signature
### Describe the solution you'd like
_No resp
jayzhan211 opened a new issue, #14759:
URL: https://github.com/apache/datafusion/issues/14759
### Is your feature request related to a problem or challenge?
After #14440, we can use Coercible signature for existing String
```rust
TypeSignature::Coercible(v
jayzhan211 opened a new issue, #14762:
URL: https://github.com/apache/datafusion/issues/14762
### Is your feature request related to a problem or challenge?
`DigestFunc`, `Md5Func`, `SHA` family allow string and binary types as
input. We can use `TypeSignature::Coercible` for these fu
jayzhan211 opened a new issue, #14761:
URL: https://github.com/apache/datafusion/issues/14761
### Is your feature request related to a problem or challenge?
`get_example_types` is used to list possible types for a function in
information schema
Instead of DataType, NativeType i
dhegberg commented on issue #13570:
URL: https://github.com/apache/datafusion/issues/13570#issuecomment-2667446243
I was looking at how to support named parameters for PREPARE statements.
I expected the supported syntax in SQL dialects to looks something like:
```
PREPARE fun
kosiew opened a new issue, #14765:
URL: https://github.com/apache/datafusion/issues/14765
### Is your feature request related to a problem or challenge?
There is a common operation in libraries such as pyspark to fill nulls in an
entire DataFrame (or to limit by columns). It would be
ding-young commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2667701042
Hi, @findepi
I've set `used_underscore_binding=deny` and renamed each `_var` that was
actually used or passed down as fn arg to `var`. However, this gives another
clippy
zjregee opened a new pull request, #14767:
URL: https://github.com/apache/datafusion/pull/14767
## Which issue does this PR close?
- Closes #14436.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
## Are there any user-facing ch
2010YOUY01 commented on PR #14766:
URL: https://github.com/apache/datafusion/pull/14766#issuecomment-2667753322
Thank you for the help.
This change will stop execution once `maxrow` is reached. I think this is
the optimal behavior for application developers using `datafusion-cli` for
qu
andygrove opened a new issue, #1419:
URL: https://github.com/apache/datafusion-comet/issues/1419
### What is the problem the feature request solves?
The release process has some manual steps, such as updating snapshot and
release version numbers in the documentation. I would like to a
niebayes commented on code in PR #14723:
URL: https://github.com/apache/datafusion/pull/14723#discussion_r1960068258
##
datafusion/substrait/src/serializer.rs:
##
@@ -26,9 +26,30 @@ use substrait::proto::Plan;
use std::fs::OpenOptions;
use std::io::{Read, Write};
+use std::p
niebayes commented on PR #14723:
URL: https://github.com/apache/datafusion/pull/14723#issuecomment-2666178275
@alamb Applied suggestions from @mbrobbel. Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andygrove commented on PR #56:
URL: https://github.com/apache/datafusion-site/pull/56#issuecomment-2666080238
Thanks for the reviews! I plan on publishing this once
https://github.com/apache/datafusion-comet/pull/1418 is merged.
--
This is an automated message from the Apache Git Service.
andygrove opened a new pull request, #1418:
URL: https://github.com/apache/datafusion-comet/pull/1418
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
zhuqi-lucas opened a new issue, #14751:
URL: https://github.com/apache/datafusion/issues/14751
### Is your feature request related to a problem or challenge?
This is the follow-up for the discussion
https://github.com/apache/datafusion/pull/14644#issuecomment-2665614584
**P
zhuqi-lucas commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2666113013
> > > Problem
> > > I tried one query and this PR is not working as expected, I specified
one query to run under 5GB memory (select * without order requires 7GB) but
it's stil
TheBuilderJR commented on issue #13270:
URL: https://github.com/apache/datafusion/issues/13270#issuecomment-2666309651
I just created an issue for this:
https://github.com/apache/datafusion/issues/14753
--
This is an automated message from the Apache Git Service.
To respond to the message
andygrove commented on issue #1417:
URL:
https://github.com/apache/datafusion-comet/issues/1417#issuecomment-2666318484
Once this is resolved we should update the `kubernetes.md` doc to point to
the new version, as discussed in
https://github.com/apache/datafusion-comet/pull/1418
--
Thi
andygrove merged PR #1418:
URL: https://github.com/apache/datafusion-comet/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove merged PR #56:
URL: https://github.com/apache/datafusion-site/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
robtandy commented on PR #62:
URL: https://github.com/apache/datafusion-ray/pull/62#issuecomment-2666307285
Updated to squash messy commit history from source branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
andygrove commented on code in PR #62:
URL: https://github.com/apache/datafusion-ray/pull/62#discussion_r1960168520
##
requirements-in.txt:
##
@@ -7,6 +7,6 @@ numpy
pyarrow>=18.0.0
pytest
ray==2.40.0
-datafusion==43.1.0
+datafusion==43.0.0
Review Comment:
There is no 43.0
TheBuilderJR commented on issue #14753:
URL: https://github.com/apache/datafusion/issues/14753#issuecomment-2666342013
Actually this does seem to work with the latest version of datafusion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
andygrove commented on issue #1406:
URL:
https://github.com/apache/datafusion-comet/issues/1406#issuecomment-2666355667
This is fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
andygrove closed issue #1406: Remove hard-coded Comet version numbers from
GitHub actions
URL: https://github.com/apache/datafusion-comet/issues/1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on PR #1522:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1522#issuecomment-2666793579
> Hi @alamb , @iffyio ! Just wanted to report that I just received a crash
report that seems to come from here:
[sqlpage/SQLPage#814](https://github.com/sqlpage/SQLPage/iss
mbrobbel commented on code in PR #14723:
URL: https://github.com/apache/datafusion/pull/14723#discussion_r1960083499
##
datafusion/substrait/src/serializer.rs:
##
@@ -26,28 +26,50 @@ use substrait::proto::Plan;
use std::fs::OpenOptions;
use std::io::{Read, Write};
+use std::
codecov-commenter commented on PR #1418:
URL:
https://github.com/apache/datafusion-comet/pull/1418#issuecomment-2666238969
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1418?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove opened a new issue, #1420:
URL: https://github.com/apache/datafusion-comet/issues/1420
### What is the problem the feature request solves?
Tracking the next release.
Issues to resolve:
- https://github.com/apache/datafusion-comet/issues/1414
- https://github.
TheBuilderJR closed issue #14753: Datafusion can't seem to handle schema
evolution
URL: https://github.com/apache/datafusion/issues/14753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
findepi merged PR #14747:
URL: https://github.com/apache/datafusion/pull/14747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
niebayes commented on code in PR #14723:
URL: https://github.com/apache/datafusion/pull/14723#discussion_r1960056475
##
datafusion/substrait/src/serializer.rs:
##
@@ -26,9 +26,30 @@ use substrait::proto::Plan;
use std::fs::OpenOptions;
use std::io::{Read, Write};
+use std::p
berkaysynnada commented on PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#issuecomment-2666086572
I'd like to take a look at this tomorrow, please hold if it's not urgent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
andygrove commented on code in PR #1418:
URL: https://github.com/apache/datafusion-comet/pull/1418#discussion_r1959993933
##
docs/source/user-guide/kubernetes.md:
##
@@ -65,13 +65,13 @@ metadata:
spec:
type: Scala
mode: cluster
- image: ghcr.io/apache/datafusion-comet:sp
parthchandra commented on PR #1415:
URL:
https://github.com/apache/datafusion-comet/pull/1415#issuecomment-2666140365
> #1413 shouldn't really conflict with this (I mean it will from a merge
standpoint, but not from a logic standpoint). This just adds more true cases to
`cast_supported` an
wForget commented on PR #1410:
URL:
https://github.com/apache/datafusion-comet/pull/1410#issuecomment-2666254913
> > Thanks @wForget. I have no way to test this, but LGTM.
>
> @andygrove Thank you. I have verified this locally, I'll provide
screenshots later.
I have updated sc
findepi commented on PR #14747:
URL: https://github.com/apache/datafusion/pull/14747#issuecomment-2666259330
> `trybuild` is an example of a tool that creates cargo files inside target
directory.
BTW i am using `trybuild` in
https://github.com/apache/datafusion/pull/14668, so this wi
comphead commented on issue #1417:
URL:
https://github.com/apache/datafusion-comet/issues/1417#issuecomment-2666484290
it stucks for hours on
```
Downloading from central:
https://repo.maven.apache.org/maven2/org/scala-lang/scala-reflect/2.12.17/scala-reflect-2.12.17.jar
#33 40.95
robtandy commented on code in PR #62:
URL: https://github.com/apache/datafusion-ray/pull/62#discussion_r1960252067
##
requirements-in.txt:
##
@@ -7,6 +7,6 @@ numpy
pyarrow>=18.0.0
pytest
ray==2.40.0
-datafusion==43.1.0
+datafusion==43.0.0
Review Comment:
Good eye. Correc
findepi commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1959483130
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercio
2010YOUY01 opened a new issue, #14748:
URL: https://github.com/apache/datafusion/issues/14748
### Is your feature request related to a problem or challenge?
https://github.com/apache/datafusion/pull/14644 fixed an external sorting
bug. Each batch's memory overhead is estimated as `2 *
goldmedal closed issue #14702: Migrate Array Functions to `invoke_with_args`
URL: https://github.com/apache/datafusion/issues/14702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
goldmedal merged PR #14726:
URL: https://github.com/apache/datafusion/pull/14726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
1 - 100 of 231 matches
Mail list logo
