zjregee commented on code in PR #14767:
URL: https://github.com/apache/datafusion/pull/14767#discussion_r1961079113
##########
datafusion/common/src/dfschema.rs:
##########
@@ -230,6 +230,13 @@ impl DFSchema {
return _schema_err!(SchemaError::DuplicateQualifiedField {
qualifier: Box::new(qualifier.clone()),
name: field.name().to_string(),
+ })
+ .map_err(|err| {
+ let diagnostic = Diagnostic::new_error(
+ format!("duplicate qualified field name '{}'",
field.name()),
+ None,
Review Comment:
Hi, @eliaperantoni, I have some doubts in the implementation process and
hope to get some help.
When constructing `Diagnostic` error, how should I get the location where
the error occurred, that is, how to construct `Span` here? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
