wugeer opened a new issue, #1631:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1631
the example from
https://github.com/apache/datafusion-sqlparser-rs/blob/fe360208900a287872fc9875e9e6cb7d3a662302/src/ast/visitor.rs#L183
ant run result is follow
```
carg
wugeer commented on issue #1631:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1631#issuecomment-2566954540
my fault, while in Cargo.toml use this, thing go well.
```
sqlparser = { version = "0.53", features = ["visitor"] }
```
--
This is an automated message
wugeer closed issue #1631: trait Visitor example not working
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rluvaton commented on PR #13520:
URL: https://github.com/apache/datafusion/pull/13520#issuecomment-2566958210
I'm gonna keep this configuration for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1900394650
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -233,6 +233,10 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
// These methods have default i
alamb commented on PR #13953:
URL: https://github.com/apache/datafusion/pull/13953#issuecomment-2567004393
Thanks @aweltsch -- this looks quite nice. I am running the benchmarks on
my test rig to verify
--
This is an automated message from the Apache Git Service.
To respond to th
alamb commented on code in PR #13964:
URL: https://github.com/apache/datafusion/pull/13964#discussion_r1900397664
##
datafusion-cli/Cargo.lock:
##
@@ -2395,12 +2395,12 @@ dependencies = [
[[package]]
name = "indexmap"
-version = "2.7.0"
+version = "2.5.0"
Review Comment:
alamb commented on code in PR #13966:
URL: https://github.com/apache/datafusion/pull/13966#discussion_r1900398739
##
datafusion/functions-nested/src/set_ops.rs:
##
@@ -516,11 +516,18 @@ fn general_array_distinct(
let mut new_arrays = Vec::with_capacity(array.len());
le
Omega359 commented on issue #13969:
URL: https://github.com/apache/datafusion/issues/13969#issuecomment-2567117480
Wow, that is crazy. I had no idea it could do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Omega359 opened a new pull request, #13971:
URL: https://github.com/apache/datafusion/pull/13971
## Which issue does this PR close?
Closes #13948
## Rationale for this change
Code cleanup.
## What changes are included in this PR?
Code.
## Are
Omega359 commented on issue #13970:
URL: https://github.com/apache/datafusion/issues/13970#issuecomment-2567119971
congrats @jonahgao for becoming a committer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alamb commented on issue #13969:
URL: https://github.com/apache/datafusion/issues/13969#issuecomment-2567034085
I was just playing around with this on github codespaces -- it is mind
blowing that the full IDE /testing can be done in the browser too (basically
for free):
![Screenshot
jonahgao commented on PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#issuecomment-2567033853
> Thanks again @Omega359 and @jonahgao -- and happy new year!
>
Happy new year!
--
This is an automated message from the Apache Git Service.
To respond to the messag
viirya commented on code in PR #1209:
URL: https://github.com/apache/datafusion-comet/pull/1209#discussion_r1900464627
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -788,68 +788,82 @@ class CometSparkSessionExtensions
}
/
github-actions[bot] commented on PR #1482:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1482#issuecomment-2567223530
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or
alamb closed issue #13760: Dec 13, 2024: This week(s) in DataFusion
URL: https://github.com/apache/datafusion/issues/13760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
alamb commented on issue #13760:
URL: https://github.com/apache/datafusion/issues/13760#issuecomment-2567088248
Next week: https://github.com/apache/datafusion/issues/13970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kylebarron commented on issue #957:
URL:
https://github.com/apache/datafusion-python/issues/957#issuecomment-2567091912
The core underlying bug was fixed
https://github.com/apache/datafusion/issues/11770#event-15793733204
--
This is an automated message from the Apache Git Service.
To re
alamb commented on code in PR #13954:
URL: https://github.com/apache/datafusion/pull/13954#discussion_r1900437566
##
datafusion/common/src/config.rs:
##
@@ -901,6 +941,8 @@ pub trait ConfigExtension: ExtensionOptions {
}
/// An object-safe API for storing arbitrary configura
2010YOUY01 opened a new issue, #13976:
URL: https://github.com/apache/datafusion/issues/13976
### Describe the bug
Run in datafusion-cli compiled from main (commit 259443d66)
```
> select 1 where null between null and 2;
type_coercion
caused by
Error during planning: Can
2010YOUY01 commented on issue #13811:
URL: https://github.com/apache/datafusion/issues/13811#issuecomment-2567282981
> A quick grep and cleaning of DF errors that resulted in a query being
marked as 'skipif Datafusion':
>
> ```
> uniq -c errors_sorted.txt
> 5 # Datafusion
2010YOUY01 commented on code in PR #13953:
URL: https://github.com/apache/datafusion/pull/13953#discussion_r1900547926
##
datafusion/physical-expr/src/expressions/case.rs:
##
@@ -394,6 +401,43 @@ impl CaseExpr {
Ok(ColumnarValue::Array(zip(&when_value, &then_value, &e
jonahgao merged PR #13954:
URL: https://github.com/apache/datafusion/pull/13954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
byte-sourcerer opened a new pull request, #1633:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1633
Support [`INSERT INTO [TABLE]
FUNCTION`](https://clickhouse.com/docs/en/sql-reference/statements/insert-into#inserting-using-a-table-function)
of Clickhouse.
--
This is an au
jonahgao commented on code in PR #13965:
URL: https://github.com/apache/datafusion/pull/13965#discussion_r1900511366
##
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##
@@ -1208,7 +1208,7 @@ fn ensure_distribution(
// We store the updated children in `new_
jonahgao commented on code in PR #13965:
URL: https://github.com/apache/datafusion/pull/13965#discussion_r1900511366
##
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##
@@ -1208,7 +1208,7 @@ fn ensure_distribution(
// We store the updated children in `new_
jonahgao commented on PR #13954:
URL: https://github.com/apache/datafusion/pull/13954#issuecomment-2567253518
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jonahgao commented on code in PR #13965:
URL: https://github.com/apache/datafusion/pull/13965#discussion_r1900511366
##
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##
@@ -1208,7 +1208,7 @@ fn ensure_distribution(
// We store the updated children in `new_
alamb closed issue #13812: Complete / integrate sqlite sqllogictest test
scripts integrattion
URL: https://github.com/apache/datafusion/issues/13812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb merged PR #13936:
URL: https://github.com/apache/datafusion/pull/13936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #13866:
URL: https://github.com/apache/datafusion/pull/13866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11770: Arrow schema is missing from the parquet metadata,
for files written by ParquetSink.
URL: https://github.com/apache/datafusion/issues/11770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
alamb opened a new issue, #13967:
URL: https://github.com/apache/datafusion/issues/13967
### Is your feature request related to a problem or challenge?
- @Omega359 added the ability to run the sqlite sqlogictests suite against
DataFusion in ❤️ https://github.com/apache/datafusion/p
alamb commented on PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#issuecomment-256686
Thanks again @Omega359 and @jonahgao -- and happy new year!
- I filed https://github.com/apache/datafusion/issues/13967 to track
enabling this feature by default
--
This is an
getChan commented on code in PR #13966:
URL: https://github.com/apache/datafusion/pull/13966#discussion_r1900393942
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -5674,6 +5674,13 @@ select array_distinct([sum(a)]) from t1 where a > 100
group by b;
statement ok
drop t
alamb commented on PR #13866:
URL: https://github.com/apache/datafusion/pull/13866#issuecomment-2567001233
Thanks again @wiedld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on issue #13845:
URL: https://github.com/apache/datafusion/issues/13845#issuecomment-2567001031
BTW I think we may get our first experience with tests that don't run on PRs
as part of
- https://github.com/apache/datafusion/issues/13967
What I envision doing is runni
andygrove opened a new pull request, #1209:
URL: https://github.com/apache/datafusion-comet/pull/1209
## Which issue does this PR close?
Closes https://github.com/apache/datafusion-comet/issues/1208
## Rationale for this change
## What changes are included
codecov-commenter commented on PR #1207:
URL:
https://github.com/apache/datafusion-comet/pull/1207#issuecomment-2567103416
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1207?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on code in PR #1209:
URL: https://github.com/apache/datafusion-comet/pull/1209#discussion_r1900473667
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -788,68 +788,82 @@ class CometSparkSessionExtensions
}
Kimahriman commented on PR #1163:
URL:
https://github.com/apache/datafusion-comet/pull/1163#issuecomment-2567202463
I lost the battle in https://github.com/apache/datafusion/pull/13683 trying
to update the null semantics to match Spark's, so the only way to exactly match
Spark will be to i
jonahgao commented on code in PR #13954:
URL: https://github.com/apache/datafusion/pull/13954#discussion_r1900421074
##
datafusion/common/src/config.rs:
##
@@ -901,6 +941,8 @@ pub trait ConfigExtension: ExtensionOptions {
}
/// An object-safe API for storing arbitrary config
rluvaton opened a new pull request, #13966:
URL: https://github.com/apache/datafusion/pull/13966
## Which issue does this PR close?
Closes #13961
## What changes are included in this PR?
Just add the last offset in case of null, and migrated the input list nulls
to the o
andygrove opened a new pull request, #1207:
URL: https://github.com/apache/datafusion-comet/pull/1207
## Which issue does this PR close?
N/A
## Rationale for this change
I found the `shuffle.mode` configuration a little confusing and thought it
would be s
alamb opened a new issue, #13970:
URL: https://github.com/apache/datafusion/issues/13970
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
dependabot[bot] opened a new pull request, #13964:
URL: https://github.com/apache/datafusion/pull/13964
Updates the requirements on [petgraph](https://github.com/petgraph/petgraph)
to permit the latest version.
Changelog
Sourced from https://github.com/petgraph/petgraph/blob/master
dependabot[bot] opened a new pull request, #13965:
URL: https://github.com/apache/datafusion/pull/13965
Updates the requirements on
[itertools](https://github.com/rust-itertools/itertools) to permit the latest
version.
Changelog
Sourced from https://github.com/rust-itertools/itert
alamb commented on code in PR #13520:
URL: https://github.com/apache/datafusion/pull/13520#discussion_r1900407524
##
.devcontainer/Dockerfile:
##
@@ -0,0 +1,13 @@
+FROM rust:bookworm
Review Comment:
I think we should document that this exists / how to use dev containers in
jayzhan211 opened a new issue, #13968:
URL: https://github.com/apache/datafusion/issues/13968
### Is your feature request related to a problem or challenge?
Both these 2 exec run `MemoryStream`. The difference is that we evaluate the
batch for `ValuesExec`. Given there similarity I th
alamb commented on PR #13520:
URL: https://github.com/apache/datafusion/pull/13520#issuecomment-2567028647
Sorry about the delay in reviewing and merging this PR -- I didn't
personally review it as I am not familiar with dev containers and it wasn't
clear to me what usecase this was solving
alamb merged PR #13520:
URL: https://github.com/apache/datafusion/pull/13520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #13520:
URL: https://github.com/apache/datafusion/pull/13520#issuecomment-2567029263
Filed https://github.com/apache/datafusion/issues/13969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb opened a new issue, #13969:
URL: https://github.com/apache/datafusion/issues/13969
I think we should document that this exists / how to use dev
containers in the documentation. Perhaps at
https://datafusion.apache.org/contributor-guide/getting_started.html#gettin
Omega359 commented on issue #13969:
URL: https://github.com/apache/datafusion/issues/13969#issuecomment-2567030325
Might want to use my personal one as a template -
https://github.com/Omega359/arrow-datafusion/blob/feature/devcontainer/.devcontainer/README.md
--
This is an automated messa
yoavcloud opened a new pull request, #1632:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1632
Attempts at solving issue #1607
Snowflake is not very strict with using SQL keywords as select list item
aliases. Added support for the dialect to control if a word is parsed
Omega359 commented on issue #13967:
URL: https://github.com/apache/datafusion/issues/13967#issuecomment-2567127786
Right now the tests will fail all the time so I'm not sure this is a good
idea until we either fix all the failures or mark them as `skipif Datafusion`
with an associated issue
Omega359 commented on issue #13967:
URL: https://github.com/apache/datafusion/issues/13967#issuecomment-2567130015
Filed https://github.com/apache/datafusion/issues/13972 for resolving sqlite
test failures.
--
This is an automated message from the Apache Git Service.
To respond to the mes
Omega359 opened a new issue, #13972:
URL: https://github.com/apache/datafusion/issues/13972
### Is your feature request related to a problem or challenge?
Now that the sqlite test have been merged (#13936) the remaining failures in
the tests must be looked at manually and either:
-
Omega359 opened a new pull request, #13973:
URL: https://github.com/apache/datafusion/pull/13973
## Which issue does this PR close?
part of #13845
## Rationale for this change
The hash collisions job is expensive (just as expensive as the cargo docs
tests which
andygrove commented on code in PR #1163:
URL: https://github.com/apache/datafusion-comet/pull/1163#discussion_r1900457315
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2390,4 +2390,14 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
Omega359 opened a new pull request, #13974:
URL: https://github.com/apache/datafusion/pull/13974
## Which issue does this PR close?
Closes #.
## Rationale for this change
Adding blog post to doc.
## What changes are included in this PR?
Link to DF python 43.
Omega359 commented on issue #13972:
URL: https://github.com/apache/datafusion/issues/13972#issuecomment-2567139070
Epic this ticket is under: https://github.com/apache/datafusion/issues/13811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
iffyio merged PR #1627:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio commented on code in PR #1616:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1616#discussion_r1900459492
##
src/parser/mod.rs:
##
@@ -1044,6 +1046,24 @@ impl<'a> Parser<'a> {
Ok(Statement::NOTIFY { channel, payload })
}
+/// Parses a `RE
iffyio merged PR #1616:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2567147992
@Groennbeck DataFusion 44.0.0 is now released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
66 matches
Mail list logo
