andygrove opened a new pull request, #1207:
URL: https://github.com/apache/datafusion-comet/pull/1207
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
I found the `shuffle.mode` configuration a little confusing and thought it
would be simpler to have boolean configs for enabling/disabling native shuffle
and columnar shuffle. Also, the documentation did not explain how columnar
shuffle worked (and I only recently learned how it works).
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Added new `shuffle.native.enabled` and `shuffle.columnar.enabled` configs
(both default to `true`)
- Renamed `shuffle.mode` config to `shuffle.mode.deprecated` (it is still
used in many tests so I did not want to remove it completely in this PR)
- Added more detail in tuning guide about the native and columnar shuffle
implementations
- Updated benchmark suites to use the new configs
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
