alamb commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1900394650
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -233,6 +233,10 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
// These methods have default implementations calling the common handler
code, to allow for users
// to re-use common handling logic.
+ async fn consume_rel(&self, rel: &Rel) -> Result<LogicalPlan> {
Review Comment:
I recommend documenting such methods with `///` style comments that show up
in the API docs https://docs.rs/crate/datafusion-substrait/latest
- Of course the API docs seem to be broken now ðŸ˜
https://github.com/apache/datafusion/issues/13853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
