Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-19 Thread via GitHub
wForget commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r2004874404 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2734,4 +2734,28 @@ class CometExpressionSuite extends CometTestBase with AdaptiveS

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-13 Thread via GitHub
andygrove merged PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-13 Thread via GitHub
andygrove commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1993653354 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2734,4 +2734,28 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-13 Thread via GitHub
andygrove commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1993616092 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2734,4 +2734,28 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-12 Thread via GitHub
wForget commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1992592521 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -655,8 +655,23 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde wit

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-12 Thread via GitHub
wForget commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1992622784 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -655,8 +655,23 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde wit

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-12 Thread via GitHub
kazuyukitanimura commented on code in PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1991925624 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -655,8 +655,23 @@ object QueryPlanSerde extends Logging with ShimQueryPlan

Re: [PR] fix: check overflow for decimal integral division [datafusion-comet]

2025-03-12 Thread via GitHub
codecov-commenter commented on PR #1512: URL: https://github.com/apache/datafusion-comet/pull/1512#issuecomment-2717305481 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1512?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca