wForget commented on code in PR #1512:
URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r2004874404
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2734,4 +2734,28 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("test integral divide overflow for decimal") {
+ // decimal support requires Spark 3.4 or later
+ assume(isSpark34Plus)
+ if (isSpark40Plus) {
+ Seq(true, false)
+ } else
+ {
+ // ansi mode only supported in Spark 4.0+
+ Seq(false)
+ }.foreach { ansiMode =>
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> ansiMode.toString) {
Review Comment:
In spark 4, `spark.comet.ansi.enabled` defaults to `true`:
https://github.com/apache/datafusion-comet/blob/382ac938f2d10666eefc08ec5c1c82025ddf3726/common/src/main/scala/org/apache/comet/CometConf.scala#L578-L585
https://github.com/apache/datafusion-comet/blob/382ac938f2d10666eefc08ec5c1c82025ddf3726/common/src/main/spark-4.0/org/apache/comet/shims/ShimCometConf.scala#L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
