wForget commented on code in PR #1512:
URL: https://github.com/apache/datafusion-comet/pull/1512#discussion_r1992622784
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -655,8 +655,23 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
(builder, mathExpr) => builder.setIntegralDivide(mathExpr))
if (divideExpr.isDefined) {
+ val childExpr = if (dataType.isInstanceOf[DecimalType]) {
+ // check overflow for decimal type
+ val builder = ExprOuterClass.CheckOverflow.newBuilder()
+ builder.setChild(divideExpr.get)
+ builder.setFailOnError(false)
Review Comment:
> Is it always `false` even for ANSI mode?
Sorry, I mistakenly thought that comet does not support ansi mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
