andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1912546988
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1912521481
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove merged PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1909509839
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1909508060
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1909503394
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
jatin510 commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1909287084
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2529,4 +2529,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
jatin510 commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1905885168
##
native/core/src/execution/planner.rs:
##
@@ -735,6 +736,36 @@ impl PhysicalPlanner {
));
Ok(array_has_expr)
andygrove commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1905845993
##
native/core/src/execution/planner.rs:
##
@@ -735,6 +736,36 @@ impl PhysicalPlanner {
));
Ok(array_has_expr)
jatin510 commented on PR #1179:
URL:
https://github.com/apache/datafusion-comet/pull/1179#issuecomment-2575891718
> There seems to be a difference in null handling between DataFusion and
Spark that is causing the tests to fail.
>
> This test passes:
>
> ```scala
> checkSpar
parthchandra commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1902256464
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2517,4 +2517,16 @@ class CometExpressionSuite extends CometTestBase with
Adap
dharanad commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1901263745
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2517,4 +2517,16 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
dharanad commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1901261435
##
native/core/src/execution/planner.rs:
##
@@ -719,6 +720,24 @@ impl PhysicalPlanner {
expr.legacy_negative_index,
)))
andygrove commented on PR #1179:
URL:
https://github.com/apache/datafusion-comet/pull/1179#issuecomment-2568189397
There seems to be a difference in null handling between DataFusion and Spark
that is causing the tests to fail.
This test passes:
```scala
checkSparkAnswerAndO
andygrove commented on PR #1179:
URL:
https://github.com/apache/datafusion-comet/pull/1179#issuecomment-2567836734
Thanks @jatin510. I will review this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
jatin510 commented on PR #1179:
URL:
https://github.com/apache/datafusion-comet/pull/1179#issuecomment-2564300648
@andygrove PR is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
16 matches
Mail list logo
