jatin510 commented on code in PR #1179:
URL: https://github.com/apache/datafusion-comet/pull/1179#discussion_r1905885168
##########
native/core/src/execution/planner.rs:
##########
@@ -735,6 +736,36 @@ impl PhysicalPlanner {
));
Ok(array_has_expr)
}
+ ExprStruct::ArrayRemove(expr) => {
+ let src_array_expr =
+ self.create_expr(expr.left.as_ref().unwrap(),
Arc::clone(&input_schema))?;
+ let key_expr =
+ self.create_expr(expr.right.as_ref().unwrap(),
Arc::clone(&input_schema))?;
+ let args = vec![Arc::clone(&src_array_expr),
Arc::clone(&key_expr)];
+ let return_type = src_array_expr.data_type(&input_schema)?;
+
+ let datafusion_array_remove = array_remove_all_udf();
+
+ let array_remove_expr: Arc<dyn PhysicalExpr> =
Arc::new(ScalarFunctionExpr::new(
+ "array_remove",
+ datafusion_array_remove,
+ args,
+ return_type,
+ ));
+ let is_null_expr: Arc<dyn PhysicalExpr> =
Arc::new(IsNullExpr::new(key_expr));
+
+ let null_literal_expr: Arc<dyn PhysicalExpr> =
+ Arc::new(Literal::new(ScalarValue::Null));
+
+ let case_expr = CaseExpr::try_new(
+ None,
+ vec![(is_null_expr, null_literal_expr)],
+ Some(array_remove_expr),
+ )?;
+
+ Ok(Arc::new(case_expr))
+ // Ok(array_remove_expr)
Review Comment:
fixed ! 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
