Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2001956804 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004365325 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003780906 ## spark/src/main/scala/org/apache/spark/Plugins.scala: ## @@ -63,13 +63,10 @@ class CometDriverPlugin extends DriverPlugin with Logging with ShimCometDrive

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003562001 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -274,11 +272,9 @@ object CometConf extends ShimCometConf { .createWithDefault(true)

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003622238 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -274,11 +272,9 @@ object CometConf extends ShimCometConf { .createWithDefault(true)

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004547775 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004351049 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at ru

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#issuecomment-2738389145 > I think we can merge this and follow up if necessary. Thank you @andygrove Thanks @kazuyukitanimura. I filed https://github.com/apache/datafusion-comet/issues/1560 for

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove merged PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003621791 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at runtime b

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004349874 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003529179 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004367835 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004606195 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

viirya commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004600150 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guide +

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004340727 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuni

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004398420 ## spark/src/main/scala/org/apache/comet/CometExecIterator.scala: ## @@ -75,12 +75,11 @@ class CometExecIterator( metricsUpdateInterval = COMET_METRIC

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004402356 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004391121 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at runtime b

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004365325 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#issuecomment-2737470965 @kazuyukitanimura I've addressed feedback, Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003625799 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at runtime b

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003626404 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at runtime b

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003541798 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003529179 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003524352 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2002490500 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuni

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2002493113 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuni

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2002493113 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuni

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2002475656 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -274,11 +272,9 @@ object CometConf extends ShimCometConf { .createWithDefault(

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

parthchandra commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2002219014 ## docs/source/user-guide/tuning.md: ## @@ -141,30 +191,22 @@ It must be set before the Spark context is created. You can enable or disable Co at runtim

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r1996138171 ## docs/source/user-guide/tuning.md: ## @@ -23,12 +23,84 @@ Comet provides some tuning options to help you get the best performance from you ## Memory Tu

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r1996139134 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

kazuyukitanimura commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r1996191336 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,96 @@ specific language governing permissions and limitations under the License. --> -# Tuni

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r1995645694 ## docs/source/user-guide/tuning.md: ## @@ -143,28 +182,20 @@ Once it is disabled, Comet will fall back to the default Spark shuffle manager. ### Shuffle

Re: [PR] docs: various improvements to tuning guide [datafusion-comet]

andygrove commented on code in PR #1525: URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r1995643547 ## docs/source/user-guide/tuning.md: ## @@ -17,18 +17,94 @@ specific language governing permissions and limitations under the License. --> -# Tuning Guid