andygrove commented on code in PR #1525:
URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2003562001
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -274,11 +272,9 @@ object CometConf extends ShimCometConf {
.createWithDefault(true)
val COMET_SHUFFLE_MODE: ConfigEntry[String] =
conf(s"$COMET_EXEC_CONFIG_PREFIX.shuffle.mode")
- .doc("The mode of Comet shuffle. This config is only effective if Comet
shuffle " +
- "is enabled. Available modes are 'native', 'jvm', and 'auto'. " +
- "'native' is for native shuffle which has best performance in general. "
+
- "'jvm' is for jvm-based columnar shuffle which has higher coverage than
native shuffle. " +
- "'auto' is for Comet to choose the best shuffle mode based on the query
plan.")
+ .doc(
+ "This is test config to allow tests to force a particular shuffle
implementation to be " +
+ "used.")
Review Comment:
This is an internal config so we don't generate any documentation for this.
I will update the description to explain the modes again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
