andygrove commented on code in PR #1525:
URL: https://github.com/apache/datafusion-comet/pull/1525#discussion_r2004398420
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -75,12 +75,11 @@ class CometExecIterator(
metricsUpdateInterval = COMET_METRICS_UPDATE_INTERVAL.get(),
new CometTaskMemoryManager(id),
batchSize = COMET_BATCH_SIZE.get(),
- use_unified_memory_manager =
- CometSparkSessionExtensions.cometUnifiedMemoryManagerEnabled(conf),
- memory_pool_type = COMET_EXEC_MEMORY_POOL_TYPE.get(),
- memory_limit = CometSparkSessionExtensions.getCometMemoryOverhead(conf),
- memory_limit_per_task = getMemoryLimitPerTask(conf),
- task_attempt_id = TaskContext.get().taskAttemptId,
+ offHeapMode = CometSparkSessionExtensions.isOffHeapEnabled(conf),
+ memoryPoolType = COMET_EXEC_MEMORY_POOL_TYPE.get(),
+ memoryLimit = CometSparkSessionExtensions.getCometMemoryOverhead(conf),
+ memoryLimitPerTask = getMemoryLimitPerTask(conf),
+ taskAttemptId = TaskContext.get().taskAttemptId,
Review Comment:
Drive-by cleanup to use camel case not snake case. Also renamed
`use_unified_memory_manager` to `offHeapMode` because we are no longer using
this to indicate when to use unified memory management. That is now decided in
native code based on `offHeapMode` and `memoryPoolType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
