cht42 commented on PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#issuecomment-2808714948
@alamb can we get this merged please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
delamarch3 commented on PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#issuecomment-2798766441
Thanks for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
cht42 commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r2039629359
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -146,14 +145,61 @@ pub fn flatten_inner(args: &[ArrayRef]) ->
Result {
match array.data_type() {
cht42 commented on PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#issuecomment-2788931522
Maybe @alamb or @Weijun-H can review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
delamarch3 commented on PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#issuecomment-2772680844
Hi @cht42, I'm just waiting for another review.
@findepi could you take another look at this when you get the chance please?
--
This is an automated message from the Apach
cht42 commented on PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#issuecomment-2771431572
Hey @delamarch3 are you still tracking merging this ? interested in this new
behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
delamarch3 commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1993460956
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -77,7 +77,6 @@ impl Flatten {
pub fn new() -> Self {
Self {
signature: Signature
delamarch3 commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1991645243
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -102,25 +101,21 @@ impl ScalarUDFImpl for Flatten {
}
fn return_type(&self, arg_types: &[DataTy
findepi commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1991800980
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -77,7 +77,6 @@ impl Flatten {
pub fn new() -> Self {
Self {
signature: Signature {
Weijun-H commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1990574608
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -102,25 +101,21 @@ impl ScalarUDFImpl for Flatten {
}
fn return_type(&self, arg_types: &[DataType
Weijun-H commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1990574608
##
datafusion/functions-nested/src/flatten.rs:
##
@@ -102,25 +101,21 @@ impl ScalarUDFImpl for Flatten {
}
fn return_type(&self, arg_types: &[DataType
11 matches
Mail list logo
