delamarch3 commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1993460956
##########
datafusion/functions-nested/src/flatten.rs:
##########
@@ -77,7 +77,6 @@ impl Flatten {
pub fn new() -> Self {
Self {
signature: Signature {
- // TODO (https://github.com/apache/datafusion/issues/13757)
flatten should be single-step, not recursive
type_signature: TypeSignature::ArraySignature(
ArrayFunctionSignature::RecursiveArray,
Review Comment:
What would the deprecated note be since, from what I understand, this was
added in specifically for `flatten` to recursively coerce `FixedLengthList` to
`List`. I'm wondering if any users would rely on that downstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
