delamarch3 commented on code in PR #15160:
URL: https://github.com/apache/datafusion/pull/15160#discussion_r1991645243
##########
datafusion/functions-nested/src/flatten.rs:
##########
@@ -102,25 +101,21 @@ impl ScalarUDFImpl for Flatten {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- fn get_base_type(data_type: &DataType) -> Result<DataType> {
- match data_type {
- List(field) | FixedSizeList(field, _)
- if matches!(field.data_type(), List(_) | FixedSizeList(_,
_)) =>
- {
- get_base_type(field.data_type())
- }
- LargeList(field) if matches!(field.data_type(), LargeList(_))
=> {
- get_base_type(field.data_type())
- }
- Null | List(_) | LargeList(_) => Ok(data_type.to_owned()),
- FixedSizeList(field, _) => Ok(List(Arc::clone(field))),
- _ => exec_err!(
- "Not reachable, data_type should be List, LargeList or
FixedSizeList"
- ),
- }
- }
+ let data_type = match &arg_types[0] {
+ List(field) | FixedSizeList(field, _) => match field.data_type() {
+ List(field) | FixedSizeList(field, _) =>
List(Arc::clone(field)),
+ _ => arg_types[0].clone(),
+ },
+ LargeList(field) => match field.data_type() {
+ LargeList(field) => LargeList(Arc::clone(field)),
Review Comment:
Ah ok, I'll need to make some changes to support this. Currently trying to
flatten `LargeList(List)` will fail when casting the inner list to generic list
with i64 offset (using the type parameter `O`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
