alamb commented on PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2560323839
Here is a PR to try and fix this:
https://github.com/apache/datafusion/pull/13887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
alamb commented on PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2559808094
While testing this in comet, I am pretty sure this PR didn't quite fix the
problem
-
https://github.com/apache/datafusion-comet/pull/1154#issuecomment-2559777474
When someone
alamb commented on PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2558448612
Thanks again @buraksenn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb merged PR #13778:
URL: https://github.com/apache/datafusion/pull/13778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2555605957
> > I wonder if there is some way to test this (aka add a CI test that will
fail with recursive protection -- perhaps the WASM compile test 🤔 ) that
doesn't fail when the feature is di
findepi commented on PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2553069476
> I wonder if there is some way to test this (aka add a CI test that will
fail with recursive protection -- perhaps the WASM compile test 🤔 ) that
doesn't fail when the feature is di
buraksenn commented on code in PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#discussion_r1890845060
##
datafusion/common/Cargo.toml:
##
@@ -36,10 +36,12 @@ name = "datafusion_common"
path = "src/lib.rs"
[features]
+default = ["recursive-protection"]
avro =
buraksenn commented on code in PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#discussion_r1890844666
##
datafusion/common/Cargo.toml:
##
@@ -61,7 +63,7 @@ object_store = { workspace = true, optional = true }
parquet = { workspace = true, optional = true, defaul
buraksenn commented on code in PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#discussion_r1890844411
##
Cargo.toml:
##
@@ -143,7 +143,6 @@ pbjson = { version = "0.7.0" }
prost = "0.13.1"
prost-derive = "0.13.1"
rand = "0.8"
-recursive = "0.1.1"
Review Commen
buraksenn commented on code in PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#discussion_r1890842086
##
datafusion/optimizer/src/eliminate_cross_join.rs:
##
@@ -1293,10 +1292,10 @@ mod tests {
.build()?;
let expected = vec