alamb commented on PR #13778: URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2555605957
> > I wonder if there is some way to test this (aka add a CI test that will fail with recursive protection -- perhaps the WASM compile test 🤔 ) that doesn't fail when the feature is disabled? > > @alamb would you want to see this in this PR, or in a follow-up? Yes sorry I should have been more explicit. I think this PR should have a test (maybe even manually at first?) to both 1. ensure that this change actually does allow the relevant subcrates to be compiled without `#recursive` 2. ensure we don't break the feature in the future (for example breaking code into new crates but not bringing the `#cfg` flags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
