alamb commented on PR #13778: URL: https://github.com/apache/datafusion/pull/13778#issuecomment-2559808094
While testing this in comet, I am pretty sure this PR didn't quite fix the problem - https://github.com/apache/datafusion-comet/pull/1154#issuecomment-2559777474 When someone includes one of these crates transitively (e.g. by using `datafusion` the feature is activated by default -- you can't turn off default features. Thus, when you add datafusion as the dependency, it doesn't have the 'recursive-protect' feature so there is no way to turn the feature off in subcrates. I think we need to turn the feature off by default in subcrates and then control enabling/disabling at the main crate level. I will have a PR for this shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
