Re: [PR] wip remove future overhead when tracing is off. [datafusion]

2025-05-21 Thread via GitHub
ashdnazg closed pull request #15679: wip remove future overhead when tracing is off. URL: https://github.com/apache/datafusion/pull/15679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] wip remove future overhead when tracing is off. [datafusion]

2025-04-11 Thread via GitHub
geoffreyclaude commented on PR #15679: URL: https://github.com/apache/datafusion/pull/15679#issuecomment-2796074074 > I admit I haven't benchmarked yet. > It's more out of principle, which admittedly isn't the best reason :laughing: > > The way I see it, even if now that's not a s

Re: [PR] wip remove future overhead when tracing is off. [datafusion]

2025-04-10 Thread via GitHub
ashdnazg commented on PR #15679: URL: https://github.com/apache/datafusion/pull/15679#issuecomment-2795214445 I admit I haven't benchmarked yet. It's more out of principle, which admittedly isn't the best reason :laughing: The way I see it, even if now that's not a significant ove

Re: [PR] wip remove future overhead when tracing is off. [datafusion]

2025-04-10 Thread via GitHub
geoffreyclaude commented on PR #15679: URL: https://github.com/apache/datafusion/pull/15679#issuecomment-2795158902 @ashdnazg: I didn't go too much into detail yet, but the overall idea looks pretty sensible! Although it does seem to add complexity to some already non-obvious code. D

[PR] wip remove future overhead when tracing is off. [datafusion]

2025-04-10 Thread via GitHub
ashdnazg opened a new pull request, #15679: URL: https://github.com/apache/datafusion/pull/15679 ## Which issue does this PR close? - Closes #. ## Rationale for this change ## What changes are included in this PR? ## Are these changes tested