geoffreyclaude commented on PR #15679: URL: https://github.com/apache/datafusion/pull/15679#issuecomment-2796074074
> I admit I haven't benchmarked yet. > It's more out of principle, which admittedly isn't the best reason :laughing: > > The way I see it, even if now that's not a significant overhead, now - as you also said - is the time to change stuff, as later it will be harder. If in the future (pun unintended) it'll be an issue, it won't be fun. > > On that notion - do `trace_future` and `trace_block` need to be public? > If I understand correctly, it's enough to use them in `SpawnedTask` and `JoinSet` and the tests don't use them either. They're only public within the crate: the `trace_utils` mod is not exposed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
