geoffreyclaude commented on PR #15679: URL: https://github.com/apache/datafusion/pull/15679#issuecomment-2795158902
@ashdnazg: I didn't go too much into detail yet, but the overall idea looks pretty sensible! Although it does seem to add complexity to some already non-obvious code. Did you measure the overhead of the boxing though? I was expecting/hoping it to be negligible compared to the cost of the actual tasks. I'm also not particularly attached to the current implementation, so if you find a way to simplify the interface as well as remove the wrapping when tracing is off, go for it! Since it hasn't yet been integrated in a release, the interface is completely open to change. Just as long as the `tracing.rs` (both the test and the example files) run with the expected results. Otherwise I think it's a balance to find between code complexity and performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
