Re: [PR] refactor!: consistent null handling in coercible signatures [datafusion]

2025-06-23 Thread via GitHub
github-actions[bot] closed pull request #15404: refactor!: consistent null handling in coercible signatures URL: https://github.com/apache/datafusion/pull/15404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] refactor!: consistent null handling in coercible signatures [datafusion]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #15404: URL: https://github.com/apache/datafusion/pull/15404#issuecomment-2978700123 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] refactor!: consistent null handling in coercible signatures [datafusion]

2025-04-16 Thread via GitHub
alamb commented on PR #15404: URL: https://github.com/apache/datafusion/pull/15404#issuecomment-2810861213 Thanks @alan910127 -- I'll check it out in a few days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] refactor!: consistent null handling in coercible signatures [datafusion]

2025-04-14 Thread via GitHub
alan910127 commented on PR #15404: URL: https://github.com/apache/datafusion/pull/15404#issuecomment-2802335458 Hi @alamb, I’ve updated `upgrading.md`. Since this is my first PR with an API change, I’m not 100% sure I did everything right. Would appreciate it if you could take a look and le

Re: [PR] refactor: consistent null handling in coercible signatures [datafusion]

2025-04-07 Thread via GitHub
alan910127 commented on code in PR #15404: URL: https://github.com/apache/datafusion/pull/15404#discussion_r2031381771 ## datafusion/expr-common/src/signature.rs: ## @@ -263,10 +263,6 @@ impl TypeSignatureClass { self: &TypeSignatureClass, logical_type: &Native

Re: [PR] refactor: consistent null handling in coercible signatures [datafusion]

2025-04-07 Thread via GitHub
alamb commented on code in PR #15404: URL: https://github.com/apache/datafusion/pull/15404#discussion_r2030917550 ## datafusion/expr-common/src/signature.rs: ## @@ -263,10 +263,6 @@ impl TypeSignatureClass { self: &TypeSignatureClass, logical_type: &NativeType,

Re: [PR] refactor: consistent null handling in coercible signatures [datafusion]

2025-03-27 Thread via GitHub
wiedld commented on code in PR #15404: URL: https://github.com/apache/datafusion/pull/15404#discussion_r2017069434 ## datafusion/sqllogictest/test_files/information_schema.slt: ## @@ -736,8 +736,11 @@ select specific_name, data_type, ordinal_position, parameter_mode, rid from i

Re: [PR] refactor: consistent null handling in coercible signatures [datafusion]

2025-03-24 Thread via GitHub
alan910127 commented on code in PR #15404: URL: https://github.com/apache/datafusion/pull/15404#discussion_r2011249477 ## datafusion/sqllogictest/test_files/information_schema.slt: ## @@ -736,8 +736,11 @@ select specific_name, data_type, ordinal_position, parameter_mode, rid fr

[PR] refactor: consistent null handling in coercible signatures [datafusion]

2025-03-24 Thread via GitHub
alan910127 opened a new pull request, #15404: URL: https://github.com/apache/datafusion/pull/15404 ## Which issue does this PR close? - Closes #15013. ## Rationale for this change Currently, there are a special case for null handling in `TypeSignatureClass::m