wiedld commented on code in PR #15404: URL: https://github.com/apache/datafusion/pull/15404#discussion_r2017069434
########## datafusion/sqllogictest/test_files/information_schema.slt: ########## @@ -736,8 +736,11 @@ select specific_name, data_type, ordinal_position, parameter_mode, rid from info repeat Int64 2 IN 0 repeat Int64 2 IN 1 repeat Int64 2 IN 2 +repeat Int64 2 IN 3 repeat LargeUtf8 1 IN 1 repeat LargeUtf8 1 OUT 1 +repeat Null 1 IN 3 +repeat Null 1 OUT 3 Review Comment: I think this makes sense? Since it was previously accepted by the `matches_native_type` without needing to be listed as one of the possible signatures. Now we have added to the possible cartesian products [per here.](https://github.com/apache/datafusion/blob/dc073ffd9b9dd100c688f087b15922ac8157ad93/datafusion/expr-common/src/signature.rs#L486-L503) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
