alamb commented on code in PR #15404:
URL: https://github.com/apache/datafusion/pull/15404#discussion_r2030917550
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -263,10 +263,6 @@ impl TypeSignatureClass {
self: &TypeSignatureClass,
logical_type: &NativeType,
) -> bool {
- if logical_type == &NativeType::Null {
Review Comment:
The PR description says
> Are there any user-facing changes?
> No.
However, doesn't this change means that existing TypeSignature::Coercable
that handle Nulls will need to add `Coercion::new_implicit` to retain the same
behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
